[COMMITTERS] pgsql: Rename GinLogicValue to GinTernaryValue.

2014-03-31 Thread Heikki Linnakangas
Rename GinLogicValue to GinTernaryValue. It's more descriptive. Also, get rid of the enum, and use #defines instead, per Greg Stark's suggestion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0cfa34c25a7c8e7017cac346d954016fad0dfc16 Modified Files -- s

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-31 Thread Heikki Linnakangas
On 03/23/2014 06:07 PM, Greg Stark wrote: On Sun, Mar 23, 2014 at 1:22 PM, Heikki Linnakangas wrote: The reason for the typedef is precisely that an enum is not guaranteed to be one byte. Tom suggested getting rid of the typedef, but it's needed to make sure it's stored as one byte. I'll go

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-31 Thread Andres Freund
On 2014-03-31 10:31:00 +0300, Heikki Linnakangas wrote: > On 03/23/2014 06:07 PM, Greg Stark wrote: > >On Sun, Mar 23, 2014 at 1:22 PM, Heikki Linnakangas >>wrote: > > > >>The reason for the typedef is precisely that an enum is not guaranteed to > >>be one byte. Tom suggested getting rid of the ty

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-31 Thread Heikki Linnakangas
On 03/31/2014 12:25 PM, Andres Freund wrote: On 2014-03-31 10:31:00 +0300, Heikki Linnakangas wrote: On 03/23/2014 06:07 PM, Greg Stark wrote: On Sun, Mar 23, 2014 at 1:22 PM, Heikki Linnakangas wrote: The reason for the typedef is precisely that an enum is not guaranteed to be one byte. To

[COMMITTERS] pgsql: Rewrite the way GIN posting lists are packed on a page, to reduc

2014-03-31 Thread Heikki Linnakangas
Rewrite the way GIN posting lists are packed on a page, to reduce WAL volume. Inserting (in retail) into the new 9.4 format GIN posting tree created much larger WAL records than in 9.3. The previous strategy to WAL logging was basically to log the whole page on each change, with the exception of c

[COMMITTERS] pgsql: Fix thinko in logical decoding code.

2014-03-31 Thread Robert Haas
Fix thinko in logical decoding code. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f0e4be453ffd27b5f5e6c115172091abda3a38f Modified Files -- src/backend/replication/logical/logical.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[COMMITTERS] pgsql: Count buffers dirtied due to hints in pgBufferUsage.shared_blks_

2014-03-31 Thread Robert Haas
Count buffers dirtied due to hints in pgBufferUsage.shared_blks_dirtied. Previously, such buffers weren't counted, with the possible result that EXPLAIN (BUFFERS) and pg_stat_statements would understate the true number of blocks dirtied by an SQL statement. Back-patch to 9.2, where this counter w

[COMMITTERS] pgsql: Count buffers dirtied due to hints in pgBufferUsage.shared_blks_

2014-03-31 Thread Robert Haas
Count buffers dirtied due to hints in pgBufferUsage.shared_blks_dirtied. Previously, such buffers weren't counted, with the possible result that EXPLAIN (BUFFERS) and pg_stat_statements would understate the true number of blocks dirtied by an SQL statement. Back-patch to 9.2, where this counter w

[COMMITTERS] pgsql: Count buffers dirtied due to hints in pgBufferUsage.shared_blks_

2014-03-31 Thread Robert Haas
Count buffers dirtied due to hints in pgBufferUsage.shared_blks_dirtied. Previously, such buffers weren't counted, with the possible result that EXPLAIN (BUFFERS) and pg_stat_statements would understate the true number of blocks dirtied by an SQL statement. Back-patch to 9.2, where this counter w

[COMMITTERS] pgsql: test_decoding: Update .gitignore

2014-03-31 Thread Robert Haas
test_decoding: Update .gitignore Commit 7317d8d961f210c3a6b20972cd605bcd9bffb06e changed the set of things that need to be ignored, but neglected to update .gitignore. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0f95b723eb207ca8fe2a0391b444db23b386617b Modified

[COMMITTERS] pgsql: Mark FastPathStrongRelationLocks volatile.

2014-03-31 Thread Robert Haas
Mark FastPathStrongRelationLocks volatile. Otherwise, the compiler might decide to move modifications to data within this structure outside the enclosing SpinLockAcquire / SpinLockRelease pair, leading to shared memory corruption. This may or may not explain a recent lmgr-related buildfarm failur

[COMMITTERS] pgsql: Mark FastPathStrongRelationLocks volatile.

2014-03-31 Thread Robert Haas
Mark FastPathStrongRelationLocks volatile. Otherwise, the compiler might decide to move modifications to data within this structure outside the enclosing SpinLockAcquire / SpinLockRelease pair, leading to shared memory corruption. This may or may not explain a recent lmgr-related buildfarm failur

[COMMITTERS] pgsql: Mark FastPathStrongRelationLocks volatile.

2014-03-31 Thread Robert Haas
Mark FastPathStrongRelationLocks volatile. Otherwise, the compiler might decide to move modifications to data within this structure outside the enclosing SpinLockAcquire / SpinLockRelease pair, leading to shared memory corruption. This may or may not explain a recent lmgr-related buildfarm failur

[COMMITTERS] pgsql: Fix typo in comment.

2014-03-31 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/554bb3beba27bf4a49edecc40f6c0f249974bc7c Modified Files -- contrib/sepgsql/relation.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix typo in comment.

2014-03-31 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b924d4cdc0a95c6af0a57d4e78dbd3d7f1b39775 Modified Files -- contrib/sepgsql/relation.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-co

[COMMITTERS] pgsql: Fix typo in comment.

2014-03-31 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d747c6da6aedbbf141870136d1782f23c837029c Modified Files -- contrib/sepgsql/relation.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-co

[COMMITTERS] pgsql: Fix typo in comment.

2014-03-31 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7ef17dd71db11f2ac03154ec48fa0d5594b026de Modified Files -- contrib/sepgsql/relation.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-co