[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7d1e0e8d7a96ac2be5c3ce0e68a5c4eb65fccff2 Modified Files -- src/backend/access/nbtree/nbtinsert.c

[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/129b8adbc8cd7acd435904890a12888ead7a5ba4 Modified Files -- src/backend/access/nbtree/nbtinsert.c |

[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/895243d69ba1972157d8d2644efbf87d557abec3 Modified Files -- src/backend/access/nbtree/nbtinsert.c |

[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1891a4b6b8ad2bcdd290380a89cbb4dc160adbb8 Modified Files -- src/backend/access/nbtree/nbtinsert.c

[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/877b088785b178c50e7976d86c82dfafa4031792 Modified Files -- src/backend/access/nbtree/nbtinsert.c | 55

[COMMITTERS] pgsql: Avoid allocations in critical sections.

2014-04-04 Thread Heikki Linnakangas
Avoid allocations in critical sections. If a palloc in a critical section fails, it becomes a PANIC. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/af7004ed6c0e5b052daee1760bf12179d40166d8 Modified Files -- src/backend/access/nbtree/nbtinsert.c |

[COMMITTERS] pgsql: Add an Assertion that you don't palloc within a critical section

2014-04-04 Thread Heikki Linnakangas
Add an Assertion that you don't palloc within a critical section. This caught a bunch of cases doing that already, which I just fixed in previous commit. This is the assertion itself. Per Tom Lane's idea. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4a170ee9e0ebd

[COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti

2014-04-04 Thread Heikki Linnakangas
In checkpoint, move the check for in-progress xacts out of critical section. GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical section. I thought I covered this case with the exemption for the checkpointer, but CreateCheckPoint is also called from the startup process. Branc

[COMMITTERS] pgsql: Move multixid allocation out of critical section.

2014-04-04 Thread Heikki Linnakangas
Move multixid allocation out of critical section. It can fail if you run out of memory. This call was added in 9.3, so backpatch to 9.3 only. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a2f9572ca507bfcb71bcf1b81b563e5094fd6904 Modified Files

[COMMITTERS] pgsql: Move multixid allocation out of critical section.

2014-04-04 Thread Heikki Linnakangas
Move multixid allocation out of critical section. It can fail if you run out of memory. This call was added in 9.3, so backpatch to 9.3 only. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b1236f4b7ba2c05542f44d07c0a9ffbec3b66295 Modified Files -- src/

[COMMITTERS] pgsql: Fix some compiler warnings that clang emits with -pedantic.

2014-04-04 Thread Robert Haas
Fix some compiler warnings that clang emits with -pedantic. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/59202fae0434c98beb4994c5fe4df354a6af31e6 Modified Files -- src/backend/access/transam/xlog.c |2 +- src/bin/pg_dump/parallel.c

[COMMITTERS] pgsql: Fix bogus time printout in walreceiver's debug log messages.

2014-04-04 Thread Tom Lane
Fix bogus time printout in walreceiver's debug log messages. The displayed sendtime and receipttime were always exactly equal, because somebody forgot that timestamptz_to_str returns a static buffer (thereby simplifying life for most callers, at the cost of complicating it for those who need two r

[COMMITTERS] pgsql: Fix bogus time printout in walreceiver's debug log messages.

2014-04-04 Thread Tom Lane
Fix bogus time printout in walreceiver's debug log messages. The displayed sendtime and receipttime were always exactly equal, because somebody forgot that timestamptz_to_str returns a static buffer (thereby simplifying life for most callers, at the cost of complicating it for those who need two r

[COMMITTERS] pgsql: Fix bogus time printout in walreceiver's debug log messages.

2014-04-04 Thread Tom Lane
Fix bogus time printout in walreceiver's debug log messages. The displayed sendtime and receipttime were always exactly equal, because somebody forgot that timestamptz_to_str returns a static buffer (thereby simplifying life for most callers, at the cost of complicating it for those who need two r

[COMMITTERS] pgsql: Make sure -D is an absolute path when starting server on Windows

2014-04-04 Thread Tom Lane
Make sure -D is an absolute path when starting server on Windows. This is needed because Windows services may get started with a different current directory than where pg_ctl is executed. We want relative -D paths to be interpreted relative to pg_ctl's CWD, similarly to what happens on other plat

[COMMITTERS] pgsql: Preserve errno across free().

2014-04-04 Thread Tom Lane
Preserve errno across free(). Dept. of second thoughts: free() isn't guaranteed not to change errno. Make sure we report the right error if getcwd() fails. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2209c0f8618bbed257975055e017efab139e3fa3 Modified Files --

[COMMITTERS] pgsql: Allow "-C variable" and "--describe-config" even to root users.

2014-04-04 Thread Tom Lane
Allow "-C variable" and "--describe-config" even to root users. There's no really compelling reason to refuse to do these read-only, non-server-starting options as root, and there's at least one good reason to allow -C: pg_ctl uses -C to find out the true data directory location when pointed at a

[COMMITTERS] pgsql: Allow "-C variable" and "--describe-config" even to root users.

2014-04-04 Thread Tom Lane
Allow "-C variable" and "--describe-config" even to root users. There's no really compelling reason to refuse to do these read-only, non-server-starting options as root, and there's at least one good reason to allow -C: pg_ctl uses -C to find out the true data directory location when pointed at a

[COMMITTERS] pgsql: Allow "-C variable" and "--describe-config" even to root users.

2014-04-04 Thread Tom Lane
Allow "-C variable" and "--describe-config" even to root users. There's no really compelling reason to refuse to do these read-only, non-server-starting options as root, and there's at least one good reason to allow -C: pg_ctl uses -C to find out the true data directory location when pointed at a

[COMMITTERS] pgsql: Fix tablespace creation WAL replay to work on Windows.

2014-04-04 Thread Tom Lane
Fix tablespace creation WAL replay to work on Windows. The code segment that removes the old symlink (if present) wasn't clued into the fact that on Windows, symlinks are junction points which have to be removed with rmdir(). Backpatch to 9.0, where the failing code was introduced. MauMau, revie

[COMMITTERS] pgsql: Fix tablespace creation WAL replay to work on Windows.

2014-04-04 Thread Tom Lane
Fix tablespace creation WAL replay to work on Windows. The code segment that removes the old symlink (if present) wasn't clued into the fact that on Windows, symlinks are junction points which have to be removed with rmdir(). Backpatch to 9.0, where the failing code was introduced. MauMau, revie

[COMMITTERS] pgsql: Fix tablespace creation WAL replay to work on Windows.

2014-04-04 Thread Tom Lane
Fix tablespace creation WAL replay to work on Windows. The code segment that removes the old symlink (if present) wasn't clued into the fact that on Windows, symlinks are junction points which have to be removed with rmdir(). Backpatch to 9.0, where the failing code was introduced. MauMau, revie

[COMMITTERS] pgsql: Fix tablespace creation WAL replay to work on Windows.

2014-04-04 Thread Tom Lane
Fix tablespace creation WAL replay to work on Windows. The code segment that removes the old symlink (if present) wasn't clued into the fact that on Windows, symlinks are junction points which have to be removed with rmdir(). Backpatch to 9.0, where the failing code was introduced. MauMau, revie

[COMMITTERS] pgsql: Fix tablespace creation WAL replay to work on Windows.

2014-04-04 Thread Tom Lane
Fix tablespace creation WAL replay to work on Windows. The code segment that removes the old symlink (if present) wasn't clued into the fact that on Windows, symlinks are junction points which have to be removed with rmdir(). Backpatch to 9.0, where the failing code was introduced. MauMau, revie

[COMMITTERS] pgsql: ecpg/ecpglib must build the src/port files it uses with -DFRONTE

2014-04-04 Thread Tom Lane
ecpg/ecpglib must build the src/port files it uses with -DFRONTEND. Remarkably, this hasn't been noticed before, though it surely should have been happening since around the fall of the Byzantine empire. Commit 438b529604 changed path.c to depend on FRONTEND, and that exposed the omission, per bui