[COMMITTERS] pgsql: GIN entry pages follow the standard page layout - tell XLogInser

2014-04-14 Thread Heikki Linnakangas
GIN entry pages follow the standard page layout - tell XLogInsert. The entry B-tree pages all follow the standard page layout. The 9.3 code has this right. I inadvertently changed this at some point during the big refactorings in git master. Branch -- master Details --- http://git.postgr

[COMMITTERS] pgsql: Remove dead checks for invalid left page in ginDeletePage.

2014-04-14 Thread Heikki Linnakangas
Remove dead checks for invalid left page in ginDeletePage. In some places, the function assumes the left page is valid, and in others, it checks if it is valid. Remove all the checks. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e3e6e3af560116adc20cc9d6e75bfe82a45

[COMMITTERS] pgsql: Tab completion for event triggers.

2014-04-14 Thread Robert Haas
Tab completion for event triggers. Ian Barwick Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7b979524afb21c969234f7a0a9b1c97ceec4629d Modified Files -- src/bin/psql/tab-complete.c | 88 +-- 1 file changed, 85 in

Re: [COMMITTERS] pgsql: Don't forget to flush XLOG_PARAMETER_CHANGE record.

2014-04-14 Thread Fujii Masao
On Wed, Mar 26, 2014 at 4:59 AM, Tom Lane wrote: > Robert Haas writes: >> This commit message doesn't give any indication of what the >> consequences of this oversight are. I think that's generally a good >> thing to include. > > Yes, please. We (usually Bruce or I) make release notes based on t

Re: [COMMITTERS] pgsql: Don't forget to flush XLOG_PARAMETER_CHANGE record.

2014-04-14 Thread Fujii Masao
On Wed, Mar 26, 2014 at 5:39 AM, Simon Riggs wrote: > On 25 March 2014 19:59, Tom Lane wrote: >> Robert Haas writes: >>> This commit message doesn't give any indication of what the >>> consequences of this oversight are. I think that's generally a good >>> thing to include. >> >> Yes, please. W

[COMMITTERS] pgsql: Update list of relation types on which ALTER TABLE RENAME/OWNER

2014-04-14 Thread Robert Haas
Update list of relation types on which ALTER TABLE RENAME/OWNER work. Etsuro Fujita Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0c953540d285a94684b0c0dc7a2c338cb1d65ef0 Modified Files -- doc/src/sgml/ref/alter_table.sgml |9 + 1 file chang

[COMMITTERS] pgsql: Correct description of constraint_name in ALTER TABLE documentat

2014-04-14 Thread Robert Haas
Correct description of constraint_name in ALTER TABLE documentation. Apparently, the old text was written at a time when the only use of constraint_name here was for a constraint to be dropped, but that's no longer true. Etsuro Fujita Branch -- master Details --- http://git.postgresql.o

[COMMITTERS] pgsql: Fix bogus handling of bad strategy number in GIST consistent() f

2014-04-14 Thread Tom Lane
Fix bogus handling of bad strategy number in GIST consistent() functions. Make sure we throw an error instead of silently doing the wrong thing when fed a strategy number we don't recognize. Also, in the places that did already throw an error, spell the error message in a way more consistent with

[COMMITTERS] pgsql: doc: Update yet another place that didn't get the memo about mat

2014-04-14 Thread Robert Haas
doc: Update yet another place that didn't get the memo about matviews. Etsuro Fujita Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c050b2aae3b2f745ef61b379087cf9a67deea293 Modified Files -- doc/src/sgml/ref/create_foreign_table.sgml |2 +- 1 file ch

[COMMITTERS] pgsql: doc: Suggesting clearing pg_replslot from a hot filesystem backu

2014-04-14 Thread Robert Haas
doc: Suggesting clearing pg_replslot from a hot filesystem backup. Maybe we'll settle on another way of solving this problem, but for now this is the recommended procedure. Per discussion with Michael Paquier. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/69671ab5

[COMMITTERS] pgsql: Set pd_lower on internal GIN posting tree pages.

2014-04-14 Thread Heikki Linnakangas
Set pd_lower on internal GIN posting tree pages. This allows squeezing out the unused space in full-page writes. And more importantly, it can be a useful debugging aid. In hindsight we should've done this back when GIN was added - we wouldn't need the 'maxoff' field in the page opaque struct if w

[COMMITTERS] pgsql: Fix whitespace

2014-04-14 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7b5a9d61a8202c46f4cc02878eafa8367080c59a Modified Files -- src/interfaces/ecpg/preproc/type.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailin

[COMMITTERS] pgsql: Add @configure_input@ marker to Makefile.global.in

2014-04-14 Thread Peter Eisentraut
Add @configure_input@ marker to Makefile.global.in That way, when looking at Makefile.global, we don't get confused by the comment that claims that this is Makefile.global.in. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e3fd9327384abc1cd252ddd8ce9429ab7bef48b5 M

[COMMITTERS] pgsql: Add TAP tests for client programs

2014-04-14 Thread Peter Eisentraut
Add TAP tests for client programs Reviewed-by: Pavel Stěhule Reviewed-by: Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7d0f493f19607774fdccb1a1ea06fdd96a3d9698 Modified Files -- GNUmakefile.in |4 +- c

[COMMITTERS] pgsql: Have lcov call the right gcov

2014-04-14 Thread Peter Eisentraut
Have lcov call the right gcov By default, lcov will call whatever gcov it can find in the path. But if the user has specified a different gcov to configure, this could be incompatible. So tell lcov explicitly with an option which gcov program to call. Branch -- master Details --- http:

[COMMITTERS] pgsql: vacuumdb: Add option --analyze-in-stages

2014-04-14 Thread Peter Eisentraut
vacuumdb: Add option --analyze-in-stages Add vacuumdb option --analyze-in-stages which runs ANALYZE three times with different configuration settings, adopting the logic from the analyze_new_cluster.sh script that pg_upgrade generates. That way, users of pg_dump/pg_restore can also use that funct