[COMMITTERS] pgsql: Initialize tsId and dbId fields in WAL record of COMMIT PREPARED

2014-05-16 Thread Heikki Linnakangas
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED. Commit dd428c79 added dbId and tsId to the xl_xact_commit struct but missed that prepared transaction commits reuse that struct. Fix that. Because those fields were left unitialized, replaying a commit prepared WAL record in a hot

[COMMITTERS] pgsql: Initialize tsId and dbId fields in WAL record of COMMIT PREPARED

2014-05-16 Thread Heikki Linnakangas
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED. Commit dd428c79 added dbId and tsId to the xl_xact_commit struct but missed that prepared transaction commits reuse that struct. Fix that. Because those fields were left unitialized, replaying a commit prepared WAL record in a hot

[COMMITTERS] pgsql: Initialize tsId and dbId fields in WAL record of COMMIT PREPARED

2014-05-16 Thread Heikki Linnakangas
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED. Commit dd428c79 added dbId and tsId to the xl_xact_commit struct but missed that prepared transaction commits reuse that struct. Fix that. Because those fields were left unitialized, replaying a commit prepared WAL record in a hot

[COMMITTERS] pgsql: Initialize tsId and dbId fields in WAL record of COMMIT PREPARED

2014-05-16 Thread Heikki Linnakangas
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED. Commit dd428c79 added dbId and tsId to the xl_xact_commit struct but missed that prepared transaction commits reuse that struct. Fix that. Because those fields were left unitialized, replaying a commit prepared WAL record in a hot

[COMMITTERS] pgsql: Initialize tsId and dbId fields in WAL record of COMMIT PREPARED

2014-05-16 Thread Heikki Linnakangas
Initialize tsId and dbId fields in WAL record of COMMIT PREPARED. Commit dd428c79 added dbId and tsId to the xl_xact_commit struct but missed that prepared transaction commits reuse that struct. Fix that. Because those fields were left unitialized, replaying a commit prepared WAL record in a hot

[COMMITTERS] pgsql: Open output file before sleeping in pg_recvlogical.

2014-05-16 Thread Heikki Linnakangas
Open output file before sleeping in pg_recvlogical. Let's complain about e.g an invalid path or permission problem sooner rather than later. Before this patch, we would only try to open the output file after receiving the first decoded message from the server. Branch -- master Details --

[COMMITTERS] pgsql: Fix thinko in logical decoding of commit-prepared records.

2014-05-16 Thread Heikki Linnakangas
Fix thinko in logical decoding of commit-prepared records. The decoding of prepared transaction commits accidentally used the XID of the transaction performing the COMMIT PREPARED, not the XID of the prepared transaction. Before bb38fb0d43c8d that lead to those transactions not being decoded, afte

[COMMITTERS] pgsql: Add test case for logical decoding of prepared transactions.

2014-05-16 Thread Heikki Linnakangas
Add test case for logical decoding of prepared transactions. Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d900e192a3ef2dd73fae4522c35aadce6d72a534 Modified Files -- contrib/test_decoding/Makefile |2 +- contrib/test_decod

[COMMITTERS] pgsql: Fix test_decoding test case's check that slot has been dropped.

2014-05-16 Thread Heikki Linnakangas
Fix test_decoding test case's check that slot has been dropped. pg_stat_replication shows connected replication clients. The ddl test case never has any replication clients connected, so querying pg_stat_replication is pointless. To check that a slot has been dropped correctly, query pg_replicatio

[COMMITTERS] pgsql: Fix valgrind warning for btree_gist indexes on macaddr.

2014-05-16 Thread Tom Lane
Fix valgrind warning for btree_gist indexes on macaddr. The macaddr opclass stores two macaddr structs (each of size 6) in an index column that's declared as being of type gbtreekey16, ie 16 bytes. In the original coding this led to passing a palloc'd value of size 12 to the index insertion code,

[COMMITTERS] pgsql: Fix a second cause of undersized pallocs for btree_gist indexes

2014-05-16 Thread Tom Lane
Fix a second cause of undersized pallocs for btree_gist indexes on macaddr. gbt_macad_union also allocated 12-byte structs where we really need 16. Per report from Andres Freund. No back-patch since there's no current risk of a real problem. Branch -- master Details --- http://git.post

[COMMITTERS] pgsql: Suppress some more valgrind whining about btree_gist.

2014-05-16 Thread Tom Lane
Suppress some more valgrind whining about btree_gist. A couple of functions didn't bother to zero out pad bytes in datums that would ultimately go to disk. Harmless, but valgrind doesn't know that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/af215d8190e6ab170c02

[COMMITTERS] pgsql: Make sure chr(int) can't create invalid UTF8 sequences.

2014-05-16 Thread Tom Lane
Make sure chr(int) can't create invalid UTF8 sequences. Several years ago we changed chr(int) so that if the database encoding is UTF8, it would interpret its argument as a Unicode code point and expand it into the appropriate multibyte sequence. However, we weren't sufficiently careful about che

[COMMITTERS] pgsql: Tag refs/tags/REL9_4_BETA1 was created

2014-05-16 Thread pgsql
Tag refs/tags/REL9_4_BETA1 was created. -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers