[COMMITTERS] pgsql: Rename pg_recvlogical's --create/--drop to --create-slot/--drop-

2014-10-06 Thread Andres Freund
Rename pg_recvlogical's --create/--drop to --create-slot/--drop-slot. A future patch (9.5 only) adds slot management to pg_receivexlog. The verbs create/drop don't seem descriptive enough there. It seems better to rename pg_recvlogical's commands now, in beta, than live with the inconsistency fore

[COMMITTERS] pgsql: Rename pg_recvlogical's --create/--drop to --create-slot/--drop-

2014-10-06 Thread Andres Freund
Rename pg_recvlogical's --create/--drop to --create-slot/--drop-slot. A future patch (9.5 only) adds slot management to pg_receivexlog. The verbs create/drop don't seem descriptive enough there. It seems better to rename pg_recvlogical's commands now, in beta, than live with the inconsistency fore

[COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Andres Freund
Add support for managing physical replication slots to pg_receivexlog. pg_receivexlog already has the capability to use a replication slot to reserve WAL on the upstream node. But the used slot currently has to be created via SQL. To allow using slots directly, without involving SQL, add --create

[COMMITTERS] pgsql: Clean up Create/DropReplicationSlot query buffer

2014-10-06 Thread Stephen Frost
Clean up Create/DropReplicationSlot query buffer CreateReplicationSlot() and DropReplicationSlot() were not cleaning up the query buffer in some cases (mostly error conditions) which meant a small leak. Not generally an issue as the error case would result in an immediate exit, but not difficult

[COMMITTERS] Re: pgsql: Refactor replication connection code of various pg_basebackup ut

2014-10-06 Thread Stephen Frost
* Andres Freund ([email protected]) wrote: > I can't get very excited about this - but I also have no problems fixing > it. I'm fine with you committing what you have. Or would you rather have > me do it? Done. Thanks! Stephen signature.asc Description: Digital signatu

[COMMITTERS] pgsql: Stamp 9.4beta3.

2014-10-06 Thread Tom Lane
Stamp 9.4beta3. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/abc1a8e509180a96dab45538643abeb25a955190 Modified Files -- configure | 18 +- configure.in |2 +- doc/bug.template

Re: [COMMITTERS] pgsql: Check for GiST index tuples that don't fit on a page.

2014-10-06 Thread Peter Eisentraut
On Sat, 2014-10-04 at 11:10 -0300, Alvaro Herrera wrote: > I compiled 9.0 yesterday and there are a lot of warnings with my > current > compiler; something like -Werror is right out, I think. Maybe we can > save warnings separately and have the member turn yellow if there are > any, or something l

Re: [COMMITTERS] pgsql: Check for GiST index tuples that don't fit on a page.

2014-10-06 Thread Peter Eisentraut
On Sun, 2014-10-05 at 10:06 +0300, Heikki Linnakangas wrote: > Hmm. For this particular case, it would straightforward to add a step to > the buildfarm script to do "grep -r '%z' src". It might turn up false > positives, if there's a %z in comments or such, but it shouldn't be much > effort to m

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix array overrun in ecpg's version of ParseDateTime().

2014-10-06 Thread Tom Lane
Fix array overrun in ecpg's version of ParseDateTime(). The code wrote a value into the caller's field[] array before checking to see if there was room, which of course is backwards. Per report from Michael Paquier. I fixed the equivalent bug in the backend's version of this code way back in 630

[COMMITTERS] pgsql: Fix typo in elog message.

2014-10-06 Thread Robert Haas
Fix typo in elog message. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c421efd21330f2e5bed253b4a53d7ea5e084edf6 Modified Files -- src/backend/commands/policy.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mail

Re: [COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Fujii Masao
On Mon, Oct 6, 2014 at 7:57 PM, Andres Freund wrote: > Add support for managing physical replication slots to pg_receivexlog. > > pg_receivexlog already has the capability to use a replication slot to > reserve WAL on the upstream node. But the used slot currently has to > be created via SQL. > >

Re: [COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Andres Freund
On 2014-10-07 14:21:59 +0900, Fujii Masao wrote: > On Mon, Oct 6, 2014 at 7:57 PM, Andres Freund wrote: > > Add support for managing physical replication slots to pg_receivexlog. > > > > pg_receivexlog already has the capability to use a replication slot to > > reserve WAL on the upstream node. Bu

Re: [COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Fujii Masao
On Tue, Oct 7, 2014 at 2:29 PM, Andres Freund wrote: > On 2014-10-07 14:21:59 +0900, Fujii Masao wrote: >> On Mon, Oct 6, 2014 at 7:57 PM, Andres Freund wrote: >> > Add support for managing physical replication slots to pg_receivexlog. >> > >> > pg_receivexlog already has the capability to use a

Re: [COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Andres Freund
On 2014-10-07 14:51:59 +0900, Fujii Masao wrote: > >> *** a/src/bin/pg_basebackup/pg_receivexlog.c > >> --- b/src/bin/pg_basebackup/pg_receivexlog.c > >> *** > >> *** 591,596 main(int argc, char **argv) > >> --- 591,598 > >> disconnect_and_exit(1); > >>

Re: [COMMITTERS] pgsql: Add support for managing physical replication slots to pg_receiv

2014-10-06 Thread Fujii Masao
On Tue, Oct 7, 2014 at 2:55 PM, Andres Freund wrote: > On 2014-10-07 14:51:59 +0900, Fujii Masao wrote: >> >> *** a/src/bin/pg_basebackup/pg_receivexlog.c >> >> --- b/src/bin/pg_basebackup/pg_receivexlog.c >> >> *** >> >> *** 591,596 main(int argc, char **argv) >> >> --- 591,598 -