[COMMITTERS] pgsql: psql: complain if pg_dump custom-format is detected

2014-10-24 Thread Alvaro Herrera
psql: complain if pg_dump custom-format is detected Apparently, this is a very common mistake for users to make; it is better to have it fail reasonably rather than throw potentially a large number of errors. Since we have a magic string at the start of the file, we can detect the case easily and

[COMMITTERS] pgsql: Fix off-by-one error in 2781b4bea7db357be59f9a5fd73ca1eb12ff5a79

2014-10-24 Thread Robert Haas
Fix off-by-one error in 2781b4bea7db357be59f9a5fd73ca1eb12ff5a79. Spotted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/85bb81de530aed0f4fc3dec85c5cfbd3befd Modified Files -- src/backend/commands/trigger.c |5 +++-- 1 file changed,

[COMMITTERS] pgsql: Oops, the commit accept pg_controldata -D datadir missed code ch

2014-10-24 Thread Heikki Linnakangas
Oops, the commit accept pg_controldata -D datadir missed code changes. I updated the docs and usage blurp, but forgot to commit the code changes required. Spotted by Michael Paquier. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/22b743b2ca18a692ba8d91bc18e7c42a8b7

[COMMITTERS] pgsql: Complain if too many options are passed to pg_controldata or pg_

2014-10-24 Thread Heikki Linnakangas
Complain if too many options are passed to pg_controldata or pg_resetxlog. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2d53003432f8560b9c3adf569118747c8ac8447d Modified Files -- src/bin/pg_controldata/pg_controldata.c | 10 ++ src/bin/pg_rese

[COMMITTERS] pgsql: Forgot #include "pg_getopt.h", now that pg_controldata uses geto

2014-10-24 Thread Heikki Linnakangas
Forgot #include "pg_getopt.h", now that pg_controldata uses getopt. Needed at least on Windows. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c0c1f6fc97088100a710e7e9c2e74b775985083d Modified Files -- src/bin/pg_controldata/pg_controldata.c |1 + 1

[COMMITTERS] pgsql: Make the locale comparison in pg_upgrade more lenient

2014-10-24 Thread Heikki Linnakangas
Make the locale comparison in pg_upgrade more lenient If the locale names are not equal, try to canonicalize both of them by passing them to setlocale(). Before, we only canonicalized the old cluster's locale if upgrading from a 8.4-9.2 server, but we also need to canonicalize when upgrading from

[COMMITTERS] pgsql: Make the locale comparison in pg_upgrade more lenient

2014-10-24 Thread Heikki Linnakangas
Make the locale comparison in pg_upgrade more lenient If the locale names are not equal, try to canonicalize both of them by passing them to setlocale(). Before, we only canonicalized the old cluster's locale if upgrading from a 8.4-9.2 server, but we also need to canonicalize when upgrading from

[COMMITTERS] pgsql: Make the locale comparison in pg_upgrade more lenient

2014-10-24 Thread Heikki Linnakangas
Make the locale comparison in pg_upgrade more lenient If the locale names are not equal, try to canonicalize both of them by passing them to setlocale(). Before, we only canonicalized the old cluster's locale if upgrading from a 8.4-9.2 server, but we also need to canonicalize when upgrading from

[COMMITTERS] pgsql: Work around Windows locale name with non-ASCII character.

2014-10-24 Thread Heikki Linnakangas
Work around Windows locale name with non-ASCII character. Windows has one a locale whose name contains a non-ASCII character: "Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes trouble; when passing it setlocale(), it's not clear what encoding the argument should be in. Another p

[COMMITTERS] pgsql: Work around Windows locale name with non-ASCII character.

2014-10-24 Thread Heikki Linnakangas
Work around Windows locale name with non-ASCII character. Windows has one a locale whose name contains a non-ASCII character: "Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes trouble; when passing it setlocale(), it's not clear what encoding the argument should be in. Another p

[COMMITTERS] pgsql: Work around Windows locale name with non-ASCII character.

2014-10-24 Thread Heikki Linnakangas
Work around Windows locale name with non-ASCII character. Windows has one a locale whose name contains a non-ASCII character: "Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes trouble; when passing it setlocale(), it's not clear what encoding the argument should be in. Another p

[COMMITTERS] pgsql: Work around Windows locale name with non-ASCII character.

2014-10-24 Thread Heikki Linnakangas
Work around Windows locale name with non-ASCII character. Windows has one a locale whose name contains a non-ASCII character: "Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes trouble; when passing it setlocale(), it's not clear what encoding the argument should be in. Another p