[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Reset error message at PQreset()

2014-10-29 Thread Heikki Linnakangas
Reset error message at PQreset() If you call PQreset() repeatedly, and the connection cannot be re-established, the error messages from the failed connection attempts kept accumulating in the error string. Fixes bug #11455 reported by Caleb Epstein. Backpatch to all supported versions. Branch --

[COMMITTERS] pgsql: Avoid setup work for invalidation messages at start-of-(sub)xact

2014-10-29 Thread Robert Haas
Avoid setup work for invalidation messages at start-of-(sub)xact. Instead of initializing a new TransInvalidationInfo for every transaction or subtransaction, we can just do it for those transactions or subtransactions that actually need to queue invalidation messages. That also avoids needing to

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Tom Lane
Avoid corrupting tables when ANALYZE inside a transaction is rolled back. VACUUM and ANALYZE update the target table's pg_class row in-place, that is nontransactionally. This is OK, more or less, for the statistical columns, which are mostly nontransactional anyhow. It's not so OK for the DDL hi

[COMMITTERS] pgsql: Remove use of TAP subtests

2014-10-29 Thread Peter Eisentraut
Remove use of TAP subtests They turned out to be too much of a portability headache, because they need a fairly new version of Test::More to work properly. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ae3eb9b8ef5638610da05038e40229d4f4e5c1fd Modified Files

[COMMITTERS] pgsql: Remove use of TAP subtests

2014-10-29 Thread Peter Eisentraut
Remove use of TAP subtests They turned out to be too much of a portability headache, because they need a fairly new version of Test::More to work properly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7912f9b7dc9e2d3f6cd81892ef6aa797578e9f06 Modified Files --

[COMMITTERS] Re: pgsql: Avoid corrupting tables when ANALYZE inside a transaction is rol

2014-10-29 Thread Noah Misch
On Wed, Oct 29, 2014 at 10:12:44PM +, Tom Lane wrote: > Avoid corrupting tables when ANALYZE inside a transaction is rolled back. > > VACUUM and ANALYZE update the target table's pg_class row in-place, that is > nontransactionally. This is OK, more or less, for the statistical columns, > whic