[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

[COMMITTERS] pgsql: Check return value of strdup() in libpq connection option parsin

2014-11-25 Thread Heikki Linnakangas
Check return value of strdup() in libpq connection option parsing. An out-of-memory in most of these would lead to strange behavior, like connecting to a different database than intended, but some would lead to an outright segfault. Alex Shulgin and me. Backpatch to all supported versions. Branc

Re: [COMMITTERS] pgsql: Add infrastructure to save and restore GUC values.

2014-11-25 Thread Heikki Linnakangas
On 11/25/2014 12:17 AM, Robert Haas wrote: Add infrastructure to save and restore GUC values. This is further infrastructure for parallelism. Amit Khandekar, Noah Misch, Robert Haas guc.c: In function ‘EstimateGUCStateSpace’: guc.c:8506:7: warning: ‘valsize’ may be used uninitialized in this

[COMMITTERS] pgsql: Suppress DROP CASCADE notices in regression tests

2014-11-25 Thread Stephen Frost
Suppress DROP CASCADE notices in regression tests In the regression tests, when doing cascaded drops, we need to suppress the notices from DROP CASCADE or there can be transient regression failures as the order of drops can depend on the physical row order in pg_depend. Report and fix suggestion

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow "dbname" from connection string to be overridden in PQconn

2014-11-25 Thread Heikki Linnakangas
Allow "dbname" from connection string to be overridden in PQconnectDBParams If the "dbname" attribute in PQconnectDBParams contained a connection string or URI (and expand_dbname = TRUE), the database name from the connection string could not be overridden by a subsequent "dbname" keyword in the a

[COMMITTERS] pgsql: Allow using connection URI in primary_conninfo.

2014-11-25 Thread Heikki Linnakangas
Allow using connection URI in primary_conninfo. The old method of appending options to the connection string didn't work if the primary_conninfo was a postgres:// style URI, instead of a traditional connection string. Use PQconnectdbParams instead. Alex Shulgin Branch -- master Details

[COMMITTERS] pgsql: Add int64 -> int8 mapping to genbki

2014-11-25 Thread Stephen Frost
Add int64 -> int8 mapping to genbki Per discussion with Tom and Andrew, 64bit integers are no longer a problem for the catalogs, so go ahead and add the mapping from the C int64 type to the int8 SQL identification to allow using them. Patch by Adam Brightwell Branch -- master Details --

[COMMITTERS] pgsql: Support arrays as input to array_agg() and ARRAY(SELECT ...).

2014-11-25 Thread Tom Lane
Support arrays as input to array_agg() and ARRAY(SELECT ...). These cases formerly failed with errors about "could not find array type for data type". Now they yield arrays of the same element type and one higher dimension. The implementation involves creating functions with API similar to the e

[COMMITTERS] pgsql: De-reserve most statement-introducing keywords in plpgsql.

2014-11-25 Thread Tom Lane
De-reserve most statement-introducing keywords in plpgsql. Add a bit of context sensitivity to plpgsql_yylex() so that it can recognize when the word it is looking at is the first word of a new statement, and if so whether it is the target of an assignment statement. When we are at start of statem

[COMMITTERS] pgsql: action_at_recovery_target recovery config option

2014-11-25 Thread Simon Riggs
action_at_recovery_target recovery config option action_at_recovery_target = pause | promote | shutdown Petr Jelinek Reviewed by Muhammad Asif Naeem, Fujji Masao and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/aedccb1f6fef988af1d1a25b78151f3773954b4

[COMMITTERS] pgsql: Fix uninitialized-variable warning.

2014-11-25 Thread Tom Lane
Fix uninitialized-variable warning. In passing, add an Assert defending the presumption that bytes_left is positive to start with. (I'm not exactly convinced that using an unsigned type was such a bright thing here, but let's at least do this much.) Branch -- master Details --- http://g

Re: [COMMITTERS] pgsql: Add infrastructure to save and restore GUC values.

2014-11-25 Thread Tom Lane
Heikki Linnakangas writes: > On 11/25/2014 12:17 AM, Robert Haas wrote: >> Add infrastructure to save and restore GUC values. > guc.c: In function ‘EstimateGUCStateSpace’: > guc.c:8506:7: warning: ‘valsize’ may be used uninitialized in this > function [-Wmaybe-uninitialized] >Size v

[COMMITTERS] pgsql: Remove extraneous SGML tag

2014-11-25 Thread Simon Riggs
Remove extraneous SGML tag Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b7a715800a45be00c513ce9c4371fd47b5324d34 Modified Files -- doc/src/sgml/recovery-config.sgml |2 -- 1 file changed, 2 deletions(-) -- Sent via pgsql-committers mailing list (

Re: [COMMITTERS] pgsql: action_at_recovery_target recovery config option

2014-11-25 Thread Stefan Kaltenbrunner
On 11/25/2014 09:14 PM, Simon Riggs wrote: > action_at_recovery_target recovery config option > > action_at_recovery_target = pause | promote | shutdown > > Petr Jelinek > > Reviewed by Muhammad Asif Naeem, Fujji Masao and > Simon Riggs > > Branch > -- > master > > Details > --- > http

Re: [COMMITTERS] pgsql: action_at_recovery_target recovery config option

2014-11-25 Thread Simon Riggs
On 25 November 2014 at 21:40, Stefan Kaltenbrunner wrote: > On 11/25/2014 09:14 PM, Simon Riggs wrote: >> action_at_recovery_target recovery config option >> >> action_at_recovery_target = pause | promote | shutdown >> >> Petr Jelinek >> >> Reviewed by Muhammad Asif Naeem, Fujji Masao and >> Simon

Re: [COMMITTERS] pgsql: action_at_recovery_target recovery config option

2014-11-25 Thread Michael Paquier
On Wed, Nov 26, 2014 at 7:33 AM, Simon Riggs wrote: > On 25 November 2014 at 21:40, Stefan Kaltenbrunner > wrote: >> On 11/25/2014 09:14 PM, Simon Riggs wrote: >>> action_at_recovery_target recovery config option >>> >>> action_at_recovery_target = pause | promote | shutdown >>> >>> Petr Jelinek

Re: [COMMITTERS] pgsql: Add infrastructure to save and restore GUC values.

2014-11-25 Thread Robert Haas
On Tue, Nov 25, 2014 at 3:20 PM, Tom Lane wrote: > Heikki Linnakangas writes: >> On 11/25/2014 12:17 AM, Robert Haas wrote: >>> Add infrastructure to save and restore GUC values. > >> guc.c: In function ‘EstimateGUCStateSpace’: >> guc.c:8506:7: warning: ‘valsize’ may be used uninitialized in this

[COMMITTERS] pgsql: Attempt to suppress uninitialized variable warning.

2014-11-25 Thread Robert Haas
Attempt to suppress uninitialized variable warning. Report by Heikki Linnakangas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a6c84c770efdc85aecbef319b453c997a465bd84 Modified Files -- src/backend/utils/misc/guc.c |2 +- 1 file changed, 1 insertio

[COMMITTERS] pgsql: doc: Fix markup

2014-11-25 Thread Peter Eisentraut
doc: Fix markup Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e6f0a48a6094b4e10a81fc2de82cf896701ff396 Modified Files -- doc/src/sgml/recovery-config.sgml |1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-commit