[COMMITTERS] pgsql: dummy_seclabel: add sql/, expected/, and .gitignores

2014-12-02 Thread Alvaro Herrera
dummy_seclabel: add sql/, expected/, and .gitignores Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/332562437724845635f0e11685d11fdfe8719eb2 Modified Files -- src/test/modules/dummy_seclabel/.gitignore |4 src/test/modul

Re: [COMMITTERS] pgsql: Move security_label test

2014-12-02 Thread Alvaro Herrera
Michael Paquier wrote: > On Tue, Dec 2, 2014 at 4:13 AM, Alvaro Herrera > wrote: > > Move security_label test > > > > Rather than have the core security_label regression test depend on the > > dummy_seclabel module, have that part of the test be executed by > > dummy_seclabel itself directly. Th

[COMMITTERS] pgsql: pageinspect/BRIN: minor tweaks

2014-12-02 Thread Alvaro Herrera
pageinspect/BRIN: minor tweaks Michael Paquier Double-dash additions suggested by Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b52cb4690e0752efea440173c4923d76d2126679 Modified Files -- contrib/pageinspect/pageinspect--1.2--1.3.sql |

[COMMITTERS] pgsql: Minor cleanup of function declarations for BRIN.

2014-12-02 Thread Tom Lane
Minor cleanup of function declarations for BRIN. Get rid of PG_FUNCTION_INFO_V1() macros, which are quite inappropriate for built-in functions (possibly leftovers from testing as a loadable module?). Also, fix gratuitous inconsistency between SQL-level and C-level names of the minmax support func

[COMMITTERS] pgsql: Fix JSON aggregates to work properly when final function is re-e

2014-12-02 Thread Tom Lane
Fix JSON aggregates to work properly when final function is re-executed. Davide S. reported that json_agg() sometimes produced multiple trailing right brackets. This turns out to be because json_agg_finalfn() attaches the final right bracket, and was doing so by modifying the aggregate state in-p

[COMMITTERS] pgsql: Fix JSON aggregates to work properly when final function is re-e

2014-12-02 Thread Tom Lane
Fix JSON aggregates to work properly when final function is re-executed. Davide S. reported that json_agg() sometimes produced multiple trailing right brackets. This turns out to be because json_agg_finalfn() attaches the final right bracket, and was doing so by modifying the aggregate state in-p

Re: [COMMITTERS] pgsql: Move security_label test

2014-12-02 Thread Peter Eisentraut
On 12/2/14 9:18 AM, Alvaro Herrera wrote: >> After this module has been moved to src/test/modules, I am seeing >> > failures with make check when manually kicking the test on at least >> > OSX where I tried because expected/ and sql/ are missing. pg_regress >> > does not like that much. That's anno

[COMMITTERS] pgsql: Fix JSON aggregates to work properly when final function is re-e

2014-12-02 Thread Tom Lane
Fix JSON aggregates to work properly when final function is re-executed. Davide S. reported that json_agg() sometimes produced multiple trailing right brackets. This turns out to be because json_agg_finalfn() attaches the final right bracket, and was doing so by modifying the aggregate state in-p

Re: [COMMITTERS] pgsql: Move security_label test

2014-12-02 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 12/2/14 9:18 AM, Alvaro Herrera wrote: > >> After this module has been moved to src/test/modules, I am seeing > >> > failures with make check when manually kicking the test on at least > >> > OSX where I tried because expected/ and sql/ are missing. pg_regress > >> > do

[COMMITTERS] pgsql: Don't skip SQL backends in logical decoding for visibility compu

2014-12-02 Thread Andres Freund
Don't skip SQL backends in logical decoding for visibility computation. The logical decoding patchset introduced PROC_IN_LOGICAL_DECODING flag PGXACT flag, that allows such backends to be skipped when computing the xmin horizon/snapshots. That's fine and sensible for walsenders streaming out logic

[COMMITTERS] pgsql: Don't skip SQL backends in logical decoding for visibility compu

2014-12-02 Thread Andres Freund
Don't skip SQL backends in logical decoding for visibility computation. The logical decoding patchset introduced PROC_IN_LOGICAL_DECODING flag PGXACT flag, that allows such backends to be skipped when computing the xmin horizon/snapshots. That's fine and sensible for walsenders streaming out logic

[COMMITTERS] pgsql: Improve error messages for malformed array input strings.

2014-12-02 Thread Tom Lane
Improve error messages for malformed array input strings. Make the error messages issued by array_in() uniformly follow the style ERROR: malformed array literal: "actual input string" DETAIL: specific complaint here and rewrite many of the specific complaints to be clearer. The im

[COMMITTERS] pgsql: Improve error messages for malformed array input strings.

2014-12-02 Thread Tom Lane
Improve error messages for malformed array input strings. Make the error messages issued by array_in() uniformly follow the style ERROR: malformed array literal: "actual input string" DETAIL: specific complaint here and rewrite many of the specific complaints to be clearer. The im

[COMMITTERS] pgsql: Install kludges to fix check-world for src/test/modules

2014-12-02 Thread Alvaro Herrera
Install kludges to fix check-world for src/test/modules check-world failed in a completely clean tree, because src/test/modules fail to build unless errcodes.h is generated first. To fix this, install a dependency in src/test/modules' Makefile so that the necessary file is generated. Even with t

Re: [COMMITTERS] pgsql: Move security_label test

2014-12-02 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 12/2/14 9:18 AM, Alvaro Herrera wrote: > >> After this module has been moved to src/test/modules, I am seeing > >> > failures with make check when manually kicking the test on at least > >> > OSX where I tried because expected/ and sql/ are missing. pg_regress > >> > do

[COMMITTERS] pgsql: Fix whitespace

2014-12-02 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bc2f43eaa4cef83798692e57e9d0364f0bcce021 Modified Files -- src/test/modules/dummy_seclabel/dummy_seclabel--1.0.sql |1 - 1 file changed, 1 deletion(-) -- Sent via pgsql-committers mailin