[COMMITTERS] pgsql: Fix file descriptor leak at end of recovery.

2014-12-21 Thread Heikki Linnakangas
Fix file descriptor leak at end of recovery. XLogFileInit() returns a file descriptor, which needs to be closed. The leak was short-lived, since the startup process exits shortly afterwards, but it was clearly a bug, nevertheless. Per Coverity report. Branch -- master Details --- http:/

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th

[COMMITTERS] pgsql: Docs: clarify treatment of variadic functions with zero variadic

2014-12-21 Thread Tom Lane
Docs: clarify treatment of variadic functions with zero variadic arguments. Explain that you have to use "VARIADIC ARRAY[]" to pass an empty array to a variadic parameter position. This was already implicit in the text but it seems better to spell it out. Per a suggestion from David Johnston, th