[COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Fujii Masao
Move pg_lzcompress.c to src/common. Exposing compression and decompression APIs of pglz makes possible its use by extensions and contrib modules. pglz_decompress contained a call to elog to emit an error message in case of corrupted data. This function is changed to return a status code to let its

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Fujii Masao
On Thu, Dec 25, 2014 at 8:47 PM, Fujii Masao wrote: > Move pg_lzcompress.c to src/common. > > Exposing compression and decompression APIs of pglz makes possible its > use by extensions and contrib modules. pglz_decompress contained a call > to elog to emit an error message in case of corrupted dat

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Andres Freund
On 2014-12-25 22:39:58 +0900, Fujii Masao wrote: > On Thu, Dec 25, 2014 at 8:47 PM, Fujii Masao wrote: > > Move pg_lzcompress.c to src/common. > > > > Exposing compression and decompression APIs of pglz makes possible its > > use by extensions and contrib modules. pglz_decompress contained a call

[COMMITTERS] pgsql: Remove duplicate include of slot.h.

2014-12-25 Thread Fujii Masao
Remove duplicate include of slot.h. Back-patch to 9.4, where this problem was added. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4a5593197b0ddec913fcd7758d61e782ab5c4d59 Modified Files -- src/backend/replication/walsender.c |1 - 1 file changed, 1

[COMMITTERS] pgsql: Remove duplicate include of slot.h.

2014-12-25 Thread Fujii Masao
Remove duplicate include of slot.h. Back-patch to 9.4, where this problem was added. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6ac1c52e472a1734d0f6bdc41b4ab871e21f7b92 Modified Files -- src/backend/replication/walsender.c |1 - 1 file cha

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Michael Paquier
On Thu, Dec 25, 2014 at 10:43 PM, Andres Freund wrote: > On 2014-12-25 22:39:58 +0900, Fujii Masao wrote: >> On Thu, Dec 25, 2014 at 8:47 PM, Fujii Masao wrote: >> > Move pg_lzcompress.c to src/common. >> > >> > Exposing compression and decompression APIs of pglz makes possible its >> > use by ex

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Andres Freund
On 2014-12-25 23:46:52 +0900, Michael Paquier wrote: > On Thu, Dec 25, 2014 at 10:43 PM, Andres Freund > wrote: > > /* > > * We have to use postgres.h not postgres_fe.h here, because there's so much > > * backend-only stuff in the XLOG include files we need. But we need a > > * frontend-ish e

[COMMITTERS] pgsql: Improve LWLock scalability.

2014-12-25 Thread Andres Freund
Improve LWLock scalability. The old LWLock implementation had the problem that concurrent lock acquisitions required exclusively acquiring a spinlock. Often that could lead to acquirers waiting behind the spinlock, even if the actual LWLock was free. The new implementation doesn't acquire the spi

[COMMITTERS] pgsql: Convert the PGPROC->lwWaitLink list into a dlist instead of open

2014-12-25 Thread Andres Freund
Convert the PGPROC->lwWaitLink list into a dlist instead of open coding it. Besides being shorter and much easier to read it changes the logic in LWLockRelease() to release all shared lockers when waking up any. This can yield some significant performance improvements - and the fairness isn't real

[COMMITTERS] pgsql: Add capability to suppress CONTEXT: messages to elog machinery.

2014-12-25 Thread Andres Freund
Add capability to suppress CONTEXT: messages to elog machinery. Hiding context messages usually is not a good idea - except for rather verbose debugging/development utensils like LOG_DEBUG. There the amount of repeated context messages just bloat the log without adding information. Branch --

[COMMITTERS] pgsql: Lockless StrategyGetBuffer clock sweep hot path.

2014-12-25 Thread Andres Freund
Lockless StrategyGetBuffer clock sweep hot path. StrategyGetBuffer() has proven to be a bottleneck in a number of buffer acquisition heavy workloads. To some degree this has already been alleviated by 5d7962c6, but it still can be quite a heavy bottleneck. The problem is that in unfortunate usage

[COMMITTERS] pgsql: Temporarily revert "Move pg_lzcompress.c to src/common."

2014-12-25 Thread Tom Lane
Temporarily revert "Move pg_lzcompress.c to src/common." This reverts commit 60838df922345b26a616e49ac9fab808a35d1f85. That change needs a bit more thought to be workable. In view of the potentially machine-dependent stuff that went in today, we need all of the buildfarm to be testing those other

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Tom Lane
Andres Freund writes: > On 2014-12-25 23:46:52 +0900, Michael Paquier wrote: >> Urgh.. Would that mean keeping a local copy of SET_VARSIZE_4B_C and >> VARSIZE_4B if this hack is not used? Looking at the git history, I am >> seeing similar things in 2008 where pg_crc stuff was moved to src/port >>

[COMMITTERS] pgsql: Blindly fix a dtrace probe in lwlock.c for a removed local varia

2014-12-25 Thread Andres Freund
Blindly fix a dtrace probe in lwlock.c for a removed local variable. Per buildfarm member locust. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/740a4ec7f4adccd56eced452580ccec7157fc8d8 Modified Files -- src/backend/storage/lmgr/lwlock.c |2 +- 1 fil

Re: [COMMITTERS] pgsql: Improve LWLock scalability.

2014-12-25 Thread Andres Freund
> Improve LWLock scalability. > src/backend/storage/lmgr/lwlock.c | 931 + > src/include/storage/lwlock.h | 24 +- > 2 files changed, 653 insertions(+), 302 deletions(-) This broke dtrace probes in a trivial way. Looking at the log made me notice though t

Re: [COMMITTERS] pgsql: Improve LWLock scalability.

2014-12-25 Thread Tom Lane
Andres Freund writes: > This broke dtrace probes in a trivial way. Looking at the log made me > notice though that the probes in lwlock.c generate warnings since the > tranche changes went in. Yeah, dtrace has never behaved very nicely with "const foo *" arguments. This is a bug in dtrace, not in

Re: [COMMITTERS] pgsql: Improve LWLock scalability.

2014-12-25 Thread Andres Freund
On 2014-12-25 14:13:08 -0500, Tom Lane wrote: > Andres Freund writes: > > This broke dtrace probes in a trivial way. Looking at the log made me > > notice though that the probes in lwlock.c generate warnings since the > > tranche changes went in. > > Yeah, dtrace has never behaved very nicely wit

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

[COMMITTERS] pgsql: Have config_sspi_auth() permit IPv6 localhost connections.

2014-12-25 Thread Noah Misch
Have config_sspi_auth() permit IPv6 localhost connections. Windows versions later than Windows Server 2003 map "localhost" to ::1. Account for that in the generated pg_hba.conf, fixing another oversight in commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0. Back-patch to 9.0, like that commit. Davi

Re: [COMMITTERS] pgsql: Move pg_lzcompress.c to src/common.

2014-12-25 Thread Michael Paquier
On Fri, Dec 26, 2014 at 3:31 AM, Tom Lane wrote: > Andres Freund writes: >> Surely not. It seems like a much better idea to not have lzcompress deal >> with varlena at all but pass that responsibility one layer upwards. That >> shouldn't be very hard. I'll figure out something. > and as noted, i

[COMMITTERS] pgsql: Do not pass "-N" to initdb.

2014-12-25 Thread Noah Misch
Do not pass "-N" to initdb. Per buildfarm member hamerkop. Oversight in 9.2 back-patch of commit f6dc6dd5ba54d52c0733aaafc50da2fbaeabb8b0; earlier versions lack the affected test suite, and later versions have the "-N" option. Branch -- REL9_2_STABLE Details --- http://git.postgresql.or