[COMMITTERS] pgsql: Fix typos in comment.

2015-01-13 Thread Heikki Linnakangas
Fix typos in comment. Plus some tiny wordsmithing of not-quite-typos. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3dfce37627b76e4da9e1d6090beedb608cefafcb Modified Files -- src/include/port/atomics/fallback.h | 10 +- 1 file changed, 5 inser

[COMMITTERS] pgsql: Add barriers to the latch code.

2015-01-13 Thread Andres Freund
Add barriers to the latch code. Since their introduction latches have required barriers in SetLatch and ResetLatch - but when they were introduced there wasn't any barrier abstraction. Instead latches were documented to rely on the callsites to provide barrier semantics. Now that the barrier supp

[COMMITTERS] pgsql: Allow latches to wait for socket writability without waiting for

2015-01-13 Thread Andres Freund
Allow latches to wait for socket writability without waiting for readability. So far WaitLatchOrSocket() required to pass in WL_SOCKET_READABLE as that solely was used to indicate error conditions, like EOF. Waiting for WL_SOCKET_WRITEABLE would have meant to busy wait upon socket errors. Adjust

[COMMITTERS] pgsql: Silence Coverity warnings about unused return values from pushJs

2015-01-13 Thread Heikki Linnakangas
Silence Coverity warnings about unused return values from pushJsonbValue() Similar warnings from backend were silenced earlier by commit c8315930, but there were a few more contrib/hstore. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e37d474f91c3a

Re: [COMMITTERS] pgsql: Silence Coverity warnings about unused return values from pushJs

2015-01-13 Thread Andrew Dunstan
On 01/13/2015 07:33 AM, Heikki Linnakangas wrote: Silence Coverity warnings about unused return values from pushJsonbValue() Similar warnings from backend were silenced earlier by commit c8315930, but there were a few more contrib/hstore. Shouldn't this be backpatched to 9.4? cheers and

[COMMITTERS] pgsql: Silence Coverity warnings about unused return values from pushJs

2015-01-13 Thread Heikki Linnakangas
Silence Coverity warnings about unused return values from pushJsonbValue() Similar warnings from backend were silenced earlier by commit c8315930, but there were a few more contrib/hstore. Michael Paquier Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4ebb34

Re: [COMMITTERS] pgsql: Silence Coverity warnings about unused return values from pushJs

2015-01-13 Thread Heikki Linnakangas
On 01/13/2015 03:51 PM, Andrew Dunstan wrote: On 01/13/2015 07:33 AM, Heikki Linnakangas wrote: Silence Coverity warnings about unused return values from pushJsonbValue() Similar warnings from backend were silenced earlier by commit c8315930, but there were a few more contrib/hstore. Shouldn'

Re: [COMMITTERS] pgsql: Make path to pg_service.conf absolute in documentation

2015-01-13 Thread Peter Eisentraut
On 1/3/15 7:22 AM, Magnus Hagander wrote: > Make path to pg_service.conf absolute in documentation > > The system file is always in the absolute path /etc/, not relative. This change is incorrect. pg_service.conf is never at /etc/pg_service.conf. It would be at /etc/postgresql/pg_service.conf,

[COMMITTERS] pgsql: Remove some dead IsUnderPostmaster code from bootstrap.c.

2015-01-13 Thread Andres Freund
Remove some dead IsUnderPostmaster code from bootstrap.c. Since commit 626eb021988a2 has introduced the auxiliary process infrastructure, bootstrap_signals() was never used when forked from postmaster. Remove the IsUnderPostmaster specific code, and add a appropriate assertion. Branch -- mas

[COMMITTERS] pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga

2015-01-13 Thread Andres Freund
Make logging_collector=on work with non-windows EXEC_BACKEND again. Commit b94ce6e80 reordered postmaster's startup sequence so that the tempfile directory is only cleaned up after all the necessary state for pg_ctl is collected. Unfortunately the chosen location is after the syslogger has been s

[COMMITTERS] pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga

2015-01-13 Thread Andres Freund
Make logging_collector=on work with non-windows EXEC_BACKEND again. Commit b94ce6e80 reordered postmaster's startup sequence so that the tempfile directory is only cleaned up after all the necessary state for pg_ctl is collected. Unfortunately the chosen location is after the syslogger has been s

[COMMITTERS] pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga

2015-01-13 Thread Andres Freund
Make logging_collector=on work with non-windows EXEC_BACKEND again. Commit b94ce6e80 reordered postmaster's startup sequence so that the tempfile directory is only cleaned up after all the necessary state for pg_ctl is collected. Unfortunately the chosen location is after the syslogger has been s

[COMMITTERS] pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga

2015-01-13 Thread Andres Freund
Make logging_collector=on work with non-windows EXEC_BACKEND again. Commit b94ce6e80 reordered postmaster's startup sequence so that the tempfile directory is only cleaned up after all the necessary state for pg_ctl is collected. Unfortunately the chosen location is after the syslogger has been s

[COMMITTERS] pgsql: Make logging_collector=on work with non-windows EXEC_BACKEND aga

2015-01-13 Thread Andres Freund
Make logging_collector=on work with non-windows EXEC_BACKEND again. Commit b94ce6e80 reordered postmaster's startup sequence so that the tempfile directory is only cleaned up after all the necessary state for pg_ctl is collected. Unfortunately the chosen location is after the syslogger has been s

Re: [COMMITTERS] pgsql: Make path to pg_service.conf absolute in documentation

2015-01-13 Thread Andrew Dunstan
On 01/13/2015 04:16 PM, Peter Eisentraut wrote: On 1/3/15 7:22 AM, Magnus Hagander wrote: Make path to pg_service.conf absolute in documentation The system file is always in the absolute path /etc/, not relative. This change is incorrect. pg_service.conf is never at /etc/pg_service.conf. It

[COMMITTERS] pgsql: Remove duplicate specification of -Ae for HP-UX C compiler.

2015-01-13 Thread Tom Lane
Remove duplicate specification of -Ae for HP-UX C compiler. Autoconf has known about automatically selecting -Ae when needed for quite some time now, so remove the redundant addition in template/hpux. Noted while setting up buildfarm member pademelon. Branch -- master Details --- http://