[COMMITTERS] pgsql: Blindly try to fix a warning in s_lock.h when compiling with gcc

2015-01-15 Thread Andres Freund
Blindly try to fix a warning in s_lock.h when compiling with gcc on HPPA. The possibly, depending on compiler settings, generated warning was "warning: `S_UNLOCK' redefined". The hppa spinlock implementation doesn't follow the rules of s_lock.h and provides a gcc specific implementation outside o

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

2015-01-15 Thread Robert Haas
pg_standby: Avoid writing one byte beyond the end of the buffer. Previously, read() might have returned a length equal to the buffer length, and then the subsequent store to buf[len] would write a zero-byte one byte past the end. This doesn't seem likely to be a security issue, but there's some c

[COMMITTERS] pgsql: Improve performance of EXPLAIN with large range tables.

2015-01-15 Thread Tom Lane
Improve performance of EXPLAIN with large range tables. As of 9.3, ruleutils.c goes to some lengths to ensure that table and column aliases used in its output are unique. Of course this takes more time than was required before, which in itself isn't fatal. However, EXPLAIN was set up so that rec

[COMMITTERS] pgsql: Improve performance of EXPLAIN with large range tables.

2015-01-15 Thread Tom Lane
Improve performance of EXPLAIN with large range tables. As of 9.3, ruleutils.c goes to some lengths to ensure that table and column aliases used in its output are unique. Of course this takes more time than was required before, which in itself isn't fatal. However, EXPLAIN was set up so that rec

[COMMITTERS] pgsql: Improve performance of EXPLAIN with large range tables.

2015-01-15 Thread Tom Lane
Improve performance of EXPLAIN with large range tables. As of 9.3, ruleutils.c goes to some lengths to ensure that table and column aliases used in its output are unique. Of course this takes more time than was required before, which in itself isn't fatal. However, EXPLAIN was set up so that rec

[COMMITTERS] pgsql: Rearrange explain.c's API so callers need not embed sizeof(Expla

2015-01-15 Thread Tom Lane
Rearrange explain.c's API so callers need not embed sizeof(ExplainState). The folly of the previous arrangement was just demonstrated: there's no convenient way to add fields to ExplainState without breaking ABI, even if callers have no need to touch those fields. Since we might well need to do t

[COMMITTERS] pgsql: Fix thinko in re-setting wal_log_hints flag from a parameter-cha

2015-01-15 Thread Heikki Linnakangas
Fix thinko in re-setting wal_log_hints flag from a parameter-change record. The flag is supposed to be copied from the record. Same issue with track_commit_timestamps, but that's master-only. Report and fix by Petr Jalinek. Backpatch to 9.4, where wal_log_hints was added. Branch -- REL9_4_ST

[COMMITTERS] pgsql: Fix thinko in re-setting wal_log_hints flag from a parameter-cha

2015-01-15 Thread Heikki Linnakangas
Fix thinko in re-setting wal_log_hints flag from a parameter-change record. The flag is supposed to be copied from the record. Same issue with track_commit_timestamps, but that's master-only. Report and fix by Petr Jalinek. Backpatch to 9.4, where wal_log_hints was added. Branch -- master D

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Fix use-of-already-freed-memory problem in EvalPlanQual processi

2015-01-15 Thread Tom Lane
Fix use-of-already-freed-memory problem in EvalPlanQual processing. Up to now, the "child" executor state trees generated for EvalPlanQual rechecks have simply shared the ResultRelInfo arrays used for the original execution tree. However, this leads to dangling-pointer problems, because ExecInitM

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA

[COMMITTERS] pgsql: Update "pg_regress --no-locale" for Darwin and Windows.

2015-01-15 Thread Noah Misch
Update "pg_regress --no-locale" for Darwin and Windows. Commit 894459e59ffa5c7fee297b246c17e1f72564db1d revealed this option to be broken for NLS builds on Darwin, but "make -C contrib/unaccent check" and the buildfarm client rely on it. Fix that configuration by redefining the option to imply LA