[COMMITTERS] pgsql: Remove dead NULL-pointer checks in GiST code.

2015-01-28 Thread Heikki Linnakangas
Remove dead NULL-pointer checks in GiST code. gist_poly_compress() and gist_circle_compress() checked for a NULL-pointer key argument, but that was dead code; the gist code never passes a NULL-pointer to the "compress" method. This commit also removes a documentation note added in commit a0a3883,

[COMMITTERS] pgsql: Fix typo in comment.

2015-01-28 Thread Heikki Linnakangas
Fix typo in comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/acc2b1e843ae04e97025880f33a82f326ab12d59 Modified Files -- src/backend/storage/buffer/bufmgr.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committe

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription, ExecBuildSlotValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription, ExecBuildSlotValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription, ExecBuildSlotValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have access to view all of the colu

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have access to view all of the colu

[COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

2015-01-28 Thread Stephen Frost
Fix column-privilege leak in error-message paths While building error messages to return to the user, BuildIndexValueDescription, ExecBuildSlotValueDescription and ri_ReportViolation would happily include the entire key or entire row in the result returned to the user, even if the user didn't have

[COMMITTERS] pgsql: Clean up range-table building in copy.c

2015-01-28 Thread Stephen Frost
Clean up range-table building in copy.c Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a range table in copy.c to initialize the EState es_range_table since it can be needed in error paths. Unfortunately, that commit didn't appreciate that some code paths might end up not init

[COMMITTERS] pgsql: Clean up range-table building in copy.c

2015-01-28 Thread Stephen Frost
Clean up range-table building in copy.c Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a range table in copy.c to initialize the EState es_range_table since it can be needed in error paths. Unfortunately, that commit didn't appreciate that some code paths might end up not init

[COMMITTERS] pgsql: Clean up range-table building in copy.c

2015-01-28 Thread Stephen Frost
Clean up range-table building in copy.c Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a range table in copy.c to initialize the EState es_range_table since it can be needed in error paths. Unfortunately, that commit didn't appreciate that some code paths might end up not init

[COMMITTERS] pgsql: Clean up range-table building in copy.c

2015-01-28 Thread Stephen Frost
Clean up range-table building in copy.c Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a range table in copy.c to initialize the EState es_range_table since it can be needed in error paths. Unfortunately, that commit didn't appreciate that some code paths might end up not init

[COMMITTERS] pgsql: Clean up range-table building in copy.c

2015-01-28 Thread Stephen Frost
Clean up range-table building in copy.c Commit 804b6b6db4dcfc590a468e7be390738f9f7755fb added the build of a range table in copy.c to initialize the EState es_range_table since it can be needed in error paths. Unfortunately, that commit didn't appreciate that some code paths might end up not init

[COMMITTERS] pgsql: Improve CREATE POLICY documentation

2015-01-28 Thread Stephen Frost
Improve CREATE POLICY documentation The CREATE POLICY documention didn't sufficiently clarify what happens when a given command type (eg: ALL or UPDATE) accepts both USING and WITH CHECK clauses, but only the USING clause is defined. Add language to clarify that, in such a case, the USING clause

[COMMITTERS] pgsql: Add usebypassrls to pg_user and pg_shadow

2015-01-28 Thread Stephen Frost
Add usebypassrls to pg_user and pg_shadow The row level security patches didn't add the 'usebypassrls' columns to the pg_user and pg_shadow views on the belief that they were deprecated, but we havn't actually said they are and therefore we should include it. This patch corrects that, adds missin

[COMMITTERS] pgsql: CREATE POLICY expression -> using_expression

2015-01-28 Thread Stephen Frost
CREATE POLICY expression -> using_expression The syntax for CREATE POLICY simply used "expression" for the USING expression, while the WITH CHECK expression was "check_expression". Given that we have two expressions, it's sensible to explcitly name both to maintain clarity. This patch simply chan

[COMMITTERS] pgsql: Reword CREATE POLICY parameter descriptions

2015-01-28 Thread Stephen Frost
Reword CREATE POLICY parameter descriptions The parameter description for the using_expression and check_expression in CREATE POLICY were unclear and arguably included a typo. Clarify and improve the consistency of that language. Pointed out by Dean Rasheed. Branch -- master Details --