[COMMITTERS] pgsql: Move pg_crc.c to src/common, and remove pg_crc_tables.h

2015-02-09 Thread Heikki Linnakangas
Move pg_crc.c to src/common, and remove pg_crc_tables.h To get CRC functionality in a client program, you now need to link with libpgcommon instead of libpgport. The CRC code has nothing to do with portability, so libpgcommon is a better home. (libpgcommon didn't exist when pg_crc.c was originally

Re: [COMMITTERS] pgsql: Move pg_crc.c to src/common, and remove pg_crc_tables.h

2015-02-09 Thread Michael Paquier
On Mon, Feb 9, 2015 at 6:18 PM, Heikki Linnakangas wrote: > Move pg_crc.c to src/common, and remove pg_crc_tables.h > (snip) > contrib/hstore/hstore_gist.c |2 +- > contrib/ltree/crc32.c |2 +- > src/backend/utils/adt/tsquery.c |1 + > src/common/Makefile

[COMMITTERS] pgsql: Minor cleanup/code review for "indirect toast" stuff.

2015-02-09 Thread Tom Lane
Minor cleanup/code review for "indirect toast" stuff. Fix some issues I noticed while fooling with an extension to allow an additional kind of toast pointer. Much of this is just comment improvement, but there are a couple of actual bugs, which might or might not be reachable today depending on w

[COMMITTERS] pgsql: Minor cleanup/code review for "indirect toast" stuff.

2015-02-09 Thread Tom Lane
Minor cleanup/code review for "indirect toast" stuff. Fix some issues I noticed while fooling with an extension to allow an additional kind of toast pointer. Much of this is just comment improvement, but there are a couple of actual bugs, which might or might not be reachable today depending on w

[COMMITTERS] pgsql: Fix MSVC build.

2015-02-09 Thread Heikki Linnakangas
Fix MSVC build. When I moved pg_crc.c from src/port to src/common, I forgot to modify MSVC build script accordingly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cc761b170c5e7b4ef22ed918f4785ec1fabe62cd Modified Files -- src/tools/msvc/Mkvcbuild.pm |

Re: [COMMITTERS] pgsql: Move pg_crc.c to src/common, and remove pg_crc_tables.h

2015-02-09 Thread Heikki Linnakangas
On 02/09/2015 01:27 PM, Michael Paquier wrote: On Mon, Feb 9, 2015 at 6:18 PM, Heikki Linnakangas wrote: Move pg_crc.c to src/common, and remove pg_crc_tables.h (snip) contrib/hstore/hstore_gist.c |2 +- contrib/ltree/crc32.c |2 +- src/backend/utils/adt/tsquery.c |

Re: [COMMITTERS] pgsql: Minor cleanup/code review for "indirect toast" stuff.

2015-02-09 Thread Fujii Masao
On Tue, Feb 10, 2015 at 2:31 AM, Tom Lane wrote: > In HEAD, also correct some really minor issues with recent compression > reorganization, such as dangerously underparenthesized macros. Oh,, thanks! Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgre