[COMMITTERS] pgsql: Rationalize the APIs of array element/slice access functions.

2015-02-16 Thread Tom Lane
Rationalize the APIs of array element/slice access functions. The four functions array_ref, array_set, array_get_slice, array_set_slice have traditionally declared their array inputs and results as being of type "ArrayType *". This is a lie, and has been since Berkeley days, because they actually

[COMMITTERS] pgsql: In the SSL test suite, use a root CA cert that won't expire (so

2015-02-16 Thread Heikki Linnakangas
In the SSL test suite, use a root CA cert that won't expire (so quickly) All the other certificates were created to be valid for 1 days, because we don't want to have to recreate them. But I missed the root CA cert, and the pre-created certificates included in the repository expired in January

[COMMITTERS] pgsql: Use fast path in plpgsql's RETURN/RETURN NEXT in more cases.

2015-02-16 Thread Tom Lane
Use fast path in plpgsql's RETURN/RETURN NEXT in more cases. exec_stmt_return() and exec_stmt_return_next() have fast-path code for handling a simple variable reference (i.e. "return var") without going through the full expression evaluation machinery. For some reason, pl_gram.y was under the imp

[COMMITTERS] pgsql: Restore the SSL_set_session_id_context() call to OpenSSL renegot

2015-02-16 Thread Heikki Linnakangas
Restore the SSL_set_session_id_context() call to OpenSSL renegotiation. This reverts the removal of the call in commit (272923a0). It turns out it wasn't superfluous after all: without it, renegotiation fails if a client certificate was used. The rest of the changes in that commit are still OK and

[COMMITTERS] pgsql: Fix comment in libpq OpenSSL code about why a substitue BIO is u

2015-02-16 Thread Heikki Linnakangas
Fix comment in libpq OpenSSL code about why a substitue BIO is used. The comment was copy-pasted from the backend code along with the implementation, but libpq has different reasons for using the BIO. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c478959a009a926ec4

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Fix misuse of memcpy() in check_ip().

2015-02-16 Thread Tom Lane
Fix misuse of memcpy() in check_ip(). The previous coding copied garbage into a local variable, pretty much ensuring that the intended test of an IPv6 connection address against a promoted IPv4 address from pg_hba.conf would never match. The lack of field complaints likely indicates that nobody r

[COMMITTERS] pgsql: Eliminate unnecessary NULL checks in picksplit method of intarra

2015-02-16 Thread Kevin Grittner
Eliminate unnecessary NULL checks in picksplit method of intarray. Where these checks were being done there was no code path which could leave them NULL. Michael Paquier per Coverity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c923e82a231ebfe7c4329984c68819e2683

Re: [COMMITTERS] pgsql: pg_upgrade: quote directory names in delete_old_cluster script

2015-02-16 Thread Bruce Momjian
On Sun, Feb 15, 2015 at 12:02:44PM -0500, Peter Eisentraut wrote: > On 2/11/15 10:06 PM, Bruce Momjian wrote: > > pg_upgrade: quote directory names in delete_old_cluster script > > > > This allows the delete script to properly function when special > > characters appear in directory paths, e.g. s

Re: [COMMITTERS] pgsql: pg_upgrade: quote directory names in delete_old_cluster script

2015-02-16 Thread Peter Eisentraut
On 2/16/15 4:44 PM, Bruce Momjian wrote: > On Sun, Feb 15, 2015 at 12:02:44PM -0500, Peter Eisentraut wrote: >> On 2/11/15 10:06 PM, Bruce Momjian wrote: >>> pg_upgrade: quote directory names in delete_old_cluster script >>> >>> This allows the delete script to properly function when special >>> c

Re: [COMMITTERS] pgsql: pg_upgrade: quote directory names in delete_old_cluster script

2015-02-16 Thread Bruce Momjian
On Mon, Feb 16, 2015 at 04:47:23PM -0500, Peter Eisentraut wrote: > On 2/16/15 4:44 PM, Bruce Momjian wrote: > > On Sun, Feb 15, 2015 at 12:02:44PM -0500, Peter Eisentraut wrote: > >> On 2/11/15 10:06 PM, Bruce Momjian wrote: > >>> pg_upgrade: quote directory names in delete_old_cluster script > >