Re: [COMMITTERS] pgsql: to_char(float4/8): don't print "junk" digits

2015-03-22 Thread Bruce Momjian
On Sun, Mar 22, 2015 at 01:37:56AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > to_char(float4/8): don't print "junk" digits > > I think this probably was not what you intended to commit, because > what got committed was only an entirely-pointless whitespace change. It actually is because

Re: [COMMITTERS] pgsql: to_char(float4/8): zero pad to specified length

2015-03-22 Thread Tom Lane
I wrote: > Bruce Momjian writes: >> to_char(float4/8): zero pad to specified length > The Windows members of the buildfarm seem unimpressed with this patch. castoroides and protosciurus (Solaris) don't like it either, though the symptom is different. regards, tom lane

Re: [COMMITTERS] pgsql: to_char(float4/8): zero pad to specified length

2015-03-22 Thread Bruce Momjian
On Sun, Mar 22, 2015 at 10:39:32AM -0400, Tom Lane wrote: > I wrote: > > Bruce Momjian writes: > >> to_char(float4/8): zero pad to specified length > > > The Windows members of the buildfarm seem unimpressed with this patch. > > castoroides and protosciurus (Solaris) don't like it either, thoug

Re: [COMMITTERS] pgsql: to_char(float4/8): zero pad to specified length

2015-03-22 Thread Tom Lane
Bruce Momjian writes: > On Sun, Mar 22, 2015 at 10:39:32AM -0400, Tom Lane wrote: >> castoroides and protosciurus (Solaris) don't like it either, though >> the symptom is different. > Yeah, I just replied on the other thread --- not good. Maybe we need to > punt this change to 9.6 --- I don't kn

[COMMITTERS] pgsql: Allow foreign tables to participate in inheritance.

2015-03-22 Thread Tom Lane
Allow foreign tables to participate in inheritance. Foreign tables can now be inheritance children, or parents. Much of the system was already ready for this, but we had to fix a few things of course, mostly in the area of planner and executor handling of row locks. As side effects of this, allo

[COMMITTERS] pgsql: Fix minor copy & pasto in the int128 accumulator patch.

2015-03-22 Thread Andres Freund
Fix minor copy & pasto in the int128 accumulator patch. It's unlikely that using PG_GETARG_INT16 instead of PG_GETARG_INT32 in this pace can cause actual problems, but this still should be fixed. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/59b0a98af07cf8decfe9473

Re: [COMMITTERS] pgsql: to_char(float4/8): zero pad to specified length

2015-03-22 Thread Bruce Momjian
On Sun, Mar 22, 2015 at 12:13:28PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sun, Mar 22, 2015 at 10:39:32AM -0400, Tom Lane wrote: > >> castoroides and protosciurus (Solaris) don't like it either, though > >> the symptom is different. > > > Yeah, I just replied on the other thread --

[COMMITTERS] pgsql: to_char: revert cc0d90b73b2e6dd2f301d46818a7265742c41a14

2015-03-22 Thread Bruce Momjian
to_char: revert cc0d90b73b2e6dd2f301d46818a7265742c41a14 Revert "to_char(float4/8): zero pad to specified length". There are too many platform-specific problems, and the proper rounding is missing. Also revert companion patch 9d61b9953c1489cbb458ca70013cf5fca1bb7710. Branch -- master Deta

Re: [COMMITTERS] pgsql: Merge the various forms of transaction commit & abort records.

2015-03-22 Thread Michael Paquier
On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund wrote: > Merge the various forms of transaction commit & abort records. Coverity is complaining about the following block of code: + xact_info = XLogRecGetInfo(record) & XLOG_XACT_COMMIT; + + if (xact_info != XLOG_XACT_COMMIT && +