[COMMITTERS] pgsql: Remove ill-advised pre-check for DSM segment exhaustion.

2015-03-23 Thread Robert Haas
Remove ill-advised pre-check for DSM segment exhaustion. dsm_control->nitems never decreases, so this is testing whether the server has *ever* run out of DSM segments, not whether it is *currently* out of DSM segments. Reported off-list by Amit Kapila. Branch -- master Details --- http:

[COMMITTERS] pgsql: Fix copy & paste error in 4f1b890b137.

2015-03-23 Thread Andres Freund
Fix copy & paste error in 4f1b890b137. Due to the bug delayed standbys would not delay when applying prepared transactions. Discussion: CAB7nPqT6BO1cCn+sAyDByBxA4EKZNAiPi2mFJ=anezmnmew...@mail.gmail.com Michael Paquier via Coverity. Branch -- master Details --- http://git.postgresql.or

Re: [COMMITTERS] pgsql: Merge the various forms of transaction commit & abort records.

2015-03-23 Thread Andres Freund
On 2015-03-23 13:04:09 +0900, Michael Paquier wrote: > On Mon, Mar 16, 2015 at 1:38 AM, Andres Freund wrote: > > Merge the various forms of transaction commit & abort records. > > Coverity is complaining about the following block of code: > + xact_info = XLogRecGetInfo(record) & XLOG_XACT_C

[COMMITTERS] pgsql: Don't delay replication for less than recovery_min_apply_delay's

2015-03-23 Thread Andres Freund
Don't delay replication for less than recovery_min_apply_delay's resolution. Recovery delays are implemented by waiting on a latch, and latches take milliseconds as a parameter. The required amount of waiting was computed using microsecond resolution though and the wait loop's abort condition was

[COMMITTERS] pgsql: Don't delay replication for less than recovery_min_apply_delay's

2015-03-23 Thread Andres Freund
Don't delay replication for less than recovery_min_apply_delay's resolution. Recovery delays are implemented by waiting on a latch, and latches take milliseconds as a parameter. The required amount of waiting was computed using microsecond resolution though and the wait loop's abort condition was

[COMMITTERS] pgsql: Add pg_rewind, for re-synchronizing a master server after failba

2015-03-23 Thread Heikki Linnakangas
Add pg_rewind, for re-synchronizing a master server after failback. Earlier versions of this tool were available (and still are) on github. Thanks to Michael Paquier, Alvaro Herrera, Peter Eisentraut, Amit Kapila, and Satoshi Nagayasu for review. Branch -- master Details --- http://git.

[COMMITTERS] pgsql: Try to fix MSVC build of pg_rewind.

2015-03-23 Thread Heikki Linnakangas
Try to fix MSVC build of pg_rewind. It worked in my Windows VM with VS2013, but buildfarm animal mastodon, running MSVC 2005, was not happy. Amit Kapila also reported a similar error earlier in his environment. Let's see if this helps. Branch -- master Details --- http://git.postgresql.o

[COMMITTERS] pgsql: vacuumdb: Check result status of PQsendQuery

2015-03-23 Thread Alvaro Herrera
vacuumdb: Check result status of PQsendQuery Noticed by Coverity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/871293fb7fa869fbe0f202bef2e0d781bfd21b3e Modified Files -- src/bin/scripts/vacuumdb.c | 25 - 1 file changed, 20 ins

Re: [COMMITTERS] pgsql: vacuumdb: enable parallel mode

2015-03-23 Thread Alvaro Herrera
Michael Paquier wrote: > On Sat, Jan 24, 2015 at 3:06 AM, Alvaro Herrera > wrote: > > vacuumdb: enable parallel mode > > > > This mode allows vacuumdb to open several server connections to vacuum > > or analyze several tables simultaneously. > > Coverity is still complaining about this block of

[COMMITTERS] pgsql: Apply table and domain CHECK constraints in name order.

2015-03-23 Thread Tom Lane
Apply table and domain CHECK constraints in name order. Previously, CHECK constraints of the same scope were checked in whatever order they happened to be read from pg_constraint. (Usually, but not reliably, this would be creation order for domain constraints and reverse creation order for table

Re: [COMMITTERS] pgsql: Try to fix MSVC build of pg_rewind.

2015-03-23 Thread juan perez
I can't start PostgreSQL server in windows with a pg_basebackup of my master can I get some help in replication between windows en OS X Sent from my iPhone > On 23/03/2015, at 11:27 a.m., Heikki Linnakangas > wrote: > > Try to fix MSVC build of pg_rewind. > > It worked in my Windows VM with

Re: [COMMITTERS] pgsql: Try to fix MSVC build of pg_rewind.

2015-03-23 Thread Robert Haas
On Mon, Mar 23, 2015 at 6:09 PM, juan perez wrote: > I can't start PostgreSQL server in windows with a pg_basebackup of my master > can I get some help in replication between windows en OS X This question would be appropriate on the pgsql-general mailing list, or pgsql-novice, or maybe pgsql-adm