[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relat

2015-03-24 Thread Tom Lane
Fix ExecOpenScanRelation to take a lock on a ROW_MARK_COPY relation. ExecOpenScanRelation assumed that any relation listed in the ExecRowMark list has been locked by InitPlan; but this is not true if the rel's markType is ROW_MARK_COPY, which is possible if it's a foreign table. In most (possibly

[COMMITTERS] pgsql: Add support for ALTER TABLE IF EXISTS ... RENAME CONSTRAINT

2015-03-24 Thread Bruce Momjian
Add support for ALTER TABLE IF EXISTS ... RENAME CONSTRAINT Also add regression test. Previously this was documented to work, but didn't. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1d8198bb44e7e7e3e96d96942f642e9964111628 Modified Files -- src/back

[COMMITTERS] pgsql: doc: update NUMERIC to state that only some ops are exact

2015-03-24 Thread Bruce Momjian
doc: update NUMERIC to state that only some ops are exact Report by Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/278edd9ed36c7722cbae27e0e96a08964da69eb5 Modified Files -- doc/src/sgml/datatype.sgml | 12 +++- 1 file changed, 7 inse

[COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1()

2015-03-24 Thread Bruce Momjian
btree_gin: properly call DirectFunctionCall1() Previously we called DirectFunctionCall3() with dummy arguments. Patch by Jon Nelson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/843cd0bfe6246d94d9b34a7f36bbb76fdba87b74 Modified Files -- contrib/btree

[COMMITTERS] pgsql: docs: clarify when MVCC snapshot is taken

2015-03-24 Thread Bruce Momjian
docs: clarify when MVCC snapshot is taken Report by Álvaro Hernández Tortosa Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/66c8040d509c86fd2f215c06eb16d82e570d3fb6 Modified Files -- doc/src/sgml/mvcc.sgml |3 ++- 1 file changed, 2 insertions(+), 1

Re: [COMMITTERS] pgsql: Allow empty target list in SELECT.

2015-03-24 Thread Bruce Momjian
On Fri, Mar 20, 2015 at 08:25:50AM -0400, Bruce Momjian wrote: > > regression=# create table foo(); > > CREATE TABLE > > regression=# insert into foo default values; > > INSERT 0 1 > > regression=# insert into foo default values; > > INSERT 0 1 > > regression=# select * from foo; > > -- > > (2 rows

[COMMITTERS] pgsql: psql: show proper row count in \x mode for zero-column output

2015-03-24 Thread Bruce Momjian
psql: show proper row count in \x mode for zero-column output Also, fix pager enable selection for such cases, and other cleanups for zero-column output. Report by Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/376a0c4547fe98c45476647596ce9c9b394f8415

[COMMITTERS] pgsql: PL/pgSQL docs: recommend format() for query construction

2015-03-24 Thread Bruce Momjian
PL/pgSQL docs: recommend format() for query construction Previously only concatenation was recommended. Report by Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0e1f6d8132b4da3e0727bb4918b9ea51446a9c41 Modified Files -- doc/src/sgml/func

Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1()

2015-03-24 Thread Tom Lane
Bruce Momjian writes: > btree_gin: properly call DirectFunctionCall1() > Previously we called DirectFunctionCall3() with dummy arguments. This patch is entirely wrong and has broken the buildfarm. Please revert. regards, tom lane -- Sent via pgsql-committers mailing l

Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1()

2015-03-24 Thread Bruce Momjian
On Tue, Mar 24, 2015 at 10:02:03PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > btree_gin: properly call DirectFunctionCall1() > > Previously we called DirectFunctionCall3() with dummy arguments. > > This patch is entirely wrong and has broken the buildfarm. > Please revert. OK, done. --

[COMMITTERS] pgsql: Revert commit 843cd0bfe6246d94d9b34a7f36bbb76fdba87b74

2015-03-24 Thread Bruce Momjian
Revert commit 843cd0bfe6246d94d9b34a7f36bbb76fdba87b74 Report by Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/11226e3817687fcb70fb49d75fdf592e7f3884f6 Modified Files -- contrib/btree_gin/btree_gin.c | 15 --- 1 file changed, 12