[COMMITTERS] pgsql: Minor code cleanups in pgbench expression support.

2015-03-29 Thread Tom Lane
Minor code cleanups in pgbench expression support. Get rid of unnecessary expr_yylex declaration (we haven't supported flex 2.5.4 in a long time, and even if we still did, the declaration in pgbench.h makes this one unnecessary and inappropriate). Fix copyright dates, improve some layout choices,

[COMMITTERS] pgsql: Remove a couple other vestigial yylex() declarations.

2015-03-29 Thread Tom Lane
Remove a couple other vestigial yylex() declarations. These were workarounds for a long-gone flex bug; all supported versions of flex emit an extern declaration as expected. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9a8e23311cac14168df6644e03d533a4b07f933e Mod

[COMMITTERS] pgsql: Make ginbuild's funcCtx be independent of its tmpCtx.

2015-03-29 Thread Tom Lane
Make ginbuild's funcCtx be independent of its tmpCtx. Previously the funcCtx was a child of the tmpCtx, but that was broken by commit eaa5808e8ec4e82ce1a87103a6b6f687666e4e4c, which made MemoryContextReset() delete, not reset, child contexts. The behavior of having a tmpCtx reset also clear the o

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Add vacuum_delay_point call in compute_index_stats's per-sample-

2015-03-29 Thread Tom Lane
Add vacuum_delay_point call in compute_index_stats's per-sample-row loop. Slow functions in index expressions might cause this loop to take long enough to make it worth being cancellable. Probably it would be enough to call CHECK_FOR_INTERRUPTS here, but for consistency with other per-sample-row

[COMMITTERS] pgsql: Fix multiple bugs and infelicities in pg_rewind.

2015-03-29 Thread Tom Lane
Fix multiple bugs and infelicities in pg_rewind. Bugs all spotted by Coverity, including wrong realloc() size request and memory leaks. Cosmetic improvements by me. The usage of the global variable "filemap" here is still pretty awful, but at least I got rid of the gratuitous aliasing in several

[COMMITTERS] pgsql: Clean up all the cruft after a pg_rewind test run.

2015-03-29 Thread Tom Lane
Clean up all the cruft after a pg_rewind test run. regress_log temp directory was properly .gitignore'd, which may explain why it got left out of the "make clean" action. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1c41e2a998a0de16d9d33949a7b98a5be3d2477c Modifi

Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

2015-03-29 Thread Michael Paquier
On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund wrote: > Centralize definition of integer limits. > > Several submitted and even committed patches have run into the problem > that C89, our baseline, does not provide minimum/maximum values for > various integer datatypes. C99's stdint.h does, but we

Re: [COMMITTERS] pgsql: Centralize definition of integer limits.

2015-03-29 Thread Michael Paquier
On Mon, Mar 30, 2015 at 2:01 PM, Michael Paquier wrote: > > > > On Thu, Mar 26, 2015 at 6:49 AM, Andres Freund wrote: > > Centralize definition of integer limits. > > > > Several submitted and even committed patches have run into the problem > > that C89, our baseline, does not provide minimum/m