[COMMITTERS] pgsql: Move inet/cidr GiST opclass functions to correct place in header

2015-04-01 Thread Heikki Linnakangas
Move inet/cidr GiST opclass functions to correct place in header file. They were accidentally placed under the GIN heading. Andreas Karlsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f770870d9e4d01f4b255a3df6c2c4a2dcfcbcce0 Modified Files -- src/i

[COMMITTERS] pgsql: Provide real selectivity estimators for inet/cidr operators.

2015-04-01 Thread Tom Lane
Provide real selectivity estimators for inet/cidr operators. This patch fills in the formerly-stub networksel() and networkjoinsel() estimation functions. Those are used for << <<= >> >>= and && operators on inet/cidr types. The estimation is not perfect, certainly, because we rely on the existi

[COMMITTERS] pgsql: pg_upgrade: call 'postgres' binary to get data directory locati

2015-04-01 Thread Bruce Momjian
pg_upgrade: call 'postgres' binary to get data directory location This matches the binary 'pg_ctl' calls. Previously we called the 'postmaster'. Report by Christoph Berg Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a0efc714531d3dfd02fafd39e80d058cef6703b0 Modi

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

[COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Alvaro Herrera
psql: fix \connect with URIs and conninfo strings psql was already accepting conninfo strings as the first parameter in \connect, but the way it worked wasn't sane; some of the other parameters would get the previous connection's values, causing it to connect to a completely unexpected server or,

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Michael Paquier
On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera wrote: > psql: fix \connect with URIs and conninfo strings > > psql was already accepting conninfo strings as the first parameter in > \connect, but the way it worked wasn't sane; some of the other > parameters would get the previous connection's val

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Michael Paquier
On Thu, Apr 2, 2015 at 10:29 AM, Michael Paquier wrote: > > > > On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera > wrote: > >> psql: fix \connect with URIs and conninfo strings >> >> psql was already accepting conninfo strings as the first parameter in >> \connect, but the way it worked wasn't san

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Michael Paquier
On Thu, Apr 2, 2015 at 10:58 AM, Michael Paquier wrote: > > On other Linux machines, tests for dblink are failing: > + ERROR: could not load library > "/usr/src/pgfarm/build/HEAD/inst/lib/postgresql/dblink.so": > /usr/src/pgfarm/build/HEAD/inst/lib/libpq.so.5: undefined symbol: > libpq_connstring_

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Tom Lane
Michael Paquier writes: > The patch attached fixes all those inconsistencies (tested build on OSX and > Windows). I think this is going in the wrong direction entirely, ie doubling down on Alvaro's original mistake. libpq *must not* depend on libpgcommon, because the latter is not compiled to be

Re: [COMMITTERS] pgsql: psql: fix \connect with URIs and conninfo strings

2015-04-01 Thread Michael Paquier
On Thu, Apr 2, 2015 at 11:49 AM, Tom Lane wrote: > Michael Paquier writes: > > The patch attached fixes all those inconsistencies (tested build on OSX > and > > Windows). > > I think this is going in the wrong direction entirely, ie doubling down > on Alvaro's original mistake. libpq *must not*