[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
Don't archive bogus recycled or preallocated files after timeline switch. After a timeline switch, we would leave behind recycled WAL segments that are in the future, but on the old timeline. After promotion, and after they become old enough to be recycled again, we would notice that they don't ha

[COMMITTERS] pgsql: Refactor and fix TAP tests of pg_rewind

2015-04-13 Thread Heikki Linnakangas
Refactor and fix TAP tests of pg_rewind * Don't pass arguments to prove, since that's not supported on perl 5.8 which is the minimum version supported by the TAP tests. Refactor the test files themselves to run the tests twice, in both local and remote mode. * Use eq rather than == for string com

[COMMITTERS] pgsql: Fix pg_rewind regression tests in VPATH builds

2015-04-13 Thread Heikki Linnakangas
Fix pg_rewind regression tests in VPATH builds Should call just "pg_rewind", instead of "./pg_rewind". The tests are called so that PATH contains the temporariy installation bin dir. Per report from Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b22a

[COMMITTERS] pgsql: Move pgbench from contrib/ to src/bin/

2015-04-13 Thread Peter Eisentraut
Move pgbench from contrib/ to src/bin/ Reviewed-by: Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/81134af3ec09d67043833f8d614fd688f17cb213 Modified Files -- contrib/Makefile |1 - contrib/pgbench/.gitignore |3

Re: [COMMITTERS] pgsql: Mark the second argument of pg_log as the translatable string in

2015-04-13 Thread Alvaro Herrera
Michael Paquier wrote: > On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote: > > What pg_basebackup's progress_report() does is have the message in the > > translatable part not include the \r; the \r is in a separate fprintf() > > call. > > Like the attached then. Not a fan of this approach,

[COMMITTERS] pgsql: Remove duplicated word in README

2015-04-13 Thread Alvaro Herrera
Remove duplicated word in README Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5213e14a4759b8f6817359c827950bae5452136 Modified Files -- src/backend/access/nbtree/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commi

[COMMITTERS] pgsql: pgbench: Attempt fix build on Windows

2015-04-13 Thread Peter Eisentraut
pgbench: Attempt fix build on Windows Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d577bb868dfb595aa8df95974cd1c79e1baba924 Modified Files -- src/tools/msvc/Mkvcbuild.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-commi

Re: [COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Tom Lane
Heikki Linnakangas writes: > To fix, whenever we switch to a new timeline, scan the data directory for > WAL segments on the old timeline, but with a higher segment number, and > remove them. Wait a minute. Didn't you just break PITR scenarios? The *entire point* of the multiple-timeline mechan

Re: [COMMITTERS] pgsql: Don't archive bogus recycled or preallocated files after timelin

2015-04-13 Thread Heikki Linnakangas
On 04/14/2015 02:24 AM, Tom Lane wrote: Heikki Linnakangas writes: To fix, whenever we switch to a new timeline, scan the data directory for WAL segments on the old timeline, but with a higher segment number, and remove them. Wait a minute. Didn't you just break PITR scenarios? The *entire