[COMMITTERS] pgsql: Don't leave 'tmp_check' directory behind in pg_rewind regression

2015-04-22 Thread Heikki Linnakangas
Don't leave 'tmp_check' directory behind in pg_rewind regression tests. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4d930eee89954ef8ac5402f3d568c11ff6256035 Modified Files -- src/bin/pg_rewind/RewindTest.pm |6 -- 1 file changed, 4 insertions(+

Re: [COMMITTERS] pgsql: Add missing installcheck target to pg_rewind's Makefile

2015-04-22 Thread Heikki Linnakangas
On 04/21/2015 11:38 PM, Tom Lane wrote: Heikki Linnakangas writes: Add missing installcheck target to pg_rewind's Makefile This patch seems a brick shy of a load, in that "make installcheck" in bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory. installcheck in any other

[COMMITTERS] pgsql: Rename pg_replication_slot's new active_in to active_pid.

2015-04-22 Thread Andres Freund
Rename pg_replication_slot's new active_in to active_pid. In d811c037ce active_in was added but discussion since showed that active_pid is preferred as a name. Discussion: camsr+yfkgzca5_7_ouamwxa5pnejc9lnvipzpdhusaphu9p...@mail.gmail.com Branch -- master Details --- http://git.postgres

[COMMITTERS] pgsql: Make the pg_rewind regression tests more robust on slow systems.

2015-04-22 Thread Heikki Linnakangas
Make the pg_rewind regression tests more robust on slow systems. There were a couple of hard-coded sleeps in the tests: to wait for standby to catch up with master, and to wait for promotion with "pg_ctl promote" to complete. Instead of a fixed, hard-coded sleep, poll the server with a query once

[COMMITTERS] pgsql: Pull in tableoid for inheiritance with rowMarks

2015-04-22 Thread Stephen Frost
Pull in tableoid for inheiritance with rowMarks As noted by Etsuro Fujita [1] and Dean Rasheed[2], cb1ca4d800621dcae67ca6c799006de99fa4f0a5 changed ExecBuildAuxRowMark() to always look for the tableoid in the target list, but didn't also change preprocess_targetlist() to always include the tableoi

[COMMITTERS] pgsql: RLS fixes, new hooks, and new test module

2015-04-22 Thread Stephen Frost
RLS fixes, new hooks, and new test module In prepend_row_security_policies(), defaultDeny was always true, so if there were any hook policies, the RLS policies on the table would just get discarded. Fixed to start off with defaultDeny as false and then properly set later if we detect that only th

Re: [COMMITTERS] pgsql: RLS fixes, new hooks, and new test module

2015-04-22 Thread Stephen Frost
* Stephen Frost ([email protected]) wrote: > RLS fixes, new hooks, and new test module Looks like the buildfarm is unhappy with this.. On first blush, I believe the installcheck path isn't loading the module from the config file.. Looking into it. Thanks, Stephen sig

[COMMITTERS] pgsql: Fix installcheck for test_rls_hooks

2015-04-22 Thread Stephen Frost
Fix installcheck for test_rls_hooks As pointed out by the buildfarm, test_rls_hooks wasn't functioning properly with a clean installcheck. test_rls_hooks needs to explicitly load the library with the hooks in it, to allow installcheck to work; using the --temp-config doesn't help since that isn't

[COMMITTERS] pgsql: Use the right type OID after creating a shell type

2015-04-22 Thread Alvaro Herrera
Use the right type OID after creating a shell type Commit a2e35b53c39b2a neglected to update the type OID to use further down in DefineType when TypeShellMake was changed to return ObjectAddress instead of OID (it got it right in DefineRange, however.) This resulted in an internal error message be

Re: [COMMITTERS] pgsql: Make the pg_rewind regression tests more robust on slow systems.

2015-04-22 Thread Michael Paquier
On Wed, Apr 22, 2015 at 8:37 PM, Heikki Linnakangas wrote: > Make the pg_rewind regression tests more robust on slow systems. > > There were a couple of hard-coded sleeps in the tests: to wait for standby > to catch up with master, and to wait for promotion with "pg_ctl promote" > to complete. Ins