[COMMITTERS] pgsql: Copy the relation name for error reporting in WCOs

2015-04-24 Thread Stephen Frost
Copy the relation name for error reporting in WCOs In get_row_security_policies(), we need to make a copy of the relation name when building the WithCheckOptions structure, since RelationGetRelationName just returns a pointer into the local Relation structure. The relation name in the WCO structu

[COMMITTERS] pgsql: Fix misspellings

2015-04-24 Thread Peter Eisentraut
Fix misspellings Amit Langote and Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9ba978c8cc80d6f9e78b2ceef7f94834317b46aa Modified Files -- doc/src/sgml/ddl.sgml |2 +- src/test/regress/expected/updatable_views.out

[COMMITTERS] pgsql: doc: Move ALTER TABLE IF EXISTS description to better place

2015-04-24 Thread Peter Eisentraut
doc: Move ALTER TABLE IF EXISTS description to better place It was previously mixed in with the description of ALTER TABLE subcommands. Move it to the Parameters section, which is where it is on other reference pages. pointed out by Amit Langote Branch -- master Details --- http://git.

Re: [COMMITTERS] pgsql: Fix incorrect matching of subexpressions in outer-join plan node

2015-04-24 Thread Tom Lane
[ catching up on email post-vacation ] Qingqing Zhou writes: > On Mon, Apr 6, 2015 at 4:22 PM, Tom Lane wrote: >> Because it's expensive (a syscache lookup per function or operator). >> And that test alone would be insufficient anyway: you'd also have to >> check that there was an appropriate Va

[COMMITTERS] pgsql: Add comments explaining how unique and exclusion constraints are

2015-04-24 Thread Heikki Linnakangas
Add comments explaining how unique and exclusion constraints are enforced. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61a553a09177c4f0a5570168e3b667eff87e354c Modified Files -- src/backend/executor/execIndexing.c | 59 ++

[COMMITTERS] pgsql: Fix obsolete comment in set_rel_size().

2015-04-24 Thread Tom Lane
Fix obsolete comment in set_rel_size(). The cross-reference to set_append_rel_pathlist() was obsoleted by commit e2fa76d80ba571d4de8992de6386536867250474, which split what had been set_rel_pathlist() and child routines into two sets of functions. But I (tgl) evidently missed updating this comment

[COMMITTERS] pgsql: Fix obsolete comment in set_rel_size().

2015-04-24 Thread Tom Lane
Fix obsolete comment in set_rel_size(). The cross-reference to set_append_rel_pathlist() was obsoleted by commit e2fa76d80ba571d4de8992de6386536867250474, which split what had been set_rel_pathlist() and child routines into two sets of functions. But I (tgl) evidently missed updating this comment

[COMMITTERS] pgsql: Fix obsolete comment in set_rel_size().

2015-04-24 Thread Tom Lane
Fix obsolete comment in set_rel_size(). The cross-reference to set_append_rel_pathlist() was obsoleted by commit e2fa76d80ba571d4de8992de6386536867250474, which split what had been set_rel_pathlist() and child routines into two sets of functions. But I (tgl) evidently missed updating this comment

[COMMITTERS] pgsql: Fix obsolete comment in set_rel_size().

2015-04-24 Thread Tom Lane
Fix obsolete comment in set_rel_size(). The cross-reference to set_append_rel_pathlist() was obsoleted by commit e2fa76d80ba571d4de8992de6386536867250474, which split what had been set_rel_pathlist() and child routines into two sets of functions. But I (tgl) evidently missed updating this comment

Re: [COMMITTERS] pgsql: Fix incorrect matching of subexpressions in outer-join plan node

2015-04-24 Thread Andres Freund
On 2015-04-24 13:30:49 -0400, Tom Lane wrote: > [ catching up on email post-vacation ] Welcome back Tom! Hope you had a nice and relaxing time. > It's okay to store resulttype and retset > because we disallow changing the output type (including set-ness) of a > function; but we don't want to disa

[COMMITTERS] pgsql: Fix up .gitignore and cleanup actions in some src/test/ subdirec

2015-04-24 Thread Tom Lane
Fix up .gitignore and cleanup actions in some src/test/ subdirectories. examples/, locale/, and thread/ lacked .gitignore files and were also not connected up to top-level "make clean" etc. This had escaped notice because none of those directories are built in normal scenarios. Still, they have

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Remove obsolete -I options from ECPG library compilation.

2015-04-24 Thread Noah Misch
Remove obsolete -I options from ECPG library compilation. The MSVC build system already omitted these. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c8aa893862275614d54a0657d1fb336020c98f60 Modified Files -- src/interfaces/ecpg/compatlib/Makefile |

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Remove superfluous -DFRONTEND.

2015-04-24 Thread Noah Misch
Remove superfluous -DFRONTEND. The majority practice is to add -DFRONTEND in directories building files that are, at other times, built for the backend. Some directories lacking that property added a noise -DFRONTEND in one build system. Remove the excess flags, for consistency. Branch -- ma

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Build every ECPG library with -DFRONTEND.

2015-04-24 Thread Noah Misch
Build every ECPG library with -DFRONTEND. Each of the libraries incorporates src/port files, which often check FRONTEND. Build systems disagreed on whether to build libpgtypes this way. Only libecpg incorporates files that rely on it today. Back-patch to 9.0 (all supported versions) to forestal

[COMMITTERS] pgsql: Perform RLS WITH CHECK before constraints, etc

2015-04-24 Thread Stephen Frost
Perform RLS WITH CHECK before constraints, etc The RLS capability is built on top of the WITH CHECK OPTION system which was added for auto-updatable views, however, unlike WCOs on views (which are mandated by the SQL spec to not fire until after all other constraints and checks are done), it makes

[COMMITTERS] pgsql: Fix file comment for test_rls_hooks.c

2015-04-24 Thread Stephen Frost
Fix file comment for test_rls_hooks.c The file-level comment wasn't updated when it was copied from the shared memory queue test module. Fixed. Noted by Dean Rasheed. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/410cbfd6dd778e8f388fd0d7ee9d84f833700da5 Modified