Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-28 Thread Michael Paquier
On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier wrote: > On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: >> w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes >> in src/tools/msvc/Mkvcbuild.pm at the very least. > > If our goal is to put back to green the Windows n

[COMMITTERS] pgsql: Protect against multixact members wraparound

2015-04-28 Thread Alvaro Herrera
Protect against multixact members wraparound Multixact member files are subject to early wraparound overflow and removal: if the average multixact size is above a certain threshold (see note below) the protections against offset overflow are not enough: during multixact truncation at checkpoint ti

[COMMITTERS] pgsql: Protect against multixact members wraparound

2015-04-28 Thread Alvaro Herrera
Protect against multixact members wraparound Multixact member files are subject to early wraparound overflow and removal: if the average multixact size is above a certain threshold (see note below) the protections against offset overflow are not enough: during multixact truncation at checkpoint ti

[COMMITTERS] pgsql: Protect against multixact members wraparound

2015-04-28 Thread Alvaro Herrera
Protect against multixact members wraparound Multixact member files are subject to early wraparound overflow and removal: if the average multixact size is above a certain threshold (see note below) the protections against offset overflow are not enough: during multixact truncation at checkpoint ti

[COMMITTERS] pgsql: Fix MSVC builds for contrib transforms modules.

2015-04-28 Thread Andrew Dunstan
Fix MSVC builds for contrib transforms modules. With this patch the MSVC build and installation will work correctly with the transforms. However the python transform tests for hstore and ltree are still disabled pending some further adjustments. Michael Paquier with some tweaks from me. Branch -

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-28 Thread Andrew Dunstan
On 04/28/2015 09:04 AM, Michael Paquier wrote: On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier wrote: On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: w.r.t MSVC builds, it looks like we need entries in $contrib_extraincludes in src/tools/msvc/Mkvcbuild.pm at the very least. If our g

Re: [COMMITTERS] pgsql: Add transforms feature

2015-04-28 Thread Andrew Dunstan
[switching to -hackers] On 04/28/2015 11:51 AM, Andrew Dunstan wrote: On 04/28/2015 09:04 AM, Michael Paquier wrote: On Tue, Apr 28, 2015 at 10:01 AM, Michael Paquier wrote: On Tue, Apr 28, 2015 at 9:55 AM, Andrew Dunstan wrote: w.r.t MSVC builds, it looks like we need entries in $contrib_

[COMMITTERS] pgsql: Code review for multixact bugfix

2015-04-28 Thread Alvaro Herrera
Code review for multixact bugfix Reword messages, rename a confusingly named function. Per Robert Haas. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d3821e70c9b6d76083f4eb0f4cc25716e961c89d Modified Files -- src/backend/access/transam/multixact.c |

[COMMITTERS] pgsql: Code review for multixact bugfix

2015-04-28 Thread Alvaro Herrera
Code review for multixact bugfix Reword messages, rename a confusingly named function. Per Robert Haas. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9ae6c11f97babdac4d52b5d86ea0f1636abe37fd Modified Files -- src/backend/access/transam/multixac

[COMMITTERS] pgsql: Code review for multixact bugfix

2015-04-28 Thread Alvaro Herrera
Code review for multixact bugfix Reword messages, rename a confusingly named function. Per Robert Haas. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cf0d888ac5fbdc62e09cde3facb8b8aaa549c015 Modified Files -- src/backend/access/transam/multixac

[COMMITTERS] pgsql: Fix ATSimpleRecursion() to allow recursion from a foreign table.

2015-04-28 Thread Tom Lane
Fix ATSimpleRecursion() to allow recursion from a foreign table. This is necessary in view of the changes to allow foreign tables to be full members of inheritance hierarchies, but I (tgl) unaccountably missed it in commit cb1ca4d800621dcae67ca6c799006de99fa4f0a5. Noted by Amit Langote, patch by

[COMMITTERS] pgsql: Fix another test for RELKIND_RELATION that should allow foreign

2015-04-28 Thread Tom Lane
Fix another test for RELKIND_RELATION that should allow foreign tables now. I thought I'd gone through all of these before, but a fresh review found this one too. (Perhaps it would be better to just delete this test and let the failure occur later, but for the moment I'll preserve the logic.) Th

[COMMITTERS] pgsql: Warn about tablespace creation in PGDATA

2015-04-28 Thread Bruce Momjian
Warn about tablespace creation in PGDATA Also add warning to pg_upgrade Report by Josh Berkus Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/33cb8ff6aa1159f0a359691ca563c98b85d3d723 Modified Files -- src/backend/commands/tablespace.c |6 ++ src/

[COMMITTERS] pgsql: pg_basebackup: canonicalize old and new tablespace paths

2015-04-28 Thread Bruce Momjian
pg_basebackup: canonicalize old and new tablespace paths This avoids problems with double-slash-specified paths. Patch by Ian Barwick Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f19d8f14c776b0fa144227ecb2fc17e868a2cc5c Modified Files -- src/bin/pg_

[COMMITTERS] pgsql: doc: recommend use of GUC server_version_num for version checks

2015-04-28 Thread Bruce Momjian
doc: recommend use of GUC server_version_num for version checks Patch by Craig Ringer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5086dfceba79ecd5d1eb28b8f4ed5221838ff3a6 Modified Files -- doc/src/sgml/func.sgml |9 +++-- 1 file changed, 7 in

[COMMITTERS] pgsql: to_char(): have format 'OF' only show the leading negative sign

2015-04-28 Thread Bruce Momjian
to_char(): have format 'OF' only show the leading negative sign Previously both hours and minutes displayed as negative. Report by David Pozsar Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9b43d73b3f9bef276a46660920a01f0421c4323a Modified Files -- s