[COMMITTERS] pgsql: Fix python_includespec on Windows at configure time

2015-05-03 Thread Andrew Dunstan
Fix python_includespec on Windows at configure time By converting to using forward slashes at configure time we avoid having to repeat the logic anywhere that this is needed, such as in transforms modules for plpython. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/

[COMMITTERS] pgsql: Enable transforms modules to build and run with Mingw builds.

2015-05-03 Thread Andrew Dunstan
Enable transforms modules to build and run with Mingw builds. These modules were all missing essential Windows scaffolding, including resources files and descriptions, and links to the relevant library import files. This latter item means that the modules can't be built with pgxs on Windows, as we

[COMMITTERS] pgsql: fix escaping of brackets for m4 broken in b6b2149e48aa61981ae019

2015-05-03 Thread Andrew Dunstan
fix escaping of brackets for m4 broken in b6b2149e48aa61981ae0199c963d5145a37c258c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f707b53449f3ab6998c615b746ad01f5775723a3 Modified Files -- config/python.m4 |2 +- configure|2 +- 2 files ch

[COMMITTERS] pgsql: Fix overlooked relcache invalidation in ALTER TABLE ... ALTER CO

2015-05-03 Thread Tom Lane
Fix overlooked relcache invalidation in ALTER TABLE ... ALTER CONSTRAINT. When altering the deferredness state of a foreign key constraint, we correctly updated the catalogs and then invalidated the relcache state for the target relation ... but that's not the only relation with relevant triggers.

[COMMITTERS] pgsql: Fix overlooked relcache invalidation in ALTER TABLE ... ALTER CO

2015-05-03 Thread Tom Lane
Fix overlooked relcache invalidation in ALTER TABLE ... ALTER CONSTRAINT. When altering the deferredness state of a foreign key constraint, we correctly updated the catalogs and then invalidated the relcache state for the target relation ... but that's not the only relation with relevant triggers.

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Tom Lane
Peter Eisentraut writes: > ... I'm confused why prairiedog is complaining > about that. According to Internet lore, this flag seems to be available > from OS X either 10.3 or 10.1. prairiedog is listed as 10.4, but errors > with > MACOSX_DEPLOYMENT_TARGET environment variable set to: 10.1 >

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Tom Lane
I wrote: > In short then, my best guess is that the 10.4-era build tools defaulted > to building 10.1-compatible product files unless you explicitly override > that by setting MACOSX_DEPLOYMENT_TARGET, which I haven't. And indeed, explicitly setting MACOSX_DEPLOYMENT_TARGET = 10.4 gets past the bu

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Tom Lane
I wrote: > And indeed, explicitly setting MACOSX_DEPLOYMENT_TARGET = 10.4 gets > past the build failure. In the interests of getting the buildfarm > back to green, I've added that to the build environment spec for > prairiedog (we should have confirmation that it works in an hour or so). Well, it

Re: [COMMITTERS] pgsql: Move interpreter shared library detection to configure

2015-05-03 Thread Tom Lane
Peter Eisentraut writes: > Move interpreter shared library detection to configure BTW, the installation documentation concerning Python (installation.sgml lines 219ff) is badly in need of updates following this commit. regards, tom lane -- Sent via pgsql-committers mai

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Andrew Dunstan
On 05/03/2015 06:27 PM, Tom Lane wrote: I wrote: And indeed, explicitly setting MACOSX_DEPLOYMENT_TARGET = 10.4 gets past the build failure. In the interests of getting the buildfarm back to green, I've added that to the build environment spec for prairiedog (we should have confirmation that i

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Tom Lane
Andrew Dunstan writes: > On 05/03/2015 06:27 PM, Tom Lane wrote: >> Well, it sort of works. Looks like the hstore_plpython test is expecting >> some library function that Python 2.3 doesn't have. > I don't know if we have a standard for supported Python versions, but > Python 2.3.0 was released

Re: [COMMITTERS] pgsql: Add transforms feature

2015-05-03 Thread Andrew Dunstan
On 05/03/2015 06:54 PM, Tom Lane wrote: Andrew Dunstan writes: On 05/03/2015 06:27 PM, Tom Lane wrote: Well, it sort of works. Looks like the hstore_plpython test is expecting some library function that Python 2.3 doesn't have. I don't know if we have a standard for supported Python version

[COMMITTERS] pgsql: Second try at fixing warnings caused by commit 9b43d73b3f9bef27.

2015-05-03 Thread Tom Lane
Second try at fixing warnings caused by commit 9b43d73b3f9bef27. Commit ef3f9e642d2b2bba suppressed one cause of warnings here, but recent clang on OS X is still unhappy because we're passing a "long" to abs(). The fact that tm_gmtoff is declared as long is no doubt a hangover from days when int