[COMMITTERS] pgsql: Fix pg_get_functiondef() to print a function's LEAKPROOF propert

2015-05-28 Thread Tom Lane
Fix pg_get_functiondef() to print a function's LEAKPROOF property. Seems to have been an oversight in the original leakproofness patch. Per report and patch from Jeevan Chalke. In passing, prettify some awkward leakproof-related code in AlterFunction. Branch -- master Details --- http:/

[COMMITTERS] pgsql: Fix pg_get_functiondef() to print a function's LEAKPROOF propert

2015-05-28 Thread Tom Lane
Fix pg_get_functiondef() to print a function's LEAKPROOF property. Seems to have been an oversight in the original leakproofness patch. Per report and patch from Jeevan Chalke. In passing, prettify some awkward leakproof-related code in AlterFunction. Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: Fix pg_get_functiondef() to print a function's LEAKPROOF propert

2015-05-28 Thread Tom Lane
Fix pg_get_functiondef() to print a function's LEAKPROOF property. Seems to have been an oversight in the original leakproofness patch. Per report and patch from Jeevan Chalke. In passing, prettify some awkward leakproof-related code in AlterFunction. Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: Fix pg_get_functiondef() to print a function's LEAKPROOF propert

2015-05-28 Thread Tom Lane
Fix pg_get_functiondef() to print a function's LEAKPROOF property. Seems to have been an oversight in the original leakproofness patch. Per report and patch from Jeevan Chalke. In passing, prettify some awkward leakproof-related code in AlterFunction. Branch -- REL9_2_STABLE Details ---

[COMMITTERS] pgsql: Fix assorted inconsistencies in our calls of readlink().

2015-05-28 Thread Tom Lane
Fix assorted inconsistencies in our calls of readlink(). Ensure that we null-terminate the result string (one place in pg_rewind). Be paranoid about out-of-range results from readlink() (should not happen, but there is no good reason for some call sites to be careful about it and others not). Con

[COMMITTERS] pgsql: Remove pg_audit

2015-05-28 Thread Stephen Frost
Remove pg_audit This removes pg_audit, per discussion: [email protected] Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5f1a4f1e350f1e72531d032eaa9095ba5baeb51 Modified Files -- contrib/pg_audit/.gitignore|5 -

Re: [COMMITTERS] pgsql: Remove pg_audit

2015-05-28 Thread Heikki Linnakangas
On 05/28/2015 07:41 PM, Stephen Frost wrote: Remove pg_audit This removes pg_audit, per discussion: [email protected] Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5f1a4f1e350f1e72531d032eaa9095ba5baeb51 Modified Files -- c

[COMMITTERS] pgsql: Fix pg_rewind's handling of top-level symlinks.

2015-05-28 Thread Tom Lane
Fix pg_rewind's handling of top-level symlinks. The previous coding suffered a null-pointer dereference if it found any symlink at the top level of $PGDATA. Fix that, and teach it to recurse into a symlink for pg_xlog, but not anything else. Per note from Abhijit Menon-Sen. Branch -- master

Re: [COMMITTERS] pgsql: Remove pg_audit

2015-05-28 Thread Stephen Frost
* Heikki Linnakangas ([email protected]) wrote: > On 05/28/2015 07:41 PM, Stephen Frost wrote: > >Remove pg_audit > > > >This removes pg_audit, per discussion: > > > >[email protected] > > > >Branch > >-- > >master > > > >Details > >--- > >http://git.postgresql.org/pg

[COMMITTERS] pgsql: Finish removing pg_audit

2015-05-28 Thread Stephen Frost
Finish removing pg_audit Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cde9cf170cf0f6fbd06b24930dab22d4445e3fb6 Modified Files -- contrib/Makefile |1 - doc/src/sgml/pgaudit.sgml | 678 - 2 files c

Re: [COMMITTERS] pgsql: Finish removing pg_audit

2015-05-28 Thread Stephen Frost
And another thing to fix. I'm really not having a great day. One moment. * Stephen Frost ([email protected]) wrote: > Finish removing pg_audit > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/cde9cf170cf0f6fbd06b24930dab22d4445e3fb6 > > Modified Fi

[COMMITTERS] pgsql: Remove *pgaudit* references also.

2015-05-28 Thread Stephen Frost
Remove *pgaudit* references also. Fixes the docs build. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d5442cb2434c303fa2afc747cdac65df958ff8ac Modified Files -- doc/src/sgml/contrib.sgml |1 - doc/src/sgml/filelist.sgml |1 - 2 files changed, 2

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks

[COMMITTERS] pgsql: Fix fsync-at-startup code to not treat errors as fatal.

2015-05-28 Thread Tom Lane
Fix fsync-at-startup code to not treat errors as fatal. Commit 2ce439f3379aed857517c8ce207485655000fc8e introduced a rather serious regression, namely that if its scan of the data directory came across any un-fsync-able files, it would fail and thereby prevent database startup. Worse yet, symlinks