[COMMITTERS] pgsql: Make Python tests more portable

2015-05-31 Thread Peter Eisentraut
Make Python tests more portable Newer Python versions randomize the hash seed for dictionaries, resulting in a random output order, which messes up the regression test diffs. Instead, use Python assert to compare the dictionaries with their expected value. Branch -- master Details --- h

[COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Andrew Dunstan
Rename jsonb_replace to jsonb_set and allow it to add new values The function is given a fourth parameter, which defaults to true. When this parameter is true, if the last element of the path is missing in the original json, jsonb_set creates it in the result and assigns it the new value. If it is

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Tom Lane
Andrew Dunstan writes: > Rename jsonb_replace to jsonb_set and allow it to add new values Buildfarm doesn't seem terribly pleased with this... regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscrip

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Andrew Dunstan
On 05/31/2015 09:40 PM, Tom Lane wrote: Andrew Dunstan writes: Rename jsonb_replace to jsonb_set and allow it to add new values Buildfarm doesn't seem terribly pleased with this... Weird. I ran make check, of course, and even on the same machine crake is on. An

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Tom Lane
Andrew Dunstan writes: > On 05/31/2015 09:40 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Rename jsonb_replace to jsonb_set and allow it to add new values >> Buildfarm doesn't seem terribly pleased with this... > Weird. I ran make check, of course, and even on the same machine crake > is

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Tom Lane
I wrote: > Some of the other machines are showing crashes, not just minor output > diffs. I tried HEAD on two different machines, and they are both showing Assert failures here: (gdb) bt #0 0x00341ce32625 in raise () from /lib64/libc.so.6 #1 0x00341ce33e05 in abort () from /lib64/libc.s

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Andrew Dunstan
On 05/31/2015 10:06 PM, Tom Lane wrote: Andrew Dunstan writes: On 05/31/2015 09:40 PM, Tom Lane wrote: Andrew Dunstan writes: Rename jsonb_replace to jsonb_set and allow it to add new values Buildfarm doesn't seem terribly pleased with this... Weird. I ran make check, of course, and even

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Tom Lane
Andrew Dunstan writes: > well, that's what we have a buildfarm for. It looks like this problem is in setPathObject: setPathObject(JsonbIterator **it, Datum *path_elems, bool *path_nulls, int path_len, JsonbParseState **st, int level, Jsonb *newval, uint32 npairs, bool

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Andrew Dunstan
On 05/31/2015 10:17 PM, Tom Lane wrote: I wrote: Some of the other machines are showing crashes, not just minor output diffs. I tried HEAD on two different machines, and they are both showing Assert failures here: (gdb) bt #0 0x00341ce32625 in raise () from /lib64/libc.so.6 #1 0x003

[COMMITTERS] pgsql: Add a couple of missing JsonbValue type initialisers.

2015-05-31 Thread Andrew Dunstan
Add a couple of missing JsonbValue type initialisers. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/28b29f7e44534339f88ea914794f8b64e13bc528 Modified Files -- src/backend/utils/adt/jsonfuncs.c |2 ++ 1 file changed, 2 insertions(+) -- Sent via pgs

Re: [COMMITTERS] pgsql: Rename jsonb_replace to jsonb_set and allow it to add new values

2015-05-31 Thread Andrew Dunstan
On 05/31/2015 10:25 PM, Tom Lane wrote: Andrew Dunstan writes: well, that's what we have a buildfarm for. It looks like this problem is in setPathObject: setPathObject(JsonbIterator **it, Datum *path_elems, bool *path_nulls, int path_len, JsonbParseState **st, int level,

[COMMITTERS] pgsql: Avoid naming a variable "new", and remove bogus initializer.

2015-05-31 Thread Andrew Dunstan
Avoid naming a variable "new", and remove bogus initializer. Per gripe from Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/50ab76d3c19c95589f4eb19683e25cb88a2506e2 Modified Files -- src/backend/utils/adt/jsonfuncs.c | 20 ++--