[COMMITTERS] pgsql: Revert changes to pthread configure tests on REL9_5_STABLE.

2015-07-09 Thread Heikki Linnakangas
Revert changes to pthread configure tests on REL9_5_STABLE. Some buildfarm animals are still unhappy. These changes are becoming too invasive for backpatch, for little benefit. This reverts commits 080c4dab3d9575449b81604051b160597cfd55c3 and ce0da6261004ac15f01c21d8b94f11af7a098243. Branch -

[COMMITTERS] pgsql: Use AS_IF rather than plain shell "if" in pthread-check.

2015-07-09 Thread Heikki Linnakangas
Use AS_IF rather than plain shell "if" in pthread-check. Autoconf generates additional code for the first AC_CHECK_HEADERS call in the script. If the first call is within an if-block, the additional code is put inside the if-block too, even though it is needed by subsequent AC_CHECK_HEADERS checks

Re: [COMMITTERS] pgsql: Replace our hacked version of ax_pthread.m4 with latest upstream

2015-07-09 Thread Heikki Linnakangas
On 07/09/2015 06:17 AM, Tom Lane wrote: While my RHEL6 box seems happy now, this change has completely broken pademelon/gaur (which were not broken prior to the rearrangement), and I believe it also accounts for frogmouth being unhappy. The pademelon/gaur failure is because we are now failing to

[COMMITTERS] pgsql: Improve logging of TAP tests.

2015-07-09 Thread Heikki Linnakangas
Improve logging of TAP tests. Create a log file for each test run. Stdout and stderr of the test script, as well as any subprocesses run as part of the test, are redirected to the log file. This makes it a lot easier to debug test failures. Also print the test output (ok 12 - ... messages) to the

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Fix another broken link in documentation.

2015-07-09 Thread Heikki Linnakangas
Fix another broken link in documentation. Tom fixed another one of these in commit 7f32dbcd, but there was another almost identical one in libpq docs. Per his comment: HP's web server has apparently become case-sensitive sometime recently. Per bug #13479 from Daniel Abraham. Corrected link ident

[COMMITTERS] pgsql: Use --debug flag in "remote" pg_rewind regression tests.

2015-07-09 Thread Heikki Linnakangas
Use --debug flag in "remote" pg_rewind regression tests. Gives more information in the log, to debug possible failures. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/23b8928829038ef3fba5a04e4f2707c6034464c4 Modified Files -- src/bin/pg_rewind/RewindTes

[COMMITTERS] pgsql: Make wal_compression PGC_SUSET rather than PGC_USERSET.

2015-07-09 Thread Fujii Masao
Make wal_compression PGC_SUSET rather than PGC_USERSET. When enabling wal_compression, there is a risk to leak data similarly to the BREACH and CRIME attacks on SSL where the compression ratio of a full page image gives a hint of what is the existing data of this page. This vulnerability is quite

[COMMITTERS] pgsql: Make wal_compression PGC_SUSET rather than PGC_USERSET.

2015-07-09 Thread Fujii Masao
Make wal_compression PGC_SUSET rather than PGC_USERSET. When enabling wal_compression, there is a risk to leak data similarly to the BREACH and CRIME attacks on SSL where the compression ratio of a full page image gives a hint of what is the existing data of this page. This vulnerability is quite

[COMMITTERS] pgsql: Fix obsolete comment regarding NOTICE message level.

2015-07-09 Thread Fujii Masao
Fix obsolete comment regarding NOTICE message level. By default NOTICE message is not sent to server log because the default value of log_min_messages is WARNING since 8.4. Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6ba365aa4621b0e4c4c0920cbdf5634

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

[COMMITTERS] pgsql: Fix postmaster's handling of a startup-process crash.

2015-07-09 Thread Tom Lane
Fix postmaster's handling of a startup-process crash. Ordinarily, a failure (unexpected exit status) of the startup subprocess should be considered fatal, so the postmaster should just close up shop and quit. However, if we sent the startup process a SIGQUIT or SIGKILL signal, the failure is hard

Re: [COMMITTERS] pgsql: Replace our hacked version of ax_pthread.m4 with latest upstream

2015-07-09 Thread Peter Eisentraut
On 7/8/15 4:39 PM, Tom Lane wrote: > Heikki Linnakangas writes: >> I'm debugging this ATM. You're probably seeing a failure similar to >> shearwater. The problem seems to be that the earlier autoconf tests add >> "-lrt" to LIBS, and that somehow pulls in pthread_join() and other >> functions, b

[COMMITTERS] pgsql: Improve documentation about array concat operator vs. underlying

2015-07-09 Thread Tom Lane
Improve documentation about array concat operator vs. underlying functions. The documentation implied that there was seldom any reason to use the array_append, array_prepend, and array_cat functions directly. But that's not really true, because they can help make it clear which case is meant, whi

[COMMITTERS] pgsql: Improve documentation about array concat operator vs. underlying

2015-07-09 Thread Tom Lane
Improve documentation about array concat operator vs. underlying functions. The documentation implied that there was seldom any reason to use the array_append, array_prepend, and array_cat functions directly. But that's not really true, because they can help make it clear which case is meant, whi

[COMMITTERS] pgsql: Improve documentation about array concat operator vs. underlying

2015-07-09 Thread Tom Lane
Improve documentation about array concat operator vs. underlying functions. The documentation implied that there was seldom any reason to use the array_append, array_prepend, and array_cat functions directly. But that's not really true, because they can help make it clear which case is meant, whi

[COMMITTERS] pgsql: Improve documentation about array concat operator vs. underlying

2015-07-09 Thread Tom Lane
Improve documentation about array concat operator vs. underlying functions. The documentation implied that there was seldom any reason to use the array_append, array_prepend, and array_cat functions directly. But that's not really true, because they can help make it clear which case is meant, whi

[COMMITTERS] pgsql: Improve documentation about array concat operator vs. underlying

2015-07-09 Thread Tom Lane
Improve documentation about array concat operator vs. underlying functions. The documentation implied that there was seldom any reason to use the array_append, array_prepend, and array_cat functions directly. But that's not really true, because they can help make it clear which case is meant, whi