[COMMITTERS] pgsql: Redesign tablesample method API, and do extensive code review.

2015-07-25 Thread Tom Lane
Redesign tablesample method API, and do extensive code review. The original implementation of TABLESAMPLE modeled the tablesample method API on index access methods, which wasn't a good choice because, without specialized DDL commands, there's no way to build an extension that can implement a TSM.

[COMMITTERS] pgsql: Redesign tablesample method API, and do extensive code review.

2015-07-25 Thread Tom Lane
Redesign tablesample method API, and do extensive code review. The original implementation of TABLESAMPLE modeled the tablesample method API on index access methods, which wasn't a good choice because, without specialized DDL commands, there's no way to build an extension that can implement a TSM.

[COMMITTERS] pgsql: Update oidjoins regression test for 9.5.

2015-07-25 Thread Tom Lane
Update oidjoins regression test for 9.5. New FK relationships for pg_transform. Also findoidjoins now detects a few relationships it didn't before for pre-existing catalogs, as a result of new regression tests leaving entries in those catalogs that weren't there before. Branch -- master Det

[COMMITTERS] pgsql: Update oidjoins regression test for 9.5.

2015-07-25 Thread Tom Lane
Update oidjoins regression test for 9.5. New FK relationships for pg_transform. Also findoidjoins now detects a few relationships it didn't before for pre-existing catalogs, as a result of new regression tests leaving entries in those catalogs that weren't there before. Branch -- REL9_5_STAB

[COMMITTERS] pgsql: In pg_ctl, report unexpected failure to stat() the postmaster.pi

2015-07-25 Thread Tom Lane
In pg_ctl, report unexpected failure to stat() the postmaster.pid file. Any error other than ENOENT is a bit suspicious here, and perhaps should not be grounds for assuming the postmaster has failed. For the moment though, just report it, and don't change the behavior otherwise. The intent is ma

[COMMITTERS] pgsql: In pg_ctl, report unexpected failure to stat() the postmaster.pi

2015-07-25 Thread Tom Lane
In pg_ctl, report unexpected failure to stat() the postmaster.pid file. Any error other than ENOENT is a bit suspicious here, and perhaps should not be grounds for assuming the postmaster has failed. For the moment though, just report it, and don't change the behavior otherwise. The intent is ma

[COMMITTERS] pgsql: Some platforms now need contrib/tsm_system_time to be linked wit

2015-07-25 Thread Tom Lane
Some platforms now need contrib/tsm_system_time to be linked with libm. Buildfarm member hornet, at least, seems to want -lm in the link command. Probably this is due to the just-added use of isnan(). Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c879d51c5918ab5fc8

[COMMITTERS] pgsql: Some platforms now need contrib/tsm_system_time to be linked wit

2015-07-25 Thread Tom Lane
Some platforms now need contrib/tsm_system_time to be linked with libm. Buildfarm member hornet, at least, seems to want -lm in the link command. Probably this is due to the just-added use of isnan(). Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/62005e9465a

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

[COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
Restore use of zlib default compression in pg_dump directory mode. This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and friends, which ignored the fact that gzopen() will treat "-1" in the mode argument as an invalid character, which it ignores, and a flag for compression level 1

Re: [COMMITTERS] pgsql: Replace our hacked version of ax_pthread.m4 with latest upstream

2015-07-25 Thread Tom Lane
I've located another problem in the new improved ax_pthread.m4 script: prairiedog is now concluding that it should use -pthread, which leads to a whole bunch of build warnings along the lines of powerpc-apple-darwin8-gcc-4.0.1: unrecognized option '-pthread' Previously it concluded that it didn't

Re: [COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Tom Lane
Andrew Dunstan writes: > Restore use of zlib default compression in pg_dump directory mode. Buildfarm's not too happy with the 9.1 version of this. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your sub

Re: [COMMITTERS] pgsql: Restore use of zlib default compression in pg_dump directory mod

2015-07-25 Thread Andrew Dunstan
On 07/25/2015 05:57 PM, Tom Lane wrote: Andrew Dunstan writes: Restore use of zlib default compression in pg_dump directory mode. Buildfarm's not too happy with the 9.1 version of this. Oops. Will fix. cheers andrew -- Sent via pgsql-committers mailing list (p

[COMMITTERS] pgsql: Fix up bad call to exit_nicely from commit af225551ef

2015-07-25 Thread Andrew Dunstan
Fix up bad call to exit_nicely from commit af225551ef The signature for this changed in 9.2 Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2e226763e3ad160b768b13793db645b31455edea Modified Files -- src/bin/pg_dump/pg_dump.c |2 +- 1 file chang

[COMMITTERS] pgsql: Dodge portability issue (apparent compiler bug) in new tablesamp

2015-07-25 Thread Tom Lane
Dodge portability issue (apparent compiler bug) in new tablesample code. Some of the older OS X critters in the buildfarm are failing regression, with symptoms showing that a request for 100% sampling in BERNOULLI or SYSTEM methods actually gets only around 50% of the table. gdb revealed that the

[COMMITTERS] pgsql: Dodge portability issue (apparent compiler bug) in new tablesamp

2015-07-25 Thread Tom Lane
Dodge portability issue (apparent compiler bug) in new tablesample code. Some of the older OS X critters in the buildfarm are failing regression, with symptoms showing that a request for 100% sampling in BERNOULLI or SYSTEM methods actually gets only around 50% of the table. gdb revealed that the

[COMMITTERS] pgsql: Improve markup for row_security.

2015-07-25 Thread Joe Conway
Improve markup for row_security. Wrap the literals on, off, force, and BYPASSRLS with appropriate markup. Per Kevin Grittner. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cf80ddee57103bb3b454c1607d100a4551d7a48c Modified Files -- doc/src/sgml/config.s

[COMMITTERS] pgsql: Improve markup for row_security.

2015-07-25 Thread Joe Conway
Improve markup for row_security. Wrap the literals on, off, force, and BYPASSRLS with appropriate markup. Per Kevin Grittner. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/60624f45fc12a249fd48ac7557238c974d8e5011 Modified Files -- doc/src/sgml/c