[COMMITTERS] pgsql: Fix typo in comment.

2015-07-29 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a309ebd6b9940ca466c7748eeefc93c86ba2c9d4 Modified Files -- src/backend/commands/tablecmds.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: Fix typo in comment.

2015-07-29 Thread Heikki Linnakangas
Fix typo in comment. Amit Langote Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6f1789a475fe2726f8ade5ecd3aa14223b130fb1 Modified Files -- src/backend/commands/tablecmds.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Remove outdated comment in LWLockDequeueSelf's header.

2015-07-29 Thread Andres Freund
Remove outdated comment in LWLockDequeueSelf's header. Noticed-By: Robert Haas Backpatch: 9.5, where the function was added Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/81191f65820d3cf29ea94fe7f65c065e8c6a296c Modified Files -- src/backend/stor

[COMMITTERS] pgsql: Remove outdated comment in LWLockDequeueSelf's header.

2015-07-29 Thread Andres Freund
Remove outdated comment in LWLockDequeueSelf's header. Noticed-By: Robert Haas Backpatch: 9.5, where the function was added Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3bc9356ddd52443e209fb60b94a2c29d66259d62 Modified Files -- src/backend/storage/lmg

[COMMITTERS] pgsql: Document how to build the docs using the website style.

2015-07-29 Thread Robert Haas
Document how to build the docs using the website style. Craig Ringer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5f1066074cd85b829371a4123839d16f52553c3d Modified Files -- doc/src/sgml/docguide.sgml |9 + 1 file changed, 9 insertions(+)

[COMMITTERS] pgsql: Make TAP tests work on Windows.

2015-07-29 Thread Heikki Linnakangas
Make TAP tests work on Windows. On Windows, use listen_address=127.0.0.1 to allow TCP connections. We were already using "pg_regress --config-auth" to set up HBA appropriately. The standard_initdb helper function now sets up the server's unix_socket_directories or listen_addresses in the config fi

[COMMITTERS] pgsql: Add missing post create and alter hooks to policy objects.

2015-07-29 Thread Joe Conway
Add missing post create and alter hooks to policy objects. AlterPolicy() and CreatePolicy() lacked their respective hook invocations. Noted by Noah Misch, review by Dean Rasheed. Back-patch to 9.5 where RLS was introduced. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/

[COMMITTERS] pgsql: Add missing post create and alter hooks to policy objects.

2015-07-29 Thread Joe Conway
Add missing post create and alter hooks to policy objects. AlterPolicy() and CreatePolicy() lacked their respective hook invocations. Noted by Noah Misch, review by Dean Rasheed. Back-patch to 9.5 where RLS was introduced. Branch -- master Details --- http://git.postgresql.org/pg/commitd

[COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.

2015-07-29 Thread Tom Lane
Add some test coverage of EvalPlanQual with non-locked tables. A Salesforce colleague of mine griped that the regression tests don't exercise EvalPlanQualFetchRowMarks() and allied routines. Which is a fair complaint. Add test cases that go through the REFERENCE and COPY code paths. Unfortunate

[COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.

2015-07-29 Thread Tom Lane
Add some test coverage of EvalPlanQual with non-locked tables. A Salesforce colleague of mine griped that the regression tests don't exercise EvalPlanQualFetchRowMarks() and allied routines. Which is a fair complaint. Add test cases that go through the REFERENCE and COPY code paths. Unfortunate

Re: [COMMITTERS] pgsql: Make TAP tests work on Windows.

2015-07-29 Thread Tom Lane
Heikki Linnakangas writes: > Make TAP tests work on Windows. I think this might've broken buildfarm member crake. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.o

Re: [COMMITTERS] pgsql: Add some test coverage of EvalPlanQual with non-locked tables.

2015-07-29 Thread Alvaro Herrera
Tom Lane wrote: > Add some test coverage of EvalPlanQual with non-locked tables. > > A Salesforce colleague of mine griped that the regression tests don't > exercise EvalPlanQualFetchRowMarks() and allied routines. Which is > a fair complaint. Add test cases that go through the REFERENCE and COP

[COMMITTERS] pgsql: Fix TAP tests with "make installcheck".

2015-07-29 Thread Heikki Linnakangas
Fix TAP tests with "make installcheck". I neglected that the prove_installcheck rule also needs to also define PG_REGRESS, like prove_check does. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c7f0b28c7a67a8602c65d6b38d40b38d07548fbd Modified Files -- s

Re: [COMMITTERS] pgsql: Make TAP tests work on Windows.

2015-07-29 Thread Heikki Linnakangas
On 07/29/2015 08:37 PM, Tom Lane wrote: Heikki Linnakangas writes: Make TAP tests work on Windows. I think this might've broken buildfarm member crake. Oh, I didn't realize the TAP tests can also run in "make installcheck" mode. Fixed, I hope.. - Heikki -- Sent via pgsql-committers ma

[COMMITTERS] pgsql: Flesh out the background worker documentation.

2015-07-29 Thread Robert Haas
Flesh out the background worker documentation. Make it more clear that bgw_main is usually not what you want. Put the background worker flags in a variablelist rather than having them as part of a paragraph. Explain important limits on how bgw_main_arg can be used. Craig Ringer, substantially r

[COMMITTERS] pgsql: Fix incorrect comment.

2015-07-29 Thread Robert Haas
Fix incorrect comment. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f04ce3147560de90d5250ae822d8d714b76f61cd Modified Files -- src/backend/optimizer/plan/setrefs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgs

[COMMITTERS] pgsql: Create new ParseExprKind for use by policy expressions.

2015-07-29 Thread Joe Conway
Create new ParseExprKind for use by policy expressions. Policy USING and WITH CHECK expressions were using EXPR_KIND_WHERE for parse analysis, which results in inappropriate ERROR messages when the expression contains unsupported constructs such as aggregates. Create a new ParseExprKind called EXP

[COMMITTERS] pgsql: Create new ParseExprKind for use by policy expressions.

2015-07-29 Thread Joe Conway
Create new ParseExprKind for use by policy expressions. Policy USING and WITH CHECK expressions were using EXPR_KIND_WHERE for parse analysis, which results in inappropriate ERROR messages when the expression contains unsupported constructs such as aggregates. Create a new ParseExprKind called EXP

[COMMITTERS] pgsql: Add IF NOT EXISTS processing to ALTER TABLE ADD COLUMN

2015-07-29 Thread Andrew Dunstan
Add IF NOT EXISTS processing to ALTER TABLE ADD COLUMN Fabrízio de Royes Mello, reviewed by Payal Singh, Alvaro Herrera and Michael Paquier. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2cd40adb85d1d5a7fd448721b326e73c1e318750 Modified Files -- doc/sr

[COMMITTERS] pgsql: MSVC: Future-proof installation file skip logic.

2015-07-29 Thread Noah Misch
MSVC: Future-proof installation file skip logic. This code relied on knowing exactly where in the source tree temporary installations might appear. A reasonable hacker may not think to update this code when adding use of a temporary installation, making it fragile. Observe that commit 9fa8b0ee90

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_4_STABLE

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_0_STABLE

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_5_STABLE

[COMMITTERS] pgsql: MSVC: Remove duplicate PATH entry in test harness.

2015-07-29 Thread Noah Misch
MSVC: Remove duplicate PATH entry in test harness. Back-patch to 9.5, where commit 4cb7d671fddc8855c8def2de51fb23df1c8ac0af introduced it. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/95eb4b265502c26c9f72f0f554df41e273551858 Modified Files -- s

[COMMITTERS] pgsql: Remove redundant "make install" from pg_upgrade test suite.

2015-07-29 Thread Noah Misch
Remove redundant "make install" from pg_upgrade test suite. A top-level "make install" includes pg_upgrade since commit 9fa8b0ee90c44c0f97d16bf65e94322988c94864. Back-patch to 9.5, where that commit first appeared. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitd

[COMMITTERS] pgsql: MSVC: Future-proof installation file skip logic.

2015-07-29 Thread Noah Misch
MSVC: Future-proof installation file skip logic. This code relied on knowing exactly where in the source tree temporary installations might appear. A reasonable hacker may not think to update this code when adding use of a temporary installation, making it fragile. Observe that commit 9fa8b0ee90

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_3_STABLE

[COMMITTERS] pgsql: MSVC: Revert most 9.5 changes to pre-9.5 vcregress.pl tests.

2015-07-29 Thread Noah Misch
MSVC: Revert most 9.5 changes to pre-9.5 vcregress.pl tests. The reverted changes did not narrow the semantic gap between the MSVC build system and the GNU make build system. For targets old and new that run multiple suites (contribcheck, modulescheck, tapcheck), restore vcregress.pl to mimicking

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- master Detai

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_2_STABLE

[COMMITTERS] pgsql: Remove redundant "make install" from pg_upgrade test suite.

2015-07-29 Thread Noah Misch
Remove redundant "make install" from pg_upgrade test suite. A top-level "make install" includes pg_upgrade since commit 9fa8b0ee90c44c0f97d16bf65e94322988c94864. Back-patch to 9.5, where that commit first appeared. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/021

[COMMITTERS] pgsql: Blacklist xlc 32-bit inlining.

2015-07-29 Thread Noah Misch
Blacklist xlc 32-bit inlining. Per a suggestion from Tom Lane. Back-patch to 9.0 (all supported versions). While only 9.4 and up have code known to elicit this compiler bug, we were disabling inlining by accident until commit 43d89a23d59c487bc9258fad7a6187864cb8c0c0. Branch -- REL9_1_STABLE

[COMMITTERS] pgsql: MSVC: Remove duplicate PATH entry in test harness.

2015-07-29 Thread Noah Misch
MSVC: Remove duplicate PATH entry in test harness. Back-patch to 9.5, where commit 4cb7d671fddc8855c8def2de51fb23df1c8ac0af introduced it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d6ab14674d636490cec40c9dfc16104f380ced70 Modified Files -- src/tool

[COMMITTERS] pgsql: MSVC: Revert most 9.5 changes to pre-9.5 vcregress.pl tests.

2015-07-29 Thread Noah Misch
MSVC: Revert most 9.5 changes to pre-9.5 vcregress.pl tests. The reverted changes did not narrow the semantic gap between the MSVC build system and the GNU make build system. For targets old and new that run multiple suites (contribcheck, modulescheck, tapcheck), restore vcregress.pl to mimicking