[COMMITTERS] pgsql: Address points made in post-commit review of replication origins

2015-08-07 Thread Andres Freund
Address points made in post-commit review of replication origins. Amit reviewed the replication origins patch and made some good points. Address them. This fixes typos in error messages, docs and comments and adds a missing error check (although in a should-never-happen scenario). Discussion: caa

[COMMITTERS] pgsql: Address points made in post-commit review of replication origins

2015-08-07 Thread Andres Freund
Address points made in post-commit review of replication origins. Amit reviewed the replication origins patch and made some good points. Address them. This fixes typos in error messages, docs and comments and adds a missing error check (although in a should-never-happen scenario). Discussion: caa

[COMMITTERS] pgsql: Don't include low level locking code from frontend code.

2015-08-07 Thread Andres Freund
Don't include low level locking code from frontend code. Some frontend code like e.g. pg_xlogdump or pg_resetxlog, has to use backend headers. Unfortunately until now that code includes most of the locking code. It's generally not nice to expose such low level details, but de6fd1c898 made that a h

[COMMITTERS] pgsql: Fix attach-related race condition in shm_mq_send_bytes.

2015-08-07 Thread Robert Haas
Fix attach-related race condition in shm_mq_send_bytes. Spotted by Antonin Houska. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/846f8c9483a8f31e45bf949db1721706a2765771 Modified Files -- src/backend/storage/ipc/shm_mq.c | 38 +---

[COMMITTERS] pgsql: Fix attach-related race condition in shm_mq_send_bytes.

2015-08-07 Thread Robert Haas
Fix attach-related race condition in shm_mq_send_bytes. Spotted by Antonin Houska. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/caf89b31aa79b472a451a5b13657db0da43decee Modified Files -- src/backend/storage/ipc/shm_mq.c | 38 +

[COMMITTERS] pgsql: Fix attach-related race condition in shm_mq_send_bytes.

2015-08-07 Thread Robert Haas
Fix attach-related race condition in shm_mq_send_bytes. Spotted by Antonin Houska. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e9215461d2a6081812d9c3619c9ec81e5682fe0f Modified Files -- src/backend/storage/ipc/shm_mq.c | 38 +

[COMMITTERS] pgsql: Further adjustments to PlaceHolderVar removal.

2015-08-07 Thread Tom Lane
Further adjustments to PlaceHolderVar removal. A new test case from Andreas Seltenreich showed that we were still a bit confused about removing PlaceHolderVars during join removal. Specifically, remove_rel_from_query would remove a PHV that was used only underneath the removable join, even if the

[COMMITTERS] pgsql: Further adjustments to PlaceHolderVar removal.

2015-08-07 Thread Tom Lane
Further adjustments to PlaceHolderVar removal. A new test case from Andreas Seltenreich showed that we were still a bit confused about removing PlaceHolderVars during join removal. Specifically, remove_rel_from_query would remove a PHV that was used only underneath the removable join, even if the

[COMMITTERS] pgsql: Further adjustments to PlaceHolderVar removal.

2015-08-07 Thread Tom Lane
Further adjustments to PlaceHolderVar removal. A new test case from Andreas Seltenreich showed that we were still a bit confused about removing PlaceHolderVars during join removal. Specifically, remove_rel_from_query would remove a PHV that was used only underneath the removable join, even if the

[COMMITTERS] pgsql: Further adjustments to PlaceHolderVar removal.

2015-08-07 Thread Tom Lane
Further adjustments to PlaceHolderVar removal. A new test case from Andreas Seltenreich showed that we were still a bit confused about removing PlaceHolderVars during join removal. Specifically, remove_rel_from_query would remove a PHV that was used only underneath the removable join, even if the

[COMMITTERS] pgsql: Fix bug slowing down pgbench when -P is used.

2015-08-07 Thread Andres Freund
Fix bug slowing down pgbench when -P is used. A removed check in ba3deeefb made all threads but the main one busy-loop when -P was used. All threads computed the time to the next time the progress report should be printed, but only the main thread did so and re-scheduled it only for the future. R

[COMMITTERS] pgsql: Attempt to work around a 32bit xlc compiler bug from a different

2015-08-07 Thread Andres Freund
Attempt to work around a 32bit xlc compiler bug from a different place. In de6fd1c8 I moved the the work around from 53f73879 into the aix template. The previous location was removed in the former commit, and I thought that it would be nice to emit a warning when running configure. That didn't tu

Re: [COMMITTERS] pgsql: Fix bug slowing down pgbench when -P is used.

2015-08-07 Thread Fabien COELHO
A removed check in ba3deeefb Indeed. It seems that it was really removed by 1bc90f7a, that I should have checked... -- Fabien. -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committ