[COMMITTERS] pgsql: Fix uninitialized-variable bug.

2015-10-09 Thread Tom Lane
Fix uninitialized-variable bug. For some reason, neither of the compilers I usually use noticed the uninitialized-variable problem I introduced in commit 7e2a18a9161fee7e. That's hardly a good enough excuse though. Committing with brown paper bag on head. In addition to putting the operations in

[COMMITTERS] pgsql: Fix uninitialized-variable bug.

2015-10-09 Thread Tom Lane
Fix uninitialized-variable bug. For some reason, neither of the compilers I usually use noticed the uninitialized-variable problem I introduced in commit 7e2a18a9161fee7e. That's hardly a good enough excuse though. Committing with brown paper bag on head. In addition to putting the operations in

[COMMITTERS] pgsql: Fix uninitialized-variable bug.

2015-10-09 Thread Tom Lane
Fix uninitialized-variable bug. For some reason, neither of the compilers I usually use noticed the uninitialized-variable problem I introduced in commit 7e2a18a9161fee7e. That's hardly a good enough excuse though. Committing with brown paper bag on head. In addition to putting the operations in

[COMMITTERS] pgsql: Handle append_rel_list in expand_security_qual

2015-10-09 Thread Stephen Frost
Handle append_rel_list in expand_security_qual During expand_security_quals, we take the security barrier quals on an RTE and create a subquery which evaluates the quals. During this, we have to replace any variables in the outer query which refer to the original RTE with references to the column

[COMMITTERS] pgsql: Handle append_rel_list in expand_security_qual

2015-10-09 Thread Stephen Frost
Handle append_rel_list in expand_security_qual During expand_security_quals, we take the security barrier quals on an RTE and create a subquery which evaluates the quals. During this, we have to replace any variables in the outer query which refer to the original RTE with references to the column

Re: [COMMITTERS] pgsql: Perform an immediate shutdown if the postmaster.pid file is remo

2015-10-09 Thread Thom Brown
On 6 October 2015 at 22:16, Tom Lane wrote: > Perform an immediate shutdown if the postmaster.pid file is removed. > > The postmaster now checks every minute or so (worst case, at most two > minutes) that postmaster.pid is still there and still contains its own PID. > If not, it performs an immedi

[COMMITTERS] pgsql: Remove set_latch_on_sigusr1 flag.

2015-10-09 Thread Robert Haas
Remove set_latch_on_sigusr1 flag. This flag has proven to be a recipe for bugs, and it doesn't seem like it can really buy anything in terms of performance. So let's just *always* set the process latch when we receive SIGUSR1 instead of trying to do it only when needed. Per my recent proposal on

[COMMITTERS] pgsql: Make abbreviated key comparisons for text a bit cheaper.

2015-10-09 Thread Robert Haas
Make abbreviated key comparisons for text a bit cheaper. If we do some byte-swapping while abbreviating, we can do comparisons using integer arithmetic rather than memcmp. Peter Geoghegan, reviewed and slightly revised by me. Branch -- master Details --- http://git.postgresql.org/pg/com

Re: [COMMITTERS] pgsql: Perform an immediate shutdown if the postmaster.pid file is remo

2015-10-09 Thread Tom Lane
Thom Brown writes: > The log contains a misleading output following the removal of the pid file: > 2015-10-09 15:39:32 BST [31507]: [4-1] user=,db=,client= LOG: could > not open file "postmaster.pid": No such file or directory > 2015-10-09 15:39:32 BST [31507]: [5-1] user=,db=,client= LOG: > per

Re: [COMMITTERS] pgsql: Perform an immediate shutdown if the postmaster.pid file is remo

2015-10-09 Thread Alvaro Herrera
Tom Lane wrote: > Thom Brown writes: > > The log contains a misleading output following the removal of the pid file: > > > 2015-10-09 15:39:32 BST [31507]: [4-1] user=,db=,client= LOG: could > > not open file "postmaster.pid": No such file or directory > > 2015-10-09 15:39:32 BST [31507]: [5-1]

Re: [COMMITTERS] pgsql: Perform an immediate shutdown if the postmaster.pid file is remo

2015-10-09 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Looks as-expected to me. We're forcing a panic stop. > I think he's complaining that the final HINT is misleading. Well, all the particular backend knows is that it got SIGQUIT. Maybe we should rewrite the message text for that entirely, but that didn

[COMMITTERS] pgsql: Speed up text sorts where the same strings occur multiple times.

2015-10-09 Thread Robert Haas
Speed up text sorts where the same strings occur multiple times. Cache strxfrm() blobs across calls made to the text SortSupport abbreviation routine. This can speed up sorting if the same string needs to be abbreviated many times in a row. Also, cache the result of the previous strcoll() compar