[COMMITTERS] pgsql: Make viewquery a copy in rewriteTargetView()

2015-12-21 Thread Stephen Frost
Make viewquery a copy in rewriteTargetView() Rather than expect the Query returned by get_view_query() to be read-only and then copy bits and pieces of it out, simply copy the entire structure when we get it. This addresses an issue where AcquireRewriteLocks, which is called by acquireLocksOnSubL

[COMMITTERS] pgsql: Make viewquery a copy in rewriteTargetView()

2015-12-21 Thread Stephen Frost
Make viewquery a copy in rewriteTargetView() Rather than expect the Query returned by get_view_query() to be read-only and then copy bits and pieces of it out, simply copy the entire structure when we get it. This addresses an issue where AcquireRewriteLocks, which is called by acquireLocksOnSubL

[COMMITTERS] pgsql: Make viewquery a copy in rewriteTargetView()

2015-12-21 Thread Stephen Frost
Make viewquery a copy in rewriteTargetView() Rather than expect the Query returned by get_view_query() to be read-only and then copy bits and pieces of it out, simply copy the entire structure when we get it. This addresses an issue where AcquireRewriteLocks, which is called by acquireLocksOnSubL

[COMMITTERS] pgsql: Make viewquery a copy in rewriteTargetView()

2015-12-21 Thread Stephen Frost
Make viewquery a copy in rewriteTargetView() Rather than expect the Query returned by get_view_query() to be read-only and then copy bits and pieces of it out, simply copy the entire structure when we get it. This addresses an issue where AcquireRewriteLocks, which is called by acquireLocksOnSubL

[COMMITTERS] pgsql: Fix calculation of space needed for parsed words in tab completi

2015-12-21 Thread Tom Lane
Fix calculation of space needed for parsed words in tab completion. Yesterday in commit d854118c8, I had a serious brain fade leading me to underestimate the number of words that the tab-completion logic could divide a line into. On input such as "(", each character will get seen as a separat

[COMMITTERS] pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO

2015-12-21 Thread Alvaro Herrera
adjust ACL owners for REASSIGN and ALTER OWNER TO When REASSIGN and ALTER OWNER TO are used, both the object owner and ACL list should be changed from the old owner to the new owner. This patch fixes types, foreign data wrappers, and foreign servers to change their ACL list properly; they already

[COMMITTERS] pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO

2015-12-21 Thread Alvaro Herrera
adjust ACL owners for REASSIGN and ALTER OWNER TO When REASSIGN and ALTER OWNER TO are used, both the object owner and ACL list should be changed from the old owner to the new owner. This patch fixes types, foreign data wrappers, and foreign servers to change their ACL list properly; they already

[COMMITTERS] pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO

2015-12-21 Thread Alvaro Herrera
adjust ACL owners for REASSIGN and ALTER OWNER TO When REASSIGN and ALTER OWNER TO are used, both the object owner and ACL list should be changed from the old owner to the new owner. This patch fixes types, foreign data wrappers, and foreign servers to change their ACL list properly; they already

[COMMITTERS] pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO

2015-12-21 Thread Alvaro Herrera
adjust ACL owners for REASSIGN and ALTER OWNER TO When REASSIGN and ALTER OWNER TO are used, both the object owner and ACL list should be changed from the old owner to the new owner. This patch fixes types, foreign data wrappers, and foreign servers to change their ACL list properly; they already

[COMMITTERS] pgsql: Rework internals of changing a type's ownership

2015-12-21 Thread Alvaro Herrera
Rework internals of changing a type's ownership This is necessary so that REASSIGN OWNED does the right thing with composite types, to wit, that it also alters ownership of the type's pg_class entry -- previously, the pg_class entry remained owned by the original user, which caused later other fai

[COMMITTERS] pgsql: some bullshit

2015-12-21 Thread Alvaro Herrera
some bullshit Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/653530c8b1963bf91e19d03305dd0df5ad776bec Modified Files -- src/backend/commands/typecmds.c |4 1 file changed, 4 insertions(+) -- Sent via pgsql-committers mailing list (pgsql

[COMMITTERS] pgsql: Rework internals of changing a type's ownership

2015-12-21 Thread Alvaro Herrera
Rework internals of changing a type's ownership This is necessary so that REASSIGN OWNED does the right thing with composite types, to wit, that it also alters ownership of the type's pg_class entry -- previously, the pg_class entry remained owned by the original user, which caused later other fai

[COMMITTERS] pgsql: Rework internals of changing a type's ownership

2015-12-21 Thread Alvaro Herrera
Rework internals of changing a type's ownership This is necessary so that REASSIGN OWNED does the right thing with composite types, to wit, that it also alters ownership of the type's pg_class entry -- previously, the pg_class entry remained owned by the original user, which caused later other fai

[COMMITTERS] pgsql: Rework internals of changing a type's ownership

2015-12-21 Thread Alvaro Herrera
Rework internals of changing a type's ownership This is necessary so that REASSIGN OWNED does the right thing with composite types, to wit, that it also alters ownership of the type's pg_class entry -- previously, the pg_class entry remained owned by the original user, which caused later other fai

Re: [COMMITTERS] pgsql: some bullshit

2015-12-21 Thread Alvaro Herrera
Alvaro Herrera wrote: > some bullshit This commit was supposed to be squashed with the next one --- hence the, err, not-terribly-descriptive commit message. This mistake may cause future "git bisect" runs to give spurious failures, but I'm disinclined to remove it from history nonetheless. These

Re: [COMMITTERS] pgsql: some bullshit

2015-12-21 Thread Robert Haas
On Mon, Dec 21, 2015 at 6:16 PM, Alvaro Herrera wrote: > Alvaro Herrera wrote: >> some bullshit > > This commit was supposed to be squashed with the next one --- hence > the, err, not-terribly-descriptive commit message. Seems pretty descriptive to me! This made me laugh so hard that I started c

Re: [COMMITTERS] pgsql: some bullshit

2015-12-21 Thread Michael Paquier
On Tue, Dec 22, 2015 at 8:16 AM, Alvaro Herrera wrote: > Alvaro Herrera wrote: >> some bullshit > > This commit was supposed to be squashed with the next one --- hence > the, err, not-terribly-descriptive commit message. This mistake may > cause future "git bisect" runs to give spurious failures,