[COMMITTERS] pgsql: Be more predictable about reporting "lock timeout" vs "statement

2016-05-27 Thread Tom Lane
Be more predictable about reporting "lock timeout" vs "statement timeout". If both timeout indicators are set when we arrive at ProcessInterrupts, we've historically just reported "lock timeout". However, some buildfarm members have been observed to fail isolationtester's timeouts test by reporti

[COMMITTERS] pgsql: Be more predictable about reporting "lock timeout" vs "statement

2016-05-27 Thread Tom Lane
Be more predictable about reporting "lock timeout" vs "statement timeout". If both timeout indicators are set when we arrive at ProcessInterrupts, we've historically just reported "lock timeout". However, some buildfarm members have been observed to fail isolationtester's timeouts test by reporti

[COMMITTERS] pgsql: Be more predictable about reporting "lock timeout" vs "statement

2016-05-27 Thread Tom Lane
Be more predictable about reporting "lock timeout" vs "statement timeout". If both timeout indicators are set when we arrive at ProcessInterrupts, we've historically just reported "lock timeout". However, some buildfarm members have been observed to fail isolationtester's timeouts test by reporti

[COMMITTERS] pgsql: Be more predictable about reporting "lock timeout" vs "statement

2016-05-27 Thread Tom Lane
Be more predictable about reporting "lock timeout" vs "statement timeout". If both timeout indicators are set when we arrive at ProcessInterrupts, we've historically just reported "lock timeout". However, some buildfarm members have been observed to fail isolationtester's timeouts test by reporti

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-05-27 Thread Kevin Grittner
On Tue, May 24, 2016 at 4:56 PM, Andres Freund wrote: > The LSNs of the created index pages will be new, and we'll thus > not necessarily error out when requried. It is *old* LSNs that are *safe* -- *new* LSNs are what trigger the "snapshot too old" error. So your observation may be a reason th

[COMMITTERS] pgsql: Fix DROP ACCESS METHOD IF EXISTS.

2016-05-27 Thread Tom Lane
Fix DROP ACCESS METHOD IF EXISTS. The IF EXISTS option was documented, and implemented in the grammar, but it didn't actually work for lack of support in does_not_exist_skipping(). Per bug #14160. Report and patch by Kouhei Sutou Report: <[email protected]> Bran

[COMMITTERS] pgsql: Fix release-note typo.

2016-05-27 Thread Tom Lane
Fix release-note typo. Léonard Benedetti Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d81ecb9b204ae4aaf10b6a056447fe4ee853d195 Modified Files -- doc/src/sgml/release-9.6.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-co

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-05-27 Thread Kevin Grittner
On Fri, May 27, 2016 at 9:58 AM, Kevin Grittner wrote: > On Tue, May 24, 2016 at 4:56 PM, Andres Freund wrote: >> If an old session with >= repeatable read accesses a clustered >> table (after the cluster committed), they'll now not see any >> errors, because all the LSNs look new. > > Again, it

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-05-27 Thread Kevin Grittner
On Tue, May 24, 2016 at 4:10 PM, Robert Haas wrote: > On Tue, May 24, 2016 at 3:48 PM, Kevin Grittner wrote: >> On Tue, May 24, 2016 at 12:00 PM, Andres Freund wrote: >>> On 2016-05-24 11:24:44 -0500, Kevin Grittner wrote: On Fri, May 6, 2016 at 8:28 PM, Kevin Grittner wrote: > On Fri,

[COMMITTERS] pgsql: Clean up thread management in parallel pg_dump for Windows.

2016-05-27 Thread Tom Lane
Clean up thread management in parallel pg_dump for Windows. Since we start the worker threads with _beginthreadex(), we should use _endthreadex() to terminate them. We got this right in the normal-exit code path, but not so much during an error exit from a worker. In addition, be sure to apply Cl

[COMMITTERS] pgsql: Clean up thread management in parallel pg_dump for Windows.

2016-05-27 Thread Tom Lane
Clean up thread management in parallel pg_dump for Windows. Since we start the worker threads with _beginthreadex(), we should use _endthreadex() to terminate them. We got this right in the normal-exit code path, but not so much during an error exit from a worker. In addition, be sure to apply Cl

[COMMITTERS] pgsql: Clean up thread management in parallel pg_dump for Windows.

2016-05-27 Thread Tom Lane
Clean up thread management in parallel pg_dump for Windows. Since we start the worker threads with _beginthreadex(), we should use _endthreadex() to terminate them. We got this right in the normal-exit code path, but not so much during an error exit from a worker. In addition, be sure to apply Cl

[COMMITTERS] pgsql: Clean up thread management in parallel pg_dump for Windows.

2016-05-27 Thread Tom Lane
Clean up thread management in parallel pg_dump for Windows. Since we start the worker threads with _beginthreadex(), we should use _endthreadex() to terminate them. We got this right in the normal-exit code path, but not so much during an error exit from a worker. In addition, be sure to apply Cl