Re: [COMMITTERS] pgsql: doc: requirepeer is a way to avoid spoofing

2016-08-19 Thread Erik Rijkers
On 2016-08-19 03:42, Bruce Momjian wrote: + On way to prevent spoofing of typo: 'On way to ' should be 'One way to' Erik Rijkers -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgs

[COMMITTERS] pgsql: Remove typedef celt from the regex library, along with macro NOC

2016-08-19 Thread Tom Lane
Remove typedef celt from the regex library, along with macro NOCELT. The regex library used to have a notion of a "collating element" that was distinct from a "character", but Henry Spencer never actually implemented his planned support for multi-character collating elements, and the Tcl crew ripp

[COMMITTERS] pgsql: Clean up another pre-ANSI-C-ism in regex code: get rid of pcolor

2016-08-19 Thread Tom Lane
Clean up another pre-ANSI-C-ism in regex code: get rid of pcolor typedef. pcolor was used to represent function arguments that are nominally of type color, but when using a pre-ANSI C compiler would be passed as the promoted integer type. We really don't need that anymore. Branch -- master

[COMMITTERS] pgsql: reorderbuffer: preserve errno while reporting error

2016-08-19 Thread Alvaro Herrera
reorderbuffer: preserve errno while reporting error Clobbering errno during cleanup after an error is an oft-repeated, easy to make mistake. Deal with it here as everywhere else, by saving it aside and restoring after cleanup, before ereport'ing. In passing, add a missing errcode declaration in

[COMMITTERS] pgsql: reorderbuffer: preserve errno while reporting error

2016-08-19 Thread Alvaro Herrera
reorderbuffer: preserve errno while reporting error Clobbering errno during cleanup after an error is an oft-repeated, easy to make mistake. Deal with it here as everywhere else, by saving it aside and restoring after cleanup, before ereport'ing. In passing, add a missing errcode declaration in

[COMMITTERS] pgsql: reorderbuffer: preserve errno while reporting error

2016-08-19 Thread Alvaro Herrera
reorderbuffer: preserve errno while reporting error Clobbering errno during cleanup after an error is an oft-repeated, easy to make mistake. Deal with it here as everywhere else, by saving it aside and restoring after cleanup, before ereport'ing. In passing, add a missing errcode declaration in

[COMMITTERS] pgsql: reorderbuffer: preserve errno while reporting error

2016-08-19 Thread Alvaro Herrera
reorderbuffer: preserve errno while reporting error Clobbering errno during cleanup after an error is an oft-repeated, easy to make mistake. Deal with it here as everywhere else, by saving it aside and restoring after cleanup, before ereport'ing. In passing, add a missing errcode declaration in

[COMMITTERS] pgsql: Speed up planner's scanning for parallel-query hazards.

2016-08-19 Thread Tom Lane
Speed up planner's scanning for parallel-query hazards. We need to scan the whole parse tree for parallel-unsafe functions. If there are none, we'll later need to determine whether particular subtrees contain any parallel-restricted functions. The previous coding retained no knowledge from the fi

[COMMITTERS] pgsql: Guard against parallel-restricted functions in VALUES expression

2016-08-19 Thread Tom Lane
Guard against parallel-restricted functions in VALUES expressions. Obvious brain fade in set_rel_consider_parallel(). Noticed it while adjusting the adjacent RTE_FUNCTION case. In 9.6, also make the code look more like what I just did in HEAD by removing the unnecessary function_rte_parallel_ok

[COMMITTERS] pgsql: Guard against parallel-restricted functions in VALUES expression

2016-08-19 Thread Tom Lane
Guard against parallel-restricted functions in VALUES expressions. Obvious brain fade in set_rel_consider_parallel(). Noticed it while adjusting the adjacent RTE_FUNCTION case. In 9.6, also make the code look more like what I just did in HEAD by removing the unnecessary function_rte_parallel_ok

[COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn

2016-08-19 Thread Tom Lane
Use LEFT JOINs in some system views in case referenced row doesn't exist. In particular, left join to pg_authid so that rows in pg_stat_activity don't disappear if the session's owning user has been dropped. Also convert a few joins to pg_database to left joins, in the same spirit, though that cas

[COMMITTERS] pgsql: Allow empty queries in pgbench.

2016-08-19 Thread Tom Lane
Allow empty queries in pgbench. This might have been too much of a foot-gun before 9.6, but with the new commands-end-at-semicolons parsing rule, the only way to get an empty query into a script is to explicitly write an extra ";". So we may as well allow the case. Fabien Coelho Patch: Branch