Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control

2016-09-25 Thread Tom Lane
Peter Eisentraut writes: > pg_ctl: Detect current standby state from pg_control Coverity thinks that this patch introduced a bunch of null-pointer-dereference hazards, and AFAICS it is right. The change in get_controlfile()'s API is completely broken and needs to be undone.

[COMMITTERS] pgsql: Refer to OS X as "macOS", except for the port name which is stil

2016-09-25 Thread Tom Lane
Refer to OS X as "macOS", except for the port name which is still "darwin". We weren't terribly consistent about whether to call Apple's OS "OS X" or "Mac OS X", and the former is probably confusing to people who aren't Apple users. Now that Apple has rebranded it "macOS", follow their lead to es

Re: [COMMITTERS] pgsql: pg_ctl: Detect current standby state from pg_control

2016-09-25 Thread Michael Paquier
On Mon, Sep 26, 2016 at 12:54 AM, Tom Lane wrote: > Peter Eisentraut writes: >> pg_ctl: Detect current standby state from pg_control > > Coverity thinks that this patch introduced a bunch of > null-pointer-dereference hazards, and AFAICS it is right. > The change in get_controlfile()'s API is com