[COMMITTERS] pgsql: Fix hstore_plpython for Python 3.

2016-10-04 Thread Tom Lane
Fix hstore_plpython for Python 3. In commit d51924be8, I overlooked the need to provide linkage for PLyUnicode_FromStringAndSize, because that's only used (and indeed only exists) in Python 3 builds. In light of the need to #if this item, rearrange the ordering of the code related to each functio

[COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
Extend framework from commit 53be0b1ad to report latch waits. WaitLatch, WaitLatchOrSocket, and WaitEventSetWait now taken an additional wait_event_info parameter; legal values are defined in pgstat.h. This makes it possible to uniquely identify every point in the core code where we are waiting f

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Tom Lane
Robert Haas writes: > Extend framework from commit 53be0b1ad to report latch waits. Buildfarm doesn't like this one bit. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postg

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
On Tue, Oct 4, 2016 at 11:12 AM, Tom Lane wrote: > Robert Haas writes: >> Extend framework from commit 53be0b1ad to report latch waits. > > Buildfarm doesn't like this one bit. Hmm, and for good reason. But I swear I ran 'make check-world' before pushing. Argh. -- Robert Haas EnterpriseDB: h

[COMMITTERS] pgsql: Adjust worker_spi for 6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa.

2016-10-04 Thread Robert Haas
Adjust worker_spi for 6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/976a1ce91008944121d0b9d2b84c9644c36f7fbb Modified Files -- src/test/modules/worker_spi/worker_spi.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.

2016-10-04 Thread Robert Haas
On Tue, Oct 4, 2016 at 11:17 AM, Robert Haas wrote: > On Tue, Oct 4, 2016 at 11:12 AM, Tom Lane wrote: >> Robert Haas writes: >>> Extend framework from commit 53be0b1ad to report latch waits. >> >> Buildfarm doesn't like this one bit. > > Hmm, and for good reason. But I swear I ran 'make check-

[COMMITTERS] pgsql: Remove trailing commas from enums.

2016-10-04 Thread Robert Haas
Remove trailing commas from enums. Buildfarm member mylodon doesn't like them. Actually, I don't like them either, but I failed to notice these before pushing commit 6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/23843dcb60

[COMMITTERS] pgsql: Fix another outdated comment.

2016-10-04 Thread Heikki Linnakangas
Fix another outdated comment. Preloading is done by logtape.c now. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d4fca5e6c7363ba6ee4de7b8d72d68064fa864ca Modified Files -- src/backend/utils/sort/tuplesort.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[COMMITTERS] pgsql: Fix Windows compile break in 6f3bd98ebfc008cbd676da777bb0b2376c4

2016-10-04 Thread Robert Haas
Fix Windows compile break in 6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9445d1121d28d0a8ae32c907320b5d6ff985077b Modified Files -- src/backend/postmaster/pgstat.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[COMMITTERS] pgsql: Fix another Windows compile break.

2016-10-04 Thread Robert Haas
Fix another Windows compile break. Commit 6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa is still making the buildfarm unhappy. This time it's mastodon that is complaining. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6c9c95ed1b89add3a78d115a90e92d765b4c859a Modified

[COMMITTERS] pgsql: Improve (I hope) our autolocation of the Python shared library.

2016-10-04 Thread Tom Lane
Improve (I hope) our autolocation of the Python shared library. Older versions of Python produce garbage (or at least useless) values of get_config_vars('LDLIBRARY'). Newer versions produce garbage (or at least useless) values of get_config_vars('SO'), which was defeating our configure logic that

[COMMITTERS] pgsql: Huh, we do need to look in $python_configdir for the Python shli

2016-10-04 Thread Tom Lane
Huh, we do need to look in $python_configdir for the Python shlib. Debian does it that way, for no doubt what seems to them a good reason. Thanks to Aidan Van Dyk for confirmation. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fc76259f5b8473dbd3d2009b0e4a267cf3a7e7

[COMMITTERS] pgsql: Avoid direct cross-module links in hstore_plperl and ltree_plpyt

2016-10-04 Thread Tom Lane
Avoid direct cross-module links in hstore_plperl and ltree_plpython, too. Just turning the crank on the project started in commit d51924be8. These cases turn out to be exact subsets of the boilerplate needed for hstore_plpython. Discussion: <[email protected]> Branch -- master D