[COMMITTERS] pgsql: Simplify the code for logical tape read buffers.

2016-10-12 Thread Heikki Linnakangas
Simplify the code for logical tape read buffers. Pass the buffer size as argument to LogicalTapeRewindForRead, rather than setting it earlier with the separate LogicTapeAssignReadBufferSize call. This way, the buffer size is set closer to where it's actually used, which makes the code easier to un

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bb55dd6059dddf2cd44423da6a3f6946826953cf Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/69ade952e9c444e64c96465157b0e6b7456143db Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e611b11634aa48852a6c9f8ff2da5f80ffa61eb9 Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/086b99ec0987fcaacf192d018e8de7dd126fb8ac Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/3ccc15312b23fe283c7b63b3109229c16166745e Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Fix copy-pasto in comment.

2016-10-12 Thread Heikki Linnakangas
Fix copy-pasto in comment. Amit Langote Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6f020925223826cf457d8048b085b57674c525b7 Modified Files -- src/include/catalog/pg_cast.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pg

[COMMITTERS] pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve

2016-10-12 Thread Tom Lane
Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers. The need for dumping from such ancient servers has decreased to about nil in the field, so let's remove all the code that catered to it. Aside from removing a lot of boilerplate variant queries, this allows us to not have to cope

[COMMITTERS] pgsql: Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V

2016-10-12 Thread Tom Lane
Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V1 macro. This isn't really necessary for our own code, because we use a .DEF file in MSVC builds (see gendef.pl), or --export-all-symbols in MinGW and Cygwin builds, to ensure that all global symbols in loadable modules will be export

[COMMITTERS] pgsql: Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V

2016-10-12 Thread Tom Lane
Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V1 macro. This isn't really necessary for our own code, because we use a .DEF file in MSVC builds (see gendef.pl), or --export-all-symbols in MinGW and Cygwin builds, to ensure that all global symbols in loadable modules will be export

[COMMITTERS] pgsql: Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V

2016-10-12 Thread Tom Lane
Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V1 macro. This isn't really necessary for our own code, because we use a .DEF file in MSVC builds (see gendef.pl), or --export-all-symbols in MinGW and Cygwin builds, to ensure that all global symbols in loadable modules will be export

[COMMITTERS] pgsql: Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V

2016-10-12 Thread Tom Lane
Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V1 macro. This isn't really necessary for our own code, because we use a .DEF file in MSVC builds (see gendef.pl), or --export-all-symbols in MinGW and Cygwin builds, to ensure that all global symbols in loadable modules will be export

Re: [COMMITTERS] pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve

2016-10-12 Thread Peter Eisentraut
On 10/12/16 12:20 PM, Tom Lane wrote: > Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers. It looks like this or a related commit has caused these compiler warnings: pg_dump.c: In function 'getTypes': pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used [-Werror=unuse

[COMMITTERS] pgsql: Remove unnecessary int2vector-specific hash function and equalit

2016-10-12 Thread Tom Lane
Remove unnecessary int2vector-specific hash function and equality operator. These functions were originally added in commit d8cedf67a to support use of int2vector columns as catcache lookup keys. However, there are no catcaches that use such columns. (Indeed I now think it must always have been

Re: [COMMITTERS] pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve

2016-10-12 Thread Tom Lane
Peter Eisentraut writes: > On 10/12/16 12:20 PM, Tom Lane wrote: >> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers. > It looks like this or a related commit has caused these compiler warnings: > pg_dump.c: In function 'getTypes': > pg_dump.c:3692:8: error: variable 'i_typoutp

[COMMITTERS] pgsql: pg_dump's getTypes() needn't retrieve typinput or typoutput anym

2016-10-12 Thread Tom Lane
pg_dump's getTypes() needn't retrieve typinput or typoutput anymore. Commit 64f3524e2 removed the stanza of code that examined these values. I failed to notice they were unnecessary because my compiler didn't warn about the un-read variables. Noted by Peter Eisentraut. Branch -- master Deta

[COMMITTERS] pgsql: Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.

2016-10-12 Thread Tom Lane
Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro. This turns out not to be as harmless as I thought: MSVC will complain if it sees an "extern" declaration without PGDLLEXPORT and then one with. (Seems fairly silly, given that this can be changed after the fact by the linker, but there y

[COMMITTERS] pgsql: Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.

2016-10-12 Thread Tom Lane
Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro. This turns out not to be as harmless as I thought: MSVC will complain if it sees an "extern" declaration without PGDLLEXPORT and then one with. (Seems fairly silly, given that this can be changed after the fact by the linker, but there y

[COMMITTERS] pgsql: Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.

2016-10-12 Thread Tom Lane
Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro. This turns out not to be as harmless as I thought: MSVC will complain if it sees an "extern" declaration without PGDLLEXPORT and then one with. (Seems fairly silly, given that this can be changed after the fact by the linker, but there y

[COMMITTERS] pgsql: Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro.

2016-10-12 Thread Tom Lane
Revert addition of PGDLLEXPORT in PG_FUNCTION_INFO_V1 macro. This turns out not to be as harmless as I thought: MSVC will complain if it sees an "extern" declaration without PGDLLEXPORT and then one with. (Seems fairly silly, given that this can be changed after the fact by the linker, but there y

[COMMITTERS] pgsql: Remove spurious word.

2016-10-12 Thread Robert Haas
Remove spurious word. Tatsuo Ishii Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/248776ea06c240ae4605e77369d66bcd7ae4f9e3 Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Fix further hash table order dependent tests.

2016-10-12 Thread Andres Freund
Fix further hash table order dependent tests. Similar to 0137caf273, this makes contrib and pl tests less dependant on hash-table order. After this commit, at least some order affecting changes to execGrouping.c don't result in regression test changes anymore. Branch -- master Details -

[COMMITTERS] pgsql: Make pg_dumpall's database ACL query independent of hash table o

2016-10-12 Thread Andres Freund
Make pg_dumpall's database ACL query independent of hash table order. Previously GRANT order on databases was not well defined, due to the use of EXCEPT without an ORDER BY. Add an ORDER BY, adapt test output. I don't, at the moment, see reason to backpatch this. Branch -- master Details -

Re: [COMMITTERS] pgsql: Make pg_dumpall's database ACL query independent of hash table o

2016-10-12 Thread Andres Freund
On 2016-10-13 01:33:53 +, Andres Freund wrote: > Make pg_dumpall's database ACL query independent of hash table order. > > Previously GRANT order on databases was not well defined, due to the use > of EXCEPT without an ORDER BY. Add an ORDER BY, adapt test output. > > I don't, at the moment,

[COMMITTERS] pgsql: Fix broken jsonb_set() logic for replacing array elements.

2016-10-12 Thread Tom Lane
Fix broken jsonb_set() logic for replacing array elements. Commit 0b62fd036 did a fairly sloppy job of refactoring setPath() to support jsonb_insert() along with jsonb_set(). In its defense, though, there was no regression test case exercising the case of replacing an existing element in a jsonb

[COMMITTERS] pgsql: Fix broken jsonb_set() logic for replacing array elements.

2016-10-12 Thread Tom Lane
Fix broken jsonb_set() logic for replacing array elements. Commit 0b62fd036 did a fairly sloppy job of refactoring setPath() to support jsonb_insert() along with jsonb_set(). In its defense, though, there was no regression test case exercising the case of replacing an existing element in a jsonb