[COMMITTERS] pgsql: pg_dump: Fix minor memory leak

2017-01-23 Thread Peter Eisentraut
pg_dump: Fix minor memory leak Missing a destroyPQExpBuffer() in the early exit branch. The early exits aren't really necessary. Most similar functions just proceed running the rest of the code zero times and clean up at the end. Branch -- master Details --- http://git.postgresql.org/p

[COMMITTERS] pgsql: Fix typo

2017-01-23 Thread Peter Eisentraut
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/56549129079465a9d25fd6e5abc1439363922b7c Modified Files -- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committe

[COMMITTERS] pgsql: Volatile-ize some plperl variables that must survive into PG_CAT

2017-01-23 Thread Tom Lane
Volatile-ize some plperl variables that must survive into PG_CATCH blocks. This appears to be necessary to fix a failure seen on buildfarm member sittella. It shouldn't be necessary according to the letter of the C standard, because we don't change the values of these variables within the PG_TRY

[COMMITTERS] pgsql: Fix example plan in optimizer/README.

2017-01-23 Thread Tom Lane
Fix example plan in optimizer/README. Joining three tables only takes two join nodes. I think when I (tgl) wrote this, I was envisioning possible additional joins; but since the example doesn't show any fourth table, it's just confusing to write a third join node. Etsuro Fujita Discussion: htt

[COMMITTERS] pgsql: Prefetch blocks during lazy vacuum's truncation scan

2017-01-23 Thread Alvaro Herrera
Prefetch blocks during lazy vacuum's truncation scan Vacuum truncation scan can be sped up on rotating media by prefetching blocks in forward direction. That makes the blocks already present in memory by the time they are needed, while also letting OS read-ahead kick in. The truncate scan has be

[COMMITTERS] pgsql: Fix memory leaks in libpqwalreceiver

2017-01-23 Thread Peter Eisentraut
Fix memory leaks in libpqwalreceiver The results of the libpq functions PQescapeIdentifier() and PQescapeLiteral() must be freed explicitly. Also handle errors in these functions better. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/16a61884b5956778cae64a5746f4cdd

[COMMITTERS] pgsql: Fix pointer confusion

2017-01-23 Thread Peter Eisentraut
Fix pointer confusion get_object_address_publication_rel() needed to check *relation, not relation. Rename the variables to match style used nearby to avoid the confusion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6cffe54aef0a02a52692e32125eb3a5e135e7359 Modi

[COMMITTERS] pgsql: Fix NULL pointer access in logical replication workers

2017-01-23 Thread Peter Eisentraut
Fix NULL pointer access in logical replication workers From: Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/70c56a014e1813b5ab0f91581833bc7cb6c02958 Modified Files -- src/backend/replication/logical/launcher.c | 17 ++--- src/ba

[COMMITTERS] pgsql: Don't error when no system locales were found

2017-01-23 Thread Peter Eisentraut
Don't error when no system locales were found initdb used to warn about that, but it was changed to an error in pg_import_system_locales, but some build farm members failed because of that. Change it back to a warning. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff

[COMMITTERS] pgsql: Fix default minimum value for descending sequences

2017-01-23 Thread Peter Eisentraut
Fix default minimum value for descending sequences For some reason that is lost in history, a descending sequence would default its minimum value to -2^63+1 (-PG_INT64_MAX) instead of -2^63 (PG_INT64_MIN), even though explicitly specifying a minimum value of -2^63 would work. Fix this inconsisten

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7de7f80a5fd7d0eaddbcaf60881bdc85dc1f91d7 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/012691a04eb9b6e2e49722f57d440a31286f1715 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c3364a0267cca6dabae72a973bdfbe1d54083385 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9cb83818ccfa116309283cff1c01ca2b75670aa7 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
doc: Update URL for Microsoft download site Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f21f81c08e1667846df294ad03d04aca09544297 Modified Files -- doc/src/sgml/install-windows.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

Re: [COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
On 1/17/17 11:12 AM, Magnus Hagander wrote: > I suggest backpatching this. It will take a long time for the correct > link to reach "current" per the schedule we have now, and it will be > years with an incorrect link.. done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: [COMMITTERS] pgsql: doc: Update URL for Microsoft download site

2017-01-23 Thread Peter Eisentraut
On 1/17/17 11:25 AM, Tom Lane wrote: > Magnus Hagander writes: >> I suggest backpatching this. > > +1. Also, is the reference to "version 7.1", just above, still current? > Do we even want to try to track what the current version is? > I'd be inclined to delete that parenthetical remark. I don'

[COMMITTERS] pgsql: Fix parallel make issue with new fmgrprotos.h

2017-01-23 Thread Peter Eisentraut
Fix parallel make issue with new fmgrprotos.h The make rules needed further refinement so that we don't run multiple generations per build. reported by Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1a2d9a655a5de1c8c9d479c77d6351b878094606 Modified Files

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/73293ebae2e487828

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e4e5ea64c0

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/df9e034f95

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/557917769a

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a73cc3eff3

[COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
Fix comments in StrategyNotifyBgWriter(). The interface for the function was changed in d72731a70450b5e7084991b9caa15cb58a2820df but the comments of the function was not updated. Patch by Yugo Nagata. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0b7bcf7ad2

Re: [COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tom Lane
Tatsuo Ishii writes: > Fix comments in StrategyNotifyBgWriter(). [ confused... ] Surely this should only have been back-patched as far as 9.5? regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscri

Re: [COMMITTERS] pgsql: Fix comments in StrategyNotifyBgWriter().

2017-01-23 Thread Tatsuo Ishii
> Tatsuo Ishii writes: >> Fix comments in StrategyNotifyBgWriter(). > > [ confused... ] Surely this should only have been back-patched as > far as 9.5? Oops. You are right. I shouldn't have applied the patch against 9.4 or before. Will revert. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan

[COMMITTERS] pgsql: Revert "Fix comments in StrategyNotifyBgWriter()."

2017-01-23 Thread Tatsuo Ishii
Revert "Fix comments in StrategyNotifyBgWriter()." This reverts commit a73cc3eff3831d98ea3c6dbeb978b96f1bc72a42, which tried to fix the comments to reflect the change of API of the function but actually the change had been made only for 9.5 or later. Branch -- REL9_4_STABLE Details --- h

[COMMITTERS] pgsql: Revert "Fix comments in StrategyNotifyBgWriter()."

2017-01-23 Thread Tatsuo Ishii
Revert "Fix comments in StrategyNotifyBgWriter()." This reverts commit df9e034f958a5cd092f7f461d7a50156f6d076af, which tried to fix the comments to reflect the change of API of the function but actually the change had been made only for 9.5 or later. Branch -- REL9_3_STABLE Details --- h

[COMMITTERS] pgsql: Revert "Fix comments in StrategyNotifyBgWriter()."

2017-01-23 Thread Tatsuo Ishii
Revert "Fix comments in StrategyNotifyBgWriter()." This reverts commit 0b7bcf7ad2f1061664e6b517a3b4feabee0af00a, which tried to fix the comments to reflect the change of API of the function but actually the change had been made only for 9.5 or later. Branch -- REL9_2_STABLE Details --- h

[COMMITTERS] pgsql: Be sure to release the lock on failure to launch logical replica

2017-01-23 Thread Fujii Masao
Be sure to release the lock on failure to launch logical replication worker. Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dc82f5a6406dfef21ae1668b1c69a32c8a68c670 Modified Files -- src/backend/replication/logical/launcher.c | 1 + 1 file c

[COMMITTERS] pgsql: Mention logical replication tests in src/test/README.

2017-01-23 Thread Fujii Masao
Mention logical replication tests in src/test/README. Craig Ringer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3eaf03b5d331b7a06d79e5ad2be7e36c4a9c3d72 Modified Files -- src/test/README | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-com