[COMMITTERS] pgsql: test_pg_dump: perltidy cleanup

2017-01-31 Thread Stephen Frost
test_pg_dump: perltidy cleanup As pointed out by Alvaro, we actually use perltidy on the perl scripts in the source tree, so go back to the results of a perltidy run for the test_pg_dump TAP script. To make it look slightly less tragic, I changed most of the independent arguments into long-form s

[COMMITTERS] pgsql: test_pg_dump: perltidy cleanup

2017-01-31 Thread Stephen Frost
test_pg_dump: perltidy cleanup As pointed out by Alvaro, we actually use perltidy on the perl scripts in the source tree, so go back to the results of a perltidy run for the test_pg_dump TAP script. To make it look slightly less tragic, I changed most of the independent arguments into long-form s

[COMMITTERS] pgsql: perltidy pg_dump TAP tests

2017-01-31 Thread Stephen Frost
perltidy pg_dump TAP tests The pg_dump TAP tests have gotten pretty far from what perltidy thinks they should be, so fix that, and in passing use long-form argument names with arguments passed via "=" in a similar vein to 58da833. No functional changes here, just whitespace and changing runs from

[COMMITTERS] pgsql: pg_dump: Fix handling of ALTER DEFAULT PRIVILEGES

2017-01-31 Thread Stephen Frost
pg_dump: Fix handling of ALTER DEFAULT PRIVILEGES In commit 23f34fa, we changed how ACLs were handled to use the new pg_init_privs catalog and to dump out the ACL commands as REVOKE+GRANT combinations instead of trying to REVOKE all rights always and then GRANT back just the ones which were in pla

[COMMITTERS] pgsql: pg_dump: Fix handling of ALTER DEFAULT PRIVILEGES

2017-01-31 Thread Stephen Frost
pg_dump: Fix handling of ALTER DEFAULT PRIVILEGES In commit 23f34fa, we changed how ACLs were handled to use the new pg_init_privs catalog and to dump out the ACL commands as REVOKE+GRANT combinations instead of trying to REVOKE all rights always and then GRANT back just the ones which were in pla

[COMMITTERS] pgsql: Tweak catalog indexing abstraction for upcoming WARM

2017-01-31 Thread Alvaro Herrera
Tweak catalog indexing abstraction for upcoming WARM Split the existing CatalogUpdateIndexes into two different routines, CatalogTupleInsert and CatalogTupleUpdate, which do both the heap insert/update plus the index update. This removes over 300 lines of boilerplate code all over src/backend/cat

[COMMITTERS] pgsql: Move comment about test slightly closer to test.

2017-01-31 Thread Robert Haas
Move comment about test slightly closer to test. The addition of a TestForOldSnapshot() call here has made the referent of this comment slightly less clear, so move the comment to compensate. Amit Kapila (as part of the parallel index scan patch) Branch -- master Details --- http://git.