[COMMITTERS] pgsql: Cosmetic fixes for hash index write-ahead logging.

2017-03-15 Thread Robert Haas
Cosmetic fixes for hash index write-ahead logging. Amit Kapila. One of these was reported by Tom Lane. Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f7b711c8bcef46c67dc5345b983752ac833e51ad Modified Fi

[COMMITTERS] pgsql: Fix MB regression tests for WAL-logging of hash indexes.

2017-03-15 Thread Robert Haas
Fix MB regression tests for WAL-logging of hash indexes. Thomas Munro noted that these files still contained the now-removed deprecation message in the expected output. Patch by Amit Kapila Discussion: http://postgr.es/m/CAEepm=16hw_c+mba27aov9t4tqbu-vf1bt_yhrutwzvmd9b...@mail.gmail.com Branch

[COMMITTERS] pgsql: Add a regression test for snapshot too old with hash indexes.

2017-03-15 Thread Robert Haas
Add a regression test for snapshot too old with hash indexes. Amit Kapila, but I changed the comment not to be a copy-and-paste of an existing one, and instead referred to it. Discussion: http://postgr.es/m/CAA4eK1K0UJswCRf81WwJFO4H=+zvbmktnhaps-nkdmhrsq1...@mail.gmail.com Branch -- master

[COMMITTERS] pgsql: Add support for EUI-64 MAC addresses as macaddr8

2017-03-15 Thread Stephen Frost
Add support for EUI-64 MAC addresses as macaddr8 This adds in support for EUI-64 MAC addresses by adding a new data type called 'macaddr8' (using our usual convention of indicating the number of bytes stored). This was largely a copy-and-paste from the macaddr data type, with appropriate adjustme

Re: [COMMITTERS] pgsql: Remove objname/objargs split for referring to objects

2017-03-15 Thread Alvaro Herrera
Peter Eisentraut wrote: > Remove objname/objargs split for referring to objects I don't know if this is the guilty commit, but I'm now getting these compiler warnings: /pgsql/source/master/src/backend/catalog/objectaddress.c: In function 'get_object_address': /pgsql/source/master/src/backend/ca

[COMMITTERS] pgsql: Bump catversion for MACADDR8

2017-03-15 Thread Stephen Frost
Bump catversion for MACADDR8 Pointed out by Robert. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c5832346625af4193b1242e57e7d13e66a220b38 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sen

[COMMITTERS] pgsql: Fix failure to use clamp_row_est() for parallel joins.

2017-03-15 Thread Robert Haas
Fix failure to use clamp_row_est() for parallel joins. Commit 0c2070cefa0e5d097b715c9a3b9b5499470019aa neglected to use clamp_row_est() where it should have done so. Patch by me. Report by Amit Kapila. Discussion: http://postgr.es/m/[email protected]

[COMMITTERS] pgsql: Fix failure to use clamp_row_est() for parallel joins.

2017-03-15 Thread Robert Haas
Fix failure to use clamp_row_est() for parallel joins. Commit 0c2070cefa0e5d097b715c9a3b9b5499470019aa neglected to use clamp_row_est() where it should have done so. Patch by me. Report by Amit Kapila. Discussion: http://postgr.es/m/[email protected]

[COMMITTERS] pgsql: Rewrite async-connection loop in libpqwalreceiver.c, once again.

2017-03-15 Thread Tom Lane
Rewrite async-connection loop in libpqwalreceiver.c, once again. The original coding in commit 1e8a85009 didn't use PQconnectPoll per spec, and while the rewrite in e434ad39a is closer, it still doesn't guarantee to wait until the socket is read-ready or write-ready (as appropriate) before calling

[COMMITTERS] pgsql: Add more documentation and tests for publications

2017-03-15 Thread Peter Eisentraut
Add more documentation and tests for publications Add/correct documentation and add some tests related to how access control around adding tables to publications works. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e76db009f079ece9408e37336887bc6457cc1fc6 Modified

[COMMITTERS] pgsql: Fix typo

2017-03-15 Thread Peter Eisentraut
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f2a9998fb34c768d8870bd34daa4c298999fee00 Modified Files -- src/test/regress/expected/publication.out | 2 +- src/test/regress/sql/publication.sql | 2 +- 2 files changed, 2 insertions(+), 2 delet

[COMMITTERS] pgsql: Simplify publication/subscription tests a bit

2017-03-15 Thread Peter Eisentraut
Simplify publication/subscription tests a bit After testing RENAME TO, rename the object back. This reduces the merge mess when subsequent patches add test cases before or after the rename test. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd1827c7c961568eabe850d

[COMMITTERS] pgsql: Specify bindir in pg_isolation_regress_installcheck.

2017-03-15 Thread Andres Freund
Specify bindir in pg_isolation_regress_installcheck. It appears dcae5faccab64776376d3 forgot to add it to pg_isolation_regress_installcheck, while it was added to pg_regress_installcheck. It seems to so far have escaped notice, because buildfarm animals requiring it, didn't actually use pg_isolat

[COMMITTERS] pgsql: Port single-page btree vacuum logic to hash indexes.

2017-03-15 Thread Robert Haas
Port single-page btree vacuum logic to hash indexes. This is advantageous for hash indexes for the same reasons it's good for btrees: it accelerates space recycling, reducing bloat. Ashutosh Sharma, reviewed by Amit Kapila and by me. A bit of additional hacking by me. Discussion: http://postgr

[COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

2017-03-15 Thread Stephen Frost
Clean up overly paranoid checks in mac8.c Andres' compiler points out, quite correctly, that there's no need for some of the overly paranoid checks which were put into mac8.c. Remove those, as they're useless, add some comments and make a few other minor improvements- reduce the size of hexlookup

Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

2017-03-15 Thread Tom Lane
Stephen Frost writes: > Clean up overly paranoid checks in mac8.c termite thinks this wasn't quite right. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailp

Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

2017-03-15 Thread Stephen Frost
* Tom Lane ([email protected]) wrote: > Stephen Frost writes: > > Clean up overly paranoid checks in mac8.c > > termite thinks this wasn't quite right. Seems to be that termite's char is unsigned, will be fixing in a moment. Thanks! Stephen signature.asc Description: Digital signature

Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

2017-03-15 Thread Tom Lane
I wrote: > Stephen Frost writes: >> Clean up overly paranoid checks in mac8.c > termite thinks this wasn't quite right. On looking at it a bit more closely, I think you've forgotten that "char" is signed on some platforms and unsigned on others. I'd suggest putting explicit casts to unsigned ch

Re: [COMMITTERS] pgsql: Clean up overly paranoid checks in mac8.c

2017-03-15 Thread Stephen Frost
* Tom Lane ([email protected]) wrote: > I wrote: > > Stephen Frost writes: > >> Clean up overly paranoid checks in mac8.c > > > termite thinks this wasn't quite right. > > On looking at it a bit more closely, I think you've forgotten that > "char" is signed on some platforms and unsigned on oth

[COMMITTERS] pgsql: Be more careful about signed vs. unsigned char

2017-03-15 Thread Stephen Frost
Be more careful about signed vs. unsigned char The buildfarm has reminded me that not all systems consider char to be signed and we need to be explicit. Adjust the various bits of mac8.c for what we intend, mostly using casts to unsigned char as suggested by Tom, and adjust the tests for valid in