[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv

2017-03-17 Thread Heikki Linnakangas
Fix and simplify check for whether we're running as Windows service. If the process token contains SECURITY_SERVICE_RID, but it has been disabled by the SE_GROUP_USE_FOR_DENY_ONLY attribute, win32_is_service() would incorrectly report that we're running as a service. That situation arises, e.g. if

[COMMITTERS] pgsql: Allow plaintext 'password' authentication when user has a SCRAM

2017-03-17 Thread Heikki Linnakangas
Allow plaintext 'password' authentication when user has a SCRAM verifier. Oversight in the main SCRAM patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6305a9c572aaf3509ea90eec5127340dab89546 Modified Files -- src/backend/libpq/auth-scram.c | 46 ++

[COMMITTERS] pgsql: Add TAP tests for password-based authentication methods.

2017-03-17 Thread Heikki Linnakangas
Add TAP tests for password-based authentication methods. Tests all combinations of users with MD5, plaintext and SCRAM verifiers stored in pg_authid, with plain 'password', 'md5' and 'scram' authentication methods. Michael Paquier Branch -- master Details --- http://git.postgresql.org/p

Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-17 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> Hm, buildfarm results suggest this test is not entirely stable: I see it and will work on it. Tom> I have not looked very closely, but I'm suspicious that the test Tom> case depends on no autovacuum transactions running concurrently Tom> with it. Disabl

[COMMITTERS] pgsql: pageinspect: Add test for page_header function

2017-03-17 Thread Peter Eisentraut
pageinspect: Add test for page_header function Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a02731cb10535a6d5f66447295e7b8e22807f471 Modified Files -- contrib/pageinspect/expected/page.out | 6 ++ contrib/pageinspect/sql/page.sql | 2 ++ 2 files

Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-17 Thread Andrew Gierth
> "Andrew" == Andrew Gierth writes: Tom> I have not looked very closely, but I'm suspicious that the test Tom> case depends on no autovacuum transactions running concurrently Tom> with it. Disabling autovac on the table itself is not enough to Tom> control whether global xmin is being he

Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-17 Thread Robert Haas
On Thu, Mar 16, 2017 at 6:39 PM, Andrew Gierth wrote: > Avoid having vacuum set reltuples to 0 on non-empty relations in the > presence of page pins, which leads to serious estimation errors in the > planner. This particularly affects small heavily-accessed tables, > especially where locking (e.g

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7871d2a9cacf67ab1fd6704eb6be5f6bbdc39372 Modified Files -- doc/src/sgml/high-avai

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd9028b824c9c5f97795bb6b7b6f5ce38eb69f98 Modified Files -- doc/src/sgml/high-availabilit

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/da17ce6881f0c92086d1015351fcfad7e7098fb8 Modified Files -- doc/src/sgml/high-avai

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d0aebf02b0a076c438837bafbb502c14575a0d37 Modified Files -- doc/src/sgml/high-avai

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a84661215c0275942b3ecf3a023a8447c71338eb Modified Files -- doc/src/sgml/high-avai

[COMMITTERS] pgsql: Remove dead link.

2017-03-17 Thread Robert Haas
Remove dead link. David Christensen Discussion: http://postgr.es/m/[email protected] Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b04edf249c34daf9e9ca253a2a242e85bf6aea4b Modified Files -- doc/src/sgml/high-avai

Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-17 Thread Andrew Dunstan
On 03/17/2017 09:30 AM, Robert Haas wrote: > > In the department of nitpicks, we usually try to write commit messages > so that the first line is a summary line which stands alone, and then > there's a blank line, and then more follows. a la > https://chris.beams.io/posts/git-commit/#separate >

[COMMITTERS] pgsql: Rename "pg_clog" directory to "pg_xact".

2017-03-17 Thread Robert Haas
Rename "pg_clog" directory to "pg_xact". Names containing the letters "log" sometimes confuse users into believing that only non-critical data is present. It is hoped this renaming will discourage ill-considered removals of transaction status data. Michael Paquier Discussion: http://postgr.es/

Re: [COMMITTERS] pgsql: Rename "pg_clog" directory to "pg_xact".

2017-03-17 Thread Tom Lane
Robert Haas writes: > Rename "pg_clog" directory to "pg_xact". There should probably have been a catversion bump in here. regards, tom lane -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.post

Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-17 Thread Tom Lane
Andrew Dunstan writes: > On 03/17/2017 09:30 AM, Robert Haas wrote: >> In the department of nitpicks, we usually try to write commit messages >> so that the first line is a summary line which stands alone, and then >> there's a blank line, and then more follows. a la >> https://chris.beams.io/pos

[COMMITTERS] pgsql: Repair test for vacuum reltuples fix.

2017-03-17 Thread Andrew Gierth
Repair test for vacuum reltuples fix. Concurrent auto-analyze could be holding a snapshot, affecting the removal of deleted row versions. Remove the deletion to avoid this happening. Per buildfarm. In passing, make the test independent of assumptions of physical row order, just out of sheer par

[COMMITTERS] pgsql: Repair test for vacuum reltuples fix.

2017-03-17 Thread Andrew Gierth
Repair test for vacuum reltuples fix. Concurrent auto-analyze could be holding a snapshot, affecting the removal of deleted row versions. Remove the deletion to avoid this happening. Per buildfarm. In passing, make the test independent of assumptions of physical row order, just out of sheer par

[COMMITTERS] pgsql: pageinspect: Add page_checksum function

2017-03-17 Thread Peter Eisentraut
pageinspect: Add page_checksum function Author: Tomas Vondra Reviewed-by: Ashutosh Sharma Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fef2bcdcba0888c95ddf2a7535179c3b9a6a2f0e Modified Files -- contrib/pageinspect/expected/page.out | 6

Re: [COMMITTERS] pgsql: Rename "pg_clog" directory to "pg_xact".

2017-03-17 Thread Robert Haas
On Fri, Mar 17, 2017 at 10:04 AM, Tom Lane wrote: > Robert Haas writes: >> Rename "pg_clog" directory to "pg_xact". > > There should probably have been a catversion bump in here. I thought about it, but: [rhaas pgsql]$ git show --stat 88e66d193fbaf756b3cc9bf94cad116aacbb355b src/include/catalog

Re: [COMMITTERS] pgsql: Rename "pg_clog" directory to "pg_xact".

2017-03-17 Thread Tom Lane
Robert Haas writes: > On Fri, Mar 17, 2017 at 10:04 AM, Tom Lane wrote: >> There should probably have been a catversion bump in here. > I thought about it, but: > * The catalog version number is used to flag incompatible changes in > * the PostgreSQL system catalogs. Whenever anyone changes

[COMMITTERS] pgsql: Fix WaitEventSetWait() to handle write-ready waits properly on W

2017-03-17 Thread Tom Lane
Fix WaitEventSetWait() to handle write-ready waits properly on Windows. Windows apparently will not detect socket write-ready events unless a preceding send attempt returned WSAEWOULDBLOCK. In many usage patterns that's satisfied by the caller of WaitEvenSetWait(), but not always. Apply the same

[COMMITTERS] pgsql: Fix WaitEventSetWait() to handle write-ready waits properly on W

2017-03-17 Thread Tom Lane
Fix WaitEventSetWait() to handle write-ready waits properly on Windows. Windows apparently will not detect socket write-ready events unless a preceding send attempt returned WSAEWOULDBLOCK. In many usage patterns that's satisfied by the caller of WaitEvenSetWait(), but not always. Apply the same