[COMMITTERS] pgsql: dblink: Small code rearrangement for clarity

2017-04-05 Thread Peter Eisentraut
dblink: Small code rearrangement for clarity suggested by Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e59b74a3fc524a658172d9ec9f1728da89136bce Modified Files -- contrib/dblink/dblink.c | 12 ++-- 1 file changed, 6 insertions(+), 6 del

Re: [COMMITTERS] pgsql: dblink: Replace some macros by static functions

2017-04-05 Thread Peter Eisentraut
On 3/13/17 15:58, Tom Lane wrote: > In the same vein, I think this bit in dblink_open is pretty poor coding > practice: > > if (!rconn || !rconn->conn) > dblink_conn_not_avail(conname); > else > conn = rconn->conn; > > as it expects both the compiler and th

[COMMITTERS] pgsql: Add isolation test for SERIALIZABLE READ ONLY DEFERRABLE.

2017-04-05 Thread Kevin Grittner
Add isolation test for SERIALIZABLE READ ONLY DEFERRABLE. This improves code coverage and lays a foundation for testing similar issues in a distributed environment. Author: Thomas Munro Reviewed-by: Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4

[COMMITTERS] pgsql: hash: Fix write-ahead logging bug.

2017-04-05 Thread Robert Haas
hash: Fix write-ahead logging bug. The size of the data is not the same thing as the size of the size of the data. Reported off-list by Tushar Ahuja. Fix by Ashutosh Sharma, reviewed by Amit Kapila. Discussion: http://postgr.es/m/cae9k0pnmpdxfvf8hdobme7q_ewc4e26ukhxubpysoos0obq...@mail.gmail.c

[COMMITTERS] pgsql: doc: Remove remark elements

2017-04-05 Thread Peter Eisentraut
doc: Remove remark elements They were not rendered with DSSSL, but now they show up by default using XSLT. Just remove them, since they are not useful. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/63e5d02af33414ab31d0d59e02333083ac696d37 Modified Files -

[COMMITTERS] pgsql: Use American English in error message

2017-04-05 Thread Peter Eisentraut
Use American English in error message All error messages use the American English spelling of recognize, apply to the single one not doing so to be consistent. Author: Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6785fbd60ffd82ef825baf6db34bd94

[COMMITTERS] pgsql: Fix pageinspect failures on hash indexes.

2017-04-05 Thread Robert Haas
Fix pageinspect failures on hash indexes. Make every page in a hash index which isn't all-zeroes have a valid special space, so that tools like pageinspect don't error out. Also, make pageinspect cope with all-zeroes pages, because _hash_alloc_buckets can leave behind large numbers of those until

[COMMITTERS] pgsql: Spelling mistake in comment in utility.c

2017-04-05 Thread Simon Riggs
Spelling mistake in comment in utility.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ed770c325ca374fee7b3b66f5cb29af1a73a1743 Modified Files -- src/backend/tcop/utility.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Allow --with-wal-segsize=n up to n=1024MB

2017-04-05 Thread Simon Riggs
Allow --with-wal-segsize=n up to n=1024MB Other part of Beena Emerson's patch to allow testing Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/00b6b6feb12cef53737287b67ecef6aff1f1d8ab Modified Files -- configure | 6 +- configure.

[COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread Simon Riggs
Collect and use multi-column dependency stats Follow on patch in the multi-variate statistics patch series. CREATE STATISTICS s1 WITH (dependencies) ON (a, b) FROM t; ANALYZE; will collect dependency stats on (a, b) and then use the measured dependency in subsequent query planning. Commit 7b504e

[COMMITTERS] pgsql: Reduce lock level for CREATE STATISTICS

2017-04-05 Thread Simon Riggs
Reduce lock level for CREATE STATISTICS In line with other lock reductions related to planning. Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/68ea2b7f9b52d35b5fcd9c8d44d88de5a64be3ba Modified Files -- doc/src/sgml/mvcc.sgml | 3 +

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Fix integer-overflow problems in interval comparison.

2017-04-05 Thread Tom Lane
Fix integer-overflow problems in interval comparison. When using integer timestamps, the interval-comparison functions tried to compute the overall magnitude of an interval as an int64 number of microseconds. As reported by Frazer McLean, this overflows for intervals exceeding about 296000 years,

[COMMITTERS] pgsql: Code review for recent slot.c changes.

2017-04-05 Thread Andres Freund
Code review for recent slot.c changes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5c21ad07cc06f00f96e9401209a7da839b326d3a Modified Files -- src/backend/replication/slot.c | 48 +++--- 1 file changed, 22 insertions(

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu

[COMMITTERS] pgsql: Remove dead code and fix comments in fast-path function handling

2017-04-05 Thread Heikki Linnakangas
Remove dead code and fix comments in fast-path function handling. HandleFunctionRequest() is no longer responsible for reading the protocol message from the client, since commit 2b3a8b20c2. Fix the outdated comments. HandleFunctionRequest() now always returns 0, because the code that used to retu