[COMMITTERS] pgsql: Don't call the function that may raise an error while holding sp

2017-04-20 Thread Fujii Masao
Don't call the function that may raise an error while holding spinlock. It's not safe to raise an error while holding spinlock. But previously logical replication worker for table sync called the function which reads the system catalog and may raise an error while it's holding spinlock. Which coul

[COMMITTERS] pgsql: Mark some columns in pg_subscription as NOT NULL.

2017-04-20 Thread Fujii Masao
Mark some columns in pg_subscription as NOT NULL. In pg_subscription, subconninfo, subslotname, subsynccommit and subpublications are expected not to be NULL. Therefore this patch adds BKI_FORCE_NOT_NULL markings to them. This patch is basically unnecessary unless the code has a bug which wrongly

[COMMITTERS] pgsql: Prevent log_replication_commands from causing SQL commands to be

2017-04-20 Thread Fujii Masao
Prevent log_replication_commands from causing SQL commands to be logged. Commit 7c4f524 allowed walsender to execute normal SQL commands to support table sync feature in logical replication. Previously while log_statement caused such SQL commands to be logged, log_replication_commands caused them

[COMMITTERS] pgsql: Modify message when partitioned table is added to publication

2017-04-20 Thread Peter Eisentraut
Modify message when partitioned table is added to publication Give a more specific error message than "xyz is not a table". Also document in CREATE PUBLICATION which kinds of relations are not supported. based on patch by Amit Langote Branch -- master Details --- https://git.postgresq

[COMMITTERS] pgsql: Sync pg_ctl documentation and usage message with reality.

2017-04-20 Thread Tom Lane
Sync pg_ctl documentation and usage message with reality. Commit 05cd12ed5 ("pg_ctl: Change default to wait for all actions") was a tad sloppy about updating the documentation to match. The documentation was also sorely in need of a copy-editing pass, having been adjusted at different times by di

[COMMITTERS] pgsql: Improve multivariate statistics documentation

2017-04-20 Thread Alvaro Herrera
Improve multivariate statistics documentation Extended statistics commit 7b504eb282c did not include appropriate documentation next to where we document regular planner statistics (I ripped what was submitted before commit and then forgot to put it back), and while later commit 2686ee1b7ccf added

[COMMITTERS] pgsql: Add missing erand48.c to libpq/.gitignore.

2017-04-20 Thread Tom Lane
Add missing erand48.c to libpq/.gitignore. Oversight in commit 818fd4a67. While at it, sync order of file list in .gitignore with those in the Makefile. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77c316be7e6950990f21ba58f78ce67db1950fa9 Modified Files ---