[COMMITTERS] pgsql: Require sufficiently modern version of Test::More for TAP tests

2017-04-22 Thread Andrew Dunstan
Require sufficiently modern version of Test::More for TAP tests Ancient versions of Test::More don't support the note() function used in some TAP tests, so we require the minimum version of the module that does. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f92562

[COMMITTERS] pgsql: Make PostgresNode::append_conf append a newline automatically.

2017-04-22 Thread Tom Lane
Make PostgresNode::append_conf append a newline automatically. Although the documentation for append_conf said clearly that it didn't add a newline, many test authors seem to have forgotten that ... or maybe they just consulted the example at the top of the POD documentation, which clearly shows a

[COMMITTERS] pgsql: Make PostgresNode::append_conf append a newline automatically.

2017-04-22 Thread Tom Lane
Make PostgresNode::append_conf append a newline automatically. Although the documentation for append_conf said clearly that it didn't add a newline, many test authors seem to have forgotten that ... or maybe they just consulted the example at the top of the POD documentation, which clearly shows a

[COMMITTERS] pgsql: Make PostgresNode.pm check server status more carefully.

2017-04-22 Thread Tom Lane
Make PostgresNode.pm check server status more carefully. PostgresNode blithely ignored the exit status of pg_ctl, and in general made no effort to be sure that the server was running when it should be. This caused it to miss server crashes, which is a serious shortcoming in a test scaffold. Make

[COMMITTERS] pgsql: Make PostgresNode.pm check server status more carefully.

2017-04-22 Thread Tom Lane
Make PostgresNode.pm check server status more carefully. PostgresNode blithely ignored the exit status of pg_ctl, and in general made no effort to be sure that the server was running when it should be. This caused it to miss server crashes, which is a serious shortcoming in a test scaffold. Make