[COMMITTERS] pgsql: Rename WAL-related functions and views to use "lsn" not "locatio

2017-05-11 Thread Tom Lane
Rename WAL-related functions and views to use "lsn" not "location". Per discussion, "location" is a rather vague term that could refer to multiple concepts. "LSN" is an unambiguous term for WAL locations and should be preferred. Some function names, view column names, and function output argumen

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent a

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent a

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent a

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Add security checks to selectivity estimation functions

2017-05-11 Thread Peter Eisentraut
Add security checks to selectivity estimation functions Some selectivity estimation functions run user-supplied operators over data obtained from pg_statistic without security checks, which allows those operators to leak pg_statistic data without having privileges on the underlying tables. Fix by

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent a

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Further patch rangetypes_selfuncs.c's statistics slot management

2017-05-11 Thread Tom Lane
Further patch rangetypes_selfuncs.c's statistics slot management. Values in a STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM slot are float8, not of the type of the column the statistics are for. This bug is at least partly the fault of sloppy specification comments for get_attstatsslot()/free_attstatsslo

[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq. Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the, already then, deprecated requiressl parameter into conninfo_storeval(). The default PGREQUIRESSL environment variable was however lost in the change resulting in a potentially silent a

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Fix possibly-uninitialized variable.

2017-05-11 Thread Tom Lane
Fix possibly-uninitialized variable. Oversight in e2d4ef8de et al (my fault not Peter's). Per buildfarm. Security: CVE-2017-7484 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cad15943225adbcadea51602b38b04d71d1183d2 Modified Files -- src/back

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7603952e751a3b27adae16192b59ab09f0d0ba72 Modified Files -- doc/src/sgml/release-9.2.sgml | 125 ++

[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options. Both views replace the umoptions field with NULL when the user does not meet qualifications to see it. They used different qualifications, and pg_user_mappings documented qualifications did not match its implemented qualifi

[COMMITTERS] pgsql: Fix possibly-uninitialized variable.

2017-05-11 Thread Tom Lane
Fix possibly-uninitialized variable. Oversight in e2d4ef8de et al (my fault not Peter's). Per buildfarm. Security: CVE-2017-7484 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d3f3f95680701fb5f5bd8df603ec57d66b5b3d1b Modified Files -- src/back

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/73b1aee886a211b0438aa3fe4bcded7fd671c1e4 Modified Files -- doc/src/sgml/release-9.2.sgml | 125 ++

[COMMITTERS] pgsql: Fix possibly-uninitialized variable.

2017-05-11 Thread Tom Lane
Fix possibly-uninitialized variable. Oversight in e2d4ef8de et al (my fault not Peter's). Per buildfarm. Security: CVE-2017-7484 Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/703da179505e8bac2aa8ebdc600402338cc0f226 Modified Files -- src/back

[COMMITTERS] pgsql: Fix possibly-uninitialized variable.

2017-05-11 Thread Tom Lane
Fix possibly-uninitialized variable. Oversight in e2d4ef8de et al (my fault not Peter's). Per buildfarm. Security: CVE-2017-7484 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b6576e5914d042bfad1c8629fe199f59b036c342 Modified Files -- src/backend/uti

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2d5e7b4a912d55d90c01732d318b94e4ae47027b Modified Files -- doc/src/sgml/release-9.2.sgml | 125 ++

[COMMITTERS] pgsql: Further patch rangetypes_selfuncs.c's statistics slot management

2017-05-11 Thread Tom Lane
Further patch rangetypes_selfuncs.c's statistics slot management. Values in a STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM slot are float8, not of the type of the column the statistics are for. This bug is at least partly the fault of sloppy specification comments for get_attstatsslot()/free_attstatsslo

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/abba57b9af951242054bd9cc5ca84764c18649e6 Modified Files -- doc/src/sgml/release-9.2.sgml | 125 ++

[COMMITTERS] pgsql: Further patch rangetypes_selfuncs.c's statistics slot management

2017-05-11 Thread Tom Lane
Further patch rangetypes_selfuncs.c's statistics slot management. Values in a STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM slot are float8, not of the type of the column the statistics are for. This bug is at least partly the fault of sloppy specification comments for get_attstatsslot()/free_attstatsslo

[COMMITTERS] pgsql: Fix possibly-uninitialized variable.

2017-05-11 Thread Tom Lane
Fix possibly-uninitialized variable. Oversight in e2d4ef8de et al (my fault not Peter's). Per buildfarm. Security: CVE-2017-7484 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a199582ef6d56786cd21aab55bf8011a478ed2d4 Modified Files -- src/back

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89cd44cc50d3d82dc6f001ac357bedd96b8387d8 Modified Files -- doc/src/sgml/release-9.2.sgml | 125 ++

[COMMITTERS] pgsql: Further patch rangetypes_selfuncs.c's statistics slot management

2017-05-11 Thread Tom Lane
Further patch rangetypes_selfuncs.c's statistics slot management. Values in a STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM slot are float8, not of the type of the column the statistics are for. This bug is at least partly the fault of sloppy specification comments for get_attstatsslot()/free_attstatsslo

[COMMITTERS] pgsql: Last-minute updates for release notes.

2017-05-11 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2017-7484, CVE-2017-7485, CVE-2017-7486 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c89d2d0204f25e556e94dabd0fd5174cf6963b1d Modified Files -- doc/src/sgml/release-9.2.sgml | 125 +

[COMMITTERS] pgsql: Further patch rangetypes_selfuncs.c's statistics slot management

2017-05-11 Thread Tom Lane
Further patch rangetypes_selfuncs.c's statistics slot management. Values in a STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM slot are float8, not of the type of the column the statistics are for. This bug is at least partly the fault of sloppy specification comments for get_attstatsslot()/free_attstatsslo

[COMMITTERS] pgsql: Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensi

2017-05-11 Thread Tom Lane
Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensions. Increase from the historical value of 32 to 64. We are up to 31 callers of CacheRegisterSyscacheCallback() in HEAD, so if they were all to be exercised in one process that would leave only one slot for add-on modules. It's proba

[COMMITTERS] pgsql: Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensi

2017-05-11 Thread Tom Lane
Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensions. Increase from the historical value of 32 to 64. We are up to 31 callers of CacheRegisterSyscacheCallback() in HEAD, so if they were all to be exercised in one process that would leave only one slot for add-on modules. It's proba

[COMMITTERS] pgsql: Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensi

2017-05-11 Thread Tom Lane
Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensions. Increase from the historical value of 32 to 64. We are up to 31 callers of CacheRegisterSyscacheCallback() in HEAD, so if they were all to be exercised in one process that would leave only one slot for add-on modules. It's proba

[COMMITTERS] pgsql: Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensi

2017-05-11 Thread Tom Lane
Increase MAX_SYSCACHE_CALLBACKS to provide more room for extensions. Increase from the historical value of 32 to 64. We are up to 31 callers of CacheRegisterSyscacheCallback() in HEAD, so if they were all to be exercised in one process that would leave only one slot for add-on modules. It's proba

[COMMITTERS] pgsql: Doc fix: scale(numeric) returns integer, not numeric.

2017-05-11 Thread Tom Lane
Doc fix: scale(numeric) returns integer, not numeric. Thinko in commit abb173392, which introduced this function. Report: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4d4cdc5065d3a5396c

[COMMITTERS] pgsql: Doc fix: scale(numeric) returns integer, not numeric.

2017-05-11 Thread Tom Lane
Doc fix: scale(numeric) returns integer, not numeric. Thinko in commit abb173392, which introduced this function. Report: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/efa2c18f4e8a8ccc74d9005d9