[COMMITTERS] pgsql: Fix dumping of outer joins with empty qual lists.

2017-07-20 Thread Tom Lane
Fix dumping of outer joins with empty qual lists. Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The co

[COMMITTERS] pgsql: Fix dumping of outer joins with empty qual lists.

2017-07-20 Thread Tom Lane
Fix dumping of outer joins with empty qual lists. Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The co

[COMMITTERS] pgsql: Fix dumping of outer joins with empty qual lists.

2017-07-20 Thread Tom Lane
Fix dumping of outer joins with empty qual lists. Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The co

[COMMITTERS] pgsql: Fix dumping of outer joins with empty qual lists.

2017-07-20 Thread Tom Lane
Fix dumping of outer joins with empty qual lists. Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The co

[COMMITTERS] pgsql: Fix dumping of outer joins with empty qual lists.

2017-07-20 Thread Tom Lane
Fix dumping of outer joins with empty qual lists. Normally, a JoinExpr would have empty "quals" only if it came from CROSS JOIN syntax. However, it's possible to get to this state by specifying NATURAL JOIN between two tables with no common column names, and there might be other ways too. The co

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: Doc: clarify description of degenerate NATURAL joins.

2017-07-20 Thread Tom Lane
Doc: clarify description of degenerate NATURAL joins. Claiming that NATURAL JOIN is equivalent to CROSS JOIN when there are no common column names is only strictly correct if it's an inner join; you can't say e.g. CROSS LEFT JOIN. Better to explain it as meaning JOIN ON TRUE, instead. Per a sugg

[COMMITTERS] pgsql: In v10 release notes, call out sequence changes as a compatibili

2017-07-20 Thread Tom Lane
In v10 release notes, call out sequence changes as a compatibility item. The previous description didn't make it clear that this change potentially breaks applications, partly because the entry wasn't even in the compatibility-hazard section. Move and clarify. Discussion: https://postgr.es/m/60