[COMMITTERS] pgsql: Force rescanning of parallel-aware scan nodes below a Gather[Mer

2017-08-30 Thread Tom Lane
Force rescanning of parallel-aware scan nodes below a Gather[Merge]. The ExecReScan machinery contains various optimizations for postponing or skipping rescans of plan subtrees; for example a HashAgg node may conclude that it can re-use the table it built before, instead of re-reading its input su

[COMMITTERS] pgsql: Force rescanning of parallel-aware scan nodes below a Gather[Mer

2017-08-30 Thread Tom Lane
Force rescanning of parallel-aware scan nodes below a Gather[Merge]. The ExecReScan machinery contains various optimizations for postponing or skipping rescans of plan subtrees; for example a HashAgg node may conclude that it can re-use the table it built before, instead of re-reading its input su

[COMMITTERS] pgsql: Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b.

2017-08-30 Thread Tom Lane
Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b. Revert the reversion commits a20aac890 and 9b644745c. In the wake of commit 7df2c1f8d, we should get stable buildfarm results from this test; if not, I'd like to know sooner not later. Discussion: https://postgr.es/m/caa4ek1jkbyys

[COMMITTERS] pgsql: Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b.

2017-08-30 Thread Tom Lane
Restore test case from a2b70c89ca1a5fcf6181d3c777d82e7b83d2de1b. Revert the reversion commits a20aac890 and 9b644745c. In the wake of commit 7df2c1f8d, we should get stable buildfarm results from this test; if not, I'd like to know sooner not later. Discussion: https://postgr.es/m/caa4ek1jkbyys

[COMMITTERS] pgsql: Separate reinitialization of shared parallel-scan state from Exe

2017-08-30 Thread Tom Lane
Separate reinitialization of shared parallel-scan state from ExecReScan. Previously, the parallel executor logic did reinitialization of shared state within the ExecReScan code for parallel-aware scan nodes. This is problematic, because it means that the ExecReScan call has to occur synchronously

[COMMITTERS] pgsql: Separate reinitialization of shared parallel-scan state from Exe

2017-08-30 Thread Tom Lane
Separate reinitialization of shared parallel-scan state from ExecReScan. Previously, the parallel executor logic did reinitialization of shared state within the ExecReScan code for parallel-aware scan nodes. This is problematic, because it means that the ExecReScan call has to occur synchronously

[COMMITTERS] pgsql: Code review for nodeGatherMerge.c.

2017-08-30 Thread Tom Lane
Code review for nodeGatherMerge.c. Comment the fields of GatherMergeState, and organize them a bit more sensibly. Comment GMReaderTupleBuffer more usefully too. Improve assorted other comments that were obsolete or just not very good English. Get rid of the use of a GMReaderTupleBuffer for the

[COMMITTERS] pgsql: Code review for nodeGatherMerge.c.

2017-08-30 Thread Tom Lane
Code review for nodeGatherMerge.c. Comment the fields of GatherMergeState, and organize them a bit more sensibly. Comment GMReaderTupleBuffer more usefully too. Improve assorted other comments that were obsolete or just not very good English. Get rid of the use of a GMReaderTupleBuffer for the

[COMMITTERS] pgsql: Remove to pre-8.2 coding convention for PG_MODULE_MAGIC

2017-08-30 Thread Peter Eisentraut
Remove to pre-8.2 coding convention for PG_MODULE_MAGIC PG_MODULE_MAGIC has been around since 8.2, with 8.1 long since in EOL, so remove the mention of #ifdef guards for compiling against pre-8.2 sources from the documentation. Author: Daniel Gustafsson Branch -- master Details --- htt