Formatting of warning about using ident

2019-06-14 Thread Daniel Gustafsson
The warning about using ident for authorization or access control is using a with an rather than a , making it look quite different from the rest of the manual, and less like a warning IMO. https://www.postgresql.org/docs/devel/auth-ident.html The attached turns it into a and removes t

SPITupleTable members missing in docs

2019-06-14 Thread Daniel Gustafsson
Commit 3d13623d75d3206c8f009353415043a191ebab39 added the next and subid fields to the SPITupleTable struct, but they never made it into the documentation. While these are internal members, we already document several other internal ones (with a sentence on not using them) so add these too to make

Re: ATTACH/DETACH partitions and locking

2019-06-14 Thread Pavel Luzanov
On 13.06.2019 23:07, Alvaro Herrera wrote: On 2019-Jun-13, Pavel Luzanov wrote: Hello, According to patch[1] and after playing with v12 beta1 I think that this item can be dropped from "5.11.3. Implementation Using Inheritance" section of v12 docs: "Some operations require a stronger lock w

Re: SPITupleTable members missing in docs

2019-06-14 Thread Tom Lane
Daniel Gustafsson writes: > Commit 3d13623d75d3206c8f009353415043a191ebab39 added the next and subid > fields > to the SPITupleTable struct, but they never made it into the documentation. > While these are internal members, we already document several other internal > ones (with a sentence on not

Re: SPITupleTable members missing in docs

2019-06-14 Thread Daniel Gustafsson
> On 14 Jun 2019, at 16:15, Tom Lane wrote: > > Daniel Gustafsson writes: >> Commit 3d13623d75d3206c8f009353415043a191ebab39 added the next and subid >> fields >> to the SPITupleTable struct, but they never made it into the documentation. >> While these are internal members, we already document

Re: Mistake in documentation for CREATE STATISTICS

2019-06-14 Thread Tom Lane
PG Doc comments form writes: > The example on https://www.postgresql.org/docs/11/sql-createstatistics.html > seems wrong: instead of "EXPLAIN ANALYZE SELECT ..." it should say "EXPLAIN > SELECT ...". If changed that way, the query optimizer estimates the number > of rows at 1 and then 100 after st